Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PIMS-2001: Add ERP date for general user projects #2642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LawrenceLau2020 merged 5 commits into from
Aug 27, 2024
Merged

PIMS-2001: Add ERP date for general user projects #2642

LawrenceLau2020 merged 5 commits into from
Aug 27, 2024

Conversation

@LawrenceLau2020
Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 commented Aug 26, 2024

🎯 Summary

PIMS-2001:

  • Created a separate component for the ERP dates section
  • This will display when an ERP project has been approved and the 30, 60, 90 day notifications have been sent to CHES.
    image

Testing

  • You can either create a new and approved ERP project to see this new section, or just go to an existing project that has already sent the 30, 60, & 90 day notfications.
  • Please test to see that all user types can see this section.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@LawrenceLau2020 LawrenceLau2020 self-assigned this Aug 26, 2024
@github-actions
Copy link

github-actions bot commented Aug 26, 2024

🚀 Deployment Information

The React APP Image has been built with the tag: 2642. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

dbarkowsky
dbarkowsky approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything working well. Tested with admin and general user roles.

A few comments, but nothing breaking.

@LawrenceLau2020 LawrenceLau2020 merged commit 117fc0d into main Aug 27, 2024
@LawrenceLau2020 LawrenceLau2020 deleted the PIMS-2001 branch August 27, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbarkowsky dbarkowsky dbarkowsky approved these changes

@Sharala-Perumal Sharala-Perumal Awaiting requested review from Sharala-Perumal Sharala-Perumal is a code owner

@TaylorFries TaylorFries Awaiting requested review from TaylorFries TaylorFries is a code owner

@GrahamS-Quartech GrahamS-Quartech Awaiting requested review from GrahamS-Quartech

@ManishSihag ManishSihag Awaiting requested review from ManishSihag ManishSihag is a code owner

Assignees

@LawrenceLau2020 LawrenceLau2020

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LawrenceLau2020 @dbarkowsky