Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PIMS-1960: Allow Filter by Workflow Group in Projects #2702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LawrenceLau2020 merged 4 commits into from
Sep 26, 2024
Merged

PIMS-1960: Allow Filter by Workflow Group in Projects #2702

LawrenceLau2020 merged 4 commits into from
Sep 26, 2024

Conversation

@LawrenceLau2020
Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 commented Sep 24, 2024

🎯 Summary

PIMS-1960 - Allow Filter by Workflow Group in Projects

Changes

  • Modified the CustomMenuItem to take an optional prop for a style
  • Added a setFilterModel for the SPL Projects option

Testing

  • To test, you can make sure all 4 project statuses are included when filtering on the "SPL Projects" dropdown option on the projects page, may need to create a new project in your local env.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@LawrenceLau2020 LawrenceLau2020 self-assigned this Sep 24, 2024
@github-actions github-actions bot added the React label Sep 24, 2024
@github-actions
Copy link

github-actions bot commented Sep 24, 2024

🚀 Deployment Information

The React APP Image has been built with the tag: 2702. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

TaylorFries
TaylorFries approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filter works well. no issues detected

@LawrenceLau2020 LawrenceLau2020 merged commit dd6eb2c into main Sep 26, 2024
@LawrenceLau2020 LawrenceLau2020 deleted the PIMS-1960 branch September 26, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TaylorFries TaylorFries TaylorFries approved these changes

@Sharala-Perumal Sharala-Perumal Awaiting requested review from Sharala-Perumal Sharala-Perumal is a code owner

@dbarkowsky dbarkowsky Awaiting requested review from dbarkowsky dbarkowsky is a code owner

@ManishSihag ManishSihag Awaiting requested review from ManishSihag ManishSihag is a code owner

Assignees

@LawrenceLau2020 LawrenceLau2020

Labels

React

Projects

PIMS
Status: Closed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LawrenceLau2020 @TaylorFries