Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PIMS-2136 Filter Scroll #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dbarkowsky merged 2 commits into from
Oct 21, 2024
Merged

PIMS-2136 Filter Scroll #2728

dbarkowsky merged 2 commits into from
Oct 21, 2024

Conversation

@dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Oct 18, 2024 •
edited
Loading

🎯 Summary

PIMS-2136

Changes

  • Made the map filter area scrollable. Kept this scroll bar visually hidden.
  • Made the property lists in the sidebar and cluster popup only have the scroll on the Y axis. Didn't notice this before on Mac, but on Windows it shows a horizontal scrollbar otherwise.

Testing

  • Visually inspect the filter and property lists on the map for scroll function.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@dbarkowsky dbarkowsky self-assigned this Oct 18, 2024
@github-actions github-actions bot added the React label Oct 18, 2024
@github-actions
Copy link

github-actions bot commented Oct 18, 2024

🚀 Deployment Information

The React APP Image has been built with the tag: 2728. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

LawrenceLau2020
LawrenceLau2020 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, I'm able to scroll through each of the 3 sections on the map page: scrolling the map to zoom in and out, scrolling the filter section (had to increase resolution to test this), and scrolling through the properties on the right side are all working fine.

@dbarkowsky dbarkowsky merged commit eaf7cdf into main Oct 21, 2024
@dbarkowsky dbarkowsky deleted the PIMS-2136-Filter-Scroll branch October 21, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LawrenceLau2020 LawrenceLau2020 LawrenceLau2020 approved these changes

@Sharala-Perumal Sharala-Perumal Awaiting requested review from Sharala-Perumal Sharala-Perumal is a code owner

@TaylorFries TaylorFries Awaiting requested review from TaylorFries TaylorFries is a code owner

@ManishSihag ManishSihag Awaiting requested review from ManishSihag ManishSihag is a code owner

Assignees

@dbarkowsky dbarkowsky

Labels

React

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbarkowsky @LawrenceLau2020