Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PIMS-2139 Transparent ERP #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dbarkowsky merged 1 commit into from
Oct 23, 2024
Merged

PIMS-2139 Transparent ERP #2735

dbarkowsky merged 1 commit into from
Oct 23, 2024

Conversation

@dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Oct 22, 2024

🎯 Summary

PIMS-2139

Fixing an issue where the property row colour had a transparency. Was fine when over white, but not fine on the map.

Changes

  • Changed colour value of gold.light in the theme.
  • Change the colour in the propertyTable.css to match

Testing

  • find ERP properties on the map and in the property table. Confirm that colour is ok.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@dbarkowsky dbarkowsky self-assigned this Oct 22, 2024
@github-actions github-actions bot added the React label Oct 22, 2024
@github-actions
Copy link

github-actions bot commented Oct 22, 2024

🚀 Deployment Information

The React APP Image has been built with the tag: 2735. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

TaylorFries
TaylorFries approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERP properties no longer translucent on map
no issues noticed.

@dbarkowsky dbarkowsky merged commit e95d9b8 into main Oct 23, 2024
@dbarkowsky dbarkowsky deleted the PIMS-2139-Transparent-ERP branch October 23, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TaylorFries TaylorFries TaylorFries approved these changes

@LawrenceLau2020 LawrenceLau2020 Awaiting requested review from LawrenceLau2020 LawrenceLau2020 is a code owner

@Sharala-Perumal Sharala-Perumal Awaiting requested review from Sharala-Perumal Sharala-Perumal is a code owner

@ManishSihag ManishSihag Awaiting requested review from ManishSihag ManishSihag is a code owner

Assignees

@dbarkowsky dbarkowsky

Labels

React

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbarkowsky @TaylorFries