Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PIMS-2106: Address WAVA Scan Findings #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LawrenceLau2020 merged 3 commits into from
Nov 13, 2024
Merged

PIMS-2106: Address WAVA Scan Findings #2834

LawrenceLau2020 merged 3 commits into from
Nov 13, 2024

Conversation

@LawrenceLau2020
Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 commented Nov 8, 2024 •
edited
Loading

🎯 Summary

PIMS-2106

Changes

  • Added a few more security header policies to the nginx.conf (see Jira ticket for more details).

Testing

  • To test you will need to build and then run the react-app and the express-api as docker containers
    docker-compose build pims-app-v2 and docker-compose build pims-api-v2
    and then to run the containers: docker-compose up pims-app-v2 -d
  • Make sure everything works as expected, all images and styles are loading properly.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@LawrenceLau2020 LawrenceLau2020 self-assigned this Nov 8, 2024
@github-actions github-actions bot added the React label Nov 8, 2024
@github-actions
Copy link

github-actions bot commented Nov 8, 2024

🚀 Deployment Information

The React APP Image has been built with the tag: 2834. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

dbarkowsky
dbarkowsky requested changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't seem to have the satellite view working.
Issue is also in DEV, but not past that.
image

@dbarkowsky
Copy link
Collaborator

dbarkowsky commented Nov 13, 2024

Adding https://server.arcgisonline.com to the img-src seems to have solved the issue.

dbarkowsky
dbarkowsky approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working after latest arcgisonline addition.

@LawrenceLau2020 LawrenceLau2020 merged commit a6ee2da into main Nov 13, 2024
8 checks passed
@LawrenceLau2020 LawrenceLau2020 deleted the PIMS-2106-nginx branch November 13, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbarkowsky dbarkowsky dbarkowsky approved these changes

@Sharala-Perumal Sharala-Perumal Awaiting requested review from Sharala-Perumal Sharala-Perumal is a code owner

@TaylorFries TaylorFries Awaiting requested review from TaylorFries TaylorFries is a code owner

@ManishSihag ManishSihag Awaiting requested review from ManishSihag ManishSihag is a code owner

Assignees

@LawrenceLau2020 LawrenceLau2020

Labels

React

Projects

PIMS
Status: Closed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LawrenceLau2020 @dbarkowsky