Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dbarkowsky
Copy link
Collaborator

🎯 Summary

PIMS-2339

What I hope is the last addition to this ticket.
To account for the time differences in CHES (DEV seems to be fast to cancel, but TEST is slow), it will now try another three times if the first status request doesn't return cancelled. Hopefully this will resolve the race condition problem where their TEST server takes an additional second to actually cancel the notification behind the scenes.

Changes

  • Added else statement that retries up to three times if the initial status request after cancelation isn't successful.

Testing

  • Try to requeue a notification in the Pending status.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@github-actions
Copy link

🚀 Deployment Information

The Express API Image has been built with the tag: 3018. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

@Sharala-Perumal
Copy link
Collaborator

Sharala-Perumal commented Jul 10, 2025 via email

@dbarkowsky dbarkowsky merged commit 88e038c into main Jul 11, 2025
11 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-2339c branch July 11, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants