Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Pims 2339b #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dbarkowsky merged 6 commits into from
Jul 9, 2025
Merged

Pims 2339b #3012

dbarkowsky merged 6 commits into from
Jul 9, 2025

Conversation

@dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Jun 27, 2025

🎯 Summary

PIMS-2339

Changes from before were working in local and DEV, but not TEST for some reason.

So...

  • Adding a logger call to see what exactly is the state of the notification when this seems to fail.
  • Passed the user object down to the send notification call. Otherwise, there's a problem where the CHES override To variable needs to be set for this to work.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@dbarkowsky dbarkowsky self-assigned this Jun 27, 2025
@github-actions
Copy link

github-actions bot commented Jun 27, 2025

🚀 Deployment Information

The Express API Image has been built with the tag: 3012. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

@dbarkowsky dbarkowsky merged commit ce6af3a into main Jul 9, 2025
9 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-2339b branch July 9, 2025 15:23
dbarkowsky added a commit that referenced this pull request Jul 28, 2025
@dbarkowsky
Pims 2339b (#3012)
e45708a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LawrenceLau2020 LawrenceLau2020 LawrenceLau2020 approved these changes

@Sharala-Perumal Sharala-Perumal Awaiting requested review from Sharala-Perumal Sharala-Perumal is a code owner

@TaylorFries TaylorFries Awaiting requested review from TaylorFries TaylorFries is a code owner

@ManishSihag ManishSihag Awaiting requested review from ManishSihag ManishSihag is a code owner

Assignees

@dbarkowsky dbarkowsky

Labels

Express Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbarkowsky @LawrenceLau2020