Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Show correct file upload status #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2024
Merged

Show correct file upload status #185

merged 2 commits into from
Apr 8, 2024

Conversation

@TimCsaky
Copy link
Contributor

@TimCsaky TimCsaky commented Apr 5, 2024

Description

https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3549

  • Catch COMS error and show toast at component level
  • Simplify fileUpload template

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • [] I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions
Copy link

github-actions bot commented Apr 5, 2024

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

@TimCsaky TimCsaky force-pushed the bug/upload-complete branch from 3700a14 to feebcc2 Compare April 5, 2024 20:49
@github-actions
Copy link

github-actions bot commented Apr 5, 2024 •
edited
Loading

Coverage Report (Frontend)

Totals Coverage
Statements: 19.32% ( 697 / 3607 )
Methods: 18.41% ( 132 / 717 )
Lines: 23.22% ( 486 / 2093 )
Branches: 9.91% ( 79 / 797 )

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Apr 5, 2024 •
edited
Loading

Code Climate has analyzed commit 215b7da and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 20.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 24.5% (0.0% change).

View more on Code Climate.

@TimCsaky TimCsaky marked this pull request as ready for review April 5, 2024 20:51
@TimCsaky
Show file upload status
5ad82a3 
Catch COMS error and show toast at component level
Simplify fileUpload template
@TimCsaky TimCsaky force-pushed the bug/upload-complete branch from feebcc2 to 5ad82a3 Compare April 5, 2024 20:52
@TimCsaky TimCsaky force-pushed the bug/upload-complete branch 2 times, most recently from 18d78ba to 0700f6a Compare April 5, 2024 22:55
@TimCsaky TimCsaky force-pushed the bug/upload-complete branch from 0700f6a to 215b7da Compare April 5, 2024 22:58
@TimCsaky TimCsaky merged commit b26993f into master Apr 8, 2024
@TimCsaky TimCsaky deleted the bug/upload-complete branch April 8, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jatindersingh93 jatindersingh93 jatindersingh93 approved these changes

@norrisng-bc norrisng-bc norrisng-bc approved these changes

@kyle1morel kyle1morel Awaiting requested review from kyle1morel

@wilwong89 wilwong89 Awaiting requested review from wilwong89

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TimCsaky @jatindersingh93 @norrisng-bc