-
Notifications
You must be signed in to change notification settings - Fork 3
Use vee-validate for Invite form; multi-user invites #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Code Climate has analyzed commit 9a3ea0d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 23.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 24.3% (0.1% change). View more on Code Climate. |
ed72700 to
cc1cec3
Compare
| .array() | ||
| .transform(function (value, originalValue) { | ||
| if (this.isType(value) && value !== null) return value; | ||
| return originalValue ? originalValue.split(/[\r\n ,;]+/).filter((item: string) => item) : []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It splits by \n in addition to ,/;? I think we should also include that in the error message and the TextInput placeholder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah maybe. Tyler wanted to require comma or semicolon. so that's the preference.
but i think it could be useful to accept newlines as well which would allow for example, pasting from a spreadsheeet or a list in another document.
I guess these are questions for Tyler.
form validation for a list of invitee emails remove 'open' invite functionality
Description
Updates to the file/folder invite form
tickets:
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3673
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments