Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@TimCsaky
Copy link
Contributor

@TimCsaky TimCsaky commented May 31, 2024

Description

Updates to the file/folder invite form

  • use vee-validate composition api to validate form fields
  • add multi-email input
  • remove 'open' invites (not scoped to a user)

tickets:

https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3673

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

@github-actions
Copy link

github-actions bot commented May 31, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 19.25% ( 713 / 3704 )
Methods: 18.76% ( 136 / 725 )
Lines: 23.08% ( 496 / 2149 )
Branches: 9.76% ( 81 / 830 )

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented May 31, 2024

Code Climate has analyzed commit 9a3ea0d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 23.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 24.3% (0.1% change).

View more on Code Climate.

@TimCsaky TimCsaky marked this pull request as ready for review June 3, 2024 19:14
@TimCsaky TimCsaky changed the title Use vee-validate for Invite form Use vee-validate for Invite form; multi-user invites Jun 3, 2024
@TimCsaky TimCsaky force-pushed the multi-invite branch 2 times, most recently from ed72700 to cc1cec3 Compare June 3, 2024 19:51
.array()
.transform(function (value, originalValue) {
if (this.isType(value) && value !== null) return value;
return originalValue ? originalValue.split(/[\r\n ,;]+/).filter((item: string) => item) : [];
Copy link
Contributor

@norrisng-bc norrisng-bc Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It splits by \n in addition to ,/;? I think we should also include that in the error message and the TextInput placeholder.

Copy link
Contributor Author

@TimCsaky TimCsaky Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah maybe. Tyler wanted to require comma or semicolon. so that's the preference.
but i think it could be useful to accept newlines as well which would allow for example, pasting from a spreadsheeet or a list in another document.
I guess these are questions for Tyler.

form validation for a list of invitee emails
remove 'open' invite functionality
@norrisng-bc norrisng-bc merged commit 6bd2898 into master Jun 4, 2024
@norrisng-bc norrisng-bc deleted the multi-invite branch June 4, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants