Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@norrisng-bc
Copy link
Contributor

Description

This fixes the styling for the bulk results modal/table.

Previously:

  • Long email/results strings would wrap
  • Spacing was inadequate along the right side of the results column
  • The table/modal would be to narrow if the results string for all emails is short

Also, the DataTable's export-filename declaration was too lengthy, so it has been moved to a separate line.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

N/A

Adjust margins when there are many emails; do not wrap long emails/result strings
@github-actions
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 03e6e52 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 50.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 23.5% (0.0% change).

View more on Code Climate.

@github-actions
Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 18.15% ( 761 / 4193 )
Methods: 17.94% ( 141 / 786 )
Lines: 22.34% ( 537 / 2404 )
Branches: 8.28% ( 83 / 1003 )

@TimCsaky TimCsaky merged commit 0336a74 into master Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants