Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Elson9
Copy link
Contributor

@Elson9 Elson9 commented Jul 8, 2024

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change with enhancements to documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Contributor

@rustyjux rustyjux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works as expected in both interactive and when providing params along with generate-config.

One gripe is that when the suggestion is shown in the interactive (in the case of a service name conflict), the message disappears as soon as you start typing. More ideally, I feel like the message would persist while the user types or allow accepting the suggestion with a key press. But for now, I reckon this is a great improvement and in most cases just about any change the user makes will lead to avoiding a naming conflict.

Could also add testing.

@rustyjux rustyjux merged commit aac5b5f into feature/ns-to-gw Aug 1, 2024
@rustyjux rustyjux deleted the feature/service-validation branch August 1, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants