Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@bczernecki
Copy link
Owner

@bczernecki bczernecki commented Sep 27, 2025

This is a release candidate for climate 1.2.4 (note: mispelled branch name as 1.2.5)

  • Major bug fixes for ogimet-related retrievals due to changes in the OGIMET service
  • Minor fixes for reading stations' coordinates from ogimet_stations(). Increased accuracy and changed logic for detecting hemisphere
  • Adding hydro_imgw_datastore() to retrieve data for hydrological stations from IMGW-PIB repository datastore (telemetry system)
    • Adding stations_hydro_imgw_telemetry() to retrieve coordinates metadata for hydrological telemetry stations from IMGW-PIB

@bczernecki bczernecki changed the title Climate RC ver 1.2.5 Climate RC ver 1.2.4 Sep 28, 2025
@bczernecki bczernecki self-assigned this Sep 28, 2025
@bczernecki bczernecki requested a review from Nowosad September 28, 2025 14:03
@bczernecki bczernecki added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Sep 28, 2025
@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

❌ Patch coverage is 96.40719% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.19%. Comparing base (3adc64c) to head (2afce43).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
R/hydro_imgw_datastore.R 95.31% 3 Missing ⚠️
R/nearest_stations_imgw.R 77.77% 2 Missing ⚠️
R/stations_hydro_imgw_telemetry.R 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   89.36%   93.19%   +3.82%     
==========================================
  Files          30       32       +2     
  Lines        1693     1764      +71     
==========================================
+ Hits         1513     1644     +131     
+ Misses        180      120      -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@Nowosad Nowosad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bczernecki,

one question -- should there be a possibility to call the meteo_imgw_datastore function from meteo_imgw (similarly to meteo_imgw_daily, etc.)?

@Nowosad
Copy link
Collaborator

Nowosad commented Oct 1, 2025

Second question -- should all of the downloading functions return the same class as the output? Currently, imgw_telemetry returns a data table, and the rest (?) return data frames..

@Nowosad
Copy link
Collaborator

Nowosad commented Oct 1, 2025

(The rest seems good)

@bczernecki
Copy link
Owner Author

Second question -- should all of the downloading functions return the same class as the output? Currently, imgw_telemetry returns a data table, and the rest (?) return data frames..

We did that in previous version, but for hydrological dataset simple transition for 1 full year of dataset from data.table to data.frame with as.data.frame() for approx 50,000,000 rows takes ages and requires lot of RAM. Also data.table usually has both classes: data.frame and data.table, so theoretically we still under the same umbrella.

@bczernecki
Copy link
Owner Author

one question -- should there be a possibility to call the meteo_imgw_datastore function from meteo_imgw (similarly to meteo_imgw_daily, etc.)?

It will be addressed in a seperate issue #112

@bczernecki bczernecki merged commit 9260ca6 into master Oct 1, 2025
10 of 11 checks passed
@bczernecki bczernecki deleted the climate_rc_ver1_2_5 branch October 29, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

3 participants