- 
                Notifications
    You must be signed in to change notification settings 
- Fork 26
Climate RC ver 1.2.4 #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Climate RC ver 1.2.4 #111
Conversation
| Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   89.36%   93.19%   +3.82%     
==========================================
  Files          30       32       +2     
  Lines        1693     1764      +71     
==========================================
+ Hits         1513     1644     +131     
+ Misses        180      120      -60     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bczernecki,
one question -- should there be a possibility to call the meteo_imgw_datastore function from meteo_imgw (similarly to meteo_imgw_daily, etc.)?
| Second question -- should all of the downloading functions return the same class as the output? Currently, imgw_telemetry returns a data table, and the rest (?) return data frames.. | 
| (The rest seems good) | 
| 
 We did that in previous version, but for hydrological dataset simple transition for 1 full year of dataset from data.table to data.frame with  | 
| 
 It will be addressed in a seperate issue #112 | 
This is a release candidate for climate 1.2.4 (note: mispelled branch name as 1.2.5)
ogimet_stations(). Increased accuracy and changed logic for detecting hemispherehydro_imgw_datastore()to retrieve data for hydrological stations from IMGW-PIB repository datastore (telemetry system)stations_hydro_imgw_telemetry()to retrieve coordinates metadata for hydrological telemetry stations from IMGW-PIB