chore: get rid of legacy env injection for tailscale #1939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
65b5091 to
0475e73
Compare
0475e73 to
0847d38
Compare
eball
approved these changes
Oct 17, 2025
eball
added a commit
that referenced
this pull request
Oct 20, 2025
…eat/intranet_server * commit 'aeef6f602b5d5b0c9b109dc33893cdb33ab75889': (33 commits) chore(manifests): add required userenvs and remove currently unused ones (#1954) fix: unify shell env name of cdn service with sysenv (#1951) feat(integration): integration server (#1948) refactor: change download to DaemonSet and migrate to os-framework (#1942) feat(olares-app): update olares-app version to v1.5.8 (#1947) chore: clean up and migrate from legacy envs (#1946) tapr: fix minio policy was override when set multi bucket (#1945) system-server: fix rbac https provider bug (#1944) fix(app-service): retain legacy env rendering for migration (#1943) chore(manifests): clean up legacy env rendering in all files (#1941) olares: remove kubectl container from Olares.yaml (#1940) chore: get rid of legacy env injection for tailscale (#1939) Update docs/manual/get-started/install-olares.md system-server: add notification provider (#1938) feat(olares-app): update olares-app version to v1.5.7 (#1937) gpu(optimize): lower metrics collect interval to reduce lag (#1934) system-server: fix websocket rbac proxy tls bug (#1932) refactor: choose reverse proxy config during activation if enabled (#1935) fix: add addon charts image (#1931) adjust wording ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Clean up the explicit legacy env injection logic for tailscale in app-service, the SystemEnv for that is no longer needed and removed as well, it shouldn't have existed in the first place since there is already a single source of truth from the
corednsService and can be easily looked-up and injected during helm chart rendering.Target Version for Merge
1.12.2
Related Issues
none
PRs Involving Sub-Systems
chore: remove legacy env injection for tailscale app-service#340
Other information:
none