Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Jun 7, 2023

Hi, this is a very rudimentary migration of the wiki pages to within source

It should be compatible with readthedocs and once it is enabled, we can discuss any style changes that are wanted.

Closes #155

TODO:

  • Import/Export man page to and from markdown format (pandoc)

Signed-off-by: Cristian Le <[email protected]>
Copy link
Member

@sopos sopos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect commit d9f0104 is not really related to the readthedocs stuff.

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Jun 8, 2023

It is related. That one creates the python optional dependencies so that rtd can pull in the correct verisions of sphinx, etc. in the .readthedocs.yaml file

@sopos
Copy link
Member

sopos commented Jun 8, 2023

I have no clue how this works but it would be nice to generate the documentation from the sources directly.
The content of man.pod is actually the src/docs/pod/beakerlib.pod which is built by make.

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Jun 8, 2023

The content of man.pod is actually the src/docs/pod/beakerlib.pod which is built by make.

Thanks for the tip. Can you expand on this a bit, how is beakerlib.pod generated? Can it output a markdown file format? And what programs are needed to run relevant part of the make script?

it would be nice to generate the documentation from the sources directly

About that, could you enable the integration on https://readthedocs.org/ with PR support?

@sopos
Copy link
Member

sopos commented Jun 8, 2023

The content of man.pod is actually the src/docs/pod/beakerlib.pod which is built by make.

Thanks for the tip. Can you expand on this a bit, how is beakerlib.pod generated? Can it output a markdown file format? And what programs are needed to run relevant part of the make script?

Following will create the pod file.

cd src
make docs/pod/beakerlib.pod

AFAIK, perl is needed for it to work.
POD is the inline documentation which may be converted to various format using pod2* tools.

it would be nice to generate the documentation from the sources directly

About that, could you enable the integration on https://readthedocs.org/ with PR support?

I created a project there and enabled the PR builds https://beakerlib.readthedocs.io/en/latest/. Otherwise I have no experience with that. Not sure what all need to be set there. I may give you rights there.

@LecrisUT LecrisUT changed the base branch from master to devel June 8, 2023 19:05
@LecrisUT LecrisUT changed the base branch from devel to master June 8, 2023 19:05
@LecrisUT LecrisUT closed this Jun 8, 2023
@LecrisUT LecrisUT reopened this Jun 8, 2023
@LecrisUT
Copy link
Contributor Author

LecrisUT commented Jun 8, 2023

https://beakerlib--157.org.readthedocs.build/en/157/index.html

There we go. I'll try to get the pod2pandoc working tomorrow. Now for the actual documentation page, any preference or reference you want to have implemented?

@sopos
Copy link
Member

sopos commented Jun 9, 2023

https://beakerlib--157.org.readthedocs.build/en/157/index.html

There we go. I'll try to get the pod2pandoc working tomorrow. Now for the actual documentation page, any preference or reference you want to have implemented?

What kind of reference do you mean? Personally I have no preferences. As this is completely new thing, I would leave it on you. We can discuss / tweak the result later, if necessary.

LecrisUT added 4 commits June 9, 2023 17:11
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT
Copy link
Contributor Author

LecrisUT commented Jun 9, 2023

What kind of reference do you mean?

I was thinking if you had a documentation page you like and want to emulate.

Well the framework is more-or-less in place. Now it's just to actually make the pages as we want to. I would have preferred to use pandoc to get more control over the format, but pod2pandoc is not available on fedora for me to try it out.

Anyway, review please?

@LecrisUT LecrisUT requested a review from sopos June 9, 2023 15:42
@sopos
Copy link
Member

sopos commented Jun 13, 2023

Seems fine to me. @hegerj, could you take a look as well?

@hegerj
Copy link
Collaborator

hegerj commented Jun 15, 2023

Looks good to me, however I too have limited understanding of how it works.

@sopos
Copy link
Member

sopos commented Jun 21, 2023

@psss can I ask you for a quick review as someone with the readthedocs knowledge?

Copy link
Member

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@LecrisUT
Copy link
Contributor Author

@psss when you have the time, I had the idea for beakerlib/libraries#13, since it can touch tmt stuff as well. Would be nice to make them more visible and get more people on board to have reusable tests there.

@psss
Copy link
Member

psss commented Jun 21, 2023

Yeah, good idea to make them more visible. Added a comment there.

@sopos sopos merged commit 7d1e3a8 into beakerlib:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation

4 participants