-
Notifications
You must be signed in to change notification settings - Fork 39
Readthedocs #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readthedocs #157
Conversation
Signed-off-by: Cristian Le <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect commit d9f0104 is not really related to the readthedocs stuff.
|
It is related. That one creates the python optional dependencies so that rtd can pull in the correct verisions of sphinx, etc. in the |
|
I have no clue how this works but it would be nice to generate the documentation from the sources directly. |
Thanks for the tip. Can you expand on this a bit, how is
About that, could you enable the integration on https://readthedocs.org/ with PR support? |
Following will create the pod file. AFAIK,
I created a project there and enabled the PR builds https://beakerlib.readthedocs.io/en/latest/. Otherwise I have no experience with that. Not sure what all need to be set there. I may give you rights there. |
|
https://beakerlib--157.org.readthedocs.build/en/157/index.html There we go. I'll try to get the pod2pandoc working tomorrow. Now for the actual documentation page, any preference or reference you want to have implemented? |
What kind of reference do you mean? Personally I have no preferences. As this is completely new thing, I would leave it on you. We can discuss / tweak the result later, if necessary. |
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
I was thinking if you had a documentation page you like and want to emulate. Well the framework is more-or-less in place. Now it's just to actually make the pages as we want to. I would have preferred to use pandoc to get more control over the format, but Anyway, review please? |
|
Seems fine to me. @hegerj, could you take a look as well? |
|
Looks good to me, however I too have limited understanding of how it works. |
|
@psss can I ask you for a quick review as someone with the readthedocs knowledge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
@psss when you have the time, I had the idea for beakerlib/libraries#13, since it can touch tmt stuff as well. Would be nice to make them more visible and get more people on board to have reusable tests there. |
|
Yeah, good idea to make them more visible. Added a comment there. |
Signed-off-by: Cristian Le <[email protected]>
Hi, this is a very rudimentary migration of the wiki pages to within source
It should be compatible with readthedocs and once it is enabled, we can discuss any style changes that are wanted.
Closes #155
TODO:
pandoc)