Made removed game not appear #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR prevents games with missing install paths from appearing in listings and cache loads, and cleans up their cached assets without deleting the game record.
- Added
Directory.Existschecks inListGamesAsyncacross all platform libraries to skip games whose install paths are gone. - Introduced similar path validations in
LoadGamesFromCacheAsync, logging the issue and callingRemoveGameAssetsFromCacheAsyncinstead of dropping the game. - Added the
RemoveGameAssetsFromCacheAsyncmethod inGame.csto delete cached assets for a game.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Data/Xbox/XboxLibrary.cs | Added install-path guard in ListGamesAsync and cache load methods. |
| src/Data/UbisoftConnect/UbisoftConnectLibrary.cs | Inserted path-existence checks before DB save and cache load. |
| src/Data/Steam/SteamLibrary.cs | Added guard clauses on missing install paths in listing and cache load. |
| src/Data/ManuallyAdded/ManuallyAddedLibrary.cs | Validates path and cleans up assets when path is missing. |
| src/Data/Game.cs | New RemoveGameAssetsFromCacheAsync method to clear cached game assets. |
| src/Data/GOG/GOGLibrary.cs | Path existence validation and asset removal in cache loading. |
| src/Data/EpicGamesStore/EpicGamesStoreLibrary.cs | Added install-path checks and cache cleanup on missing paths. |
| src/Data/BattleNet/BattleNetLibrary.cs | Inserted path checks and asset cache removal in load-from-cache logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
When loading games from cache or libraries, if the install path is not found we don't proceed to add the game to the games list.
When this is triggered loading from cache we also remove GameAsset objects. This is because if the disappearing game folder is from a temporary issue we don't reset the game data (notes, history, etc). This data will be rebuilt if/when the game reappears.
Type of Change
Issues Resolved
#537