Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix memory resource unit for CRD deployment example in README.md #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yetone merged 1 commit into from
Sep 24, 2023
Merged

Fix memory resource unit for CRD deployment example in README.md #485

yetone merged 1 commit into from
Sep 24, 2023

Conversation

@Curt-Park
Copy link
Contributor

@Curt-Park Curt-Park commented Sep 24, 2023 •
edited
Loading

AS-IS

    resources:
        limits:
            cpu: "500m"
            memory: "512m"
        requests:
            cpu: "250m"
            memory: "128m"

512m for memory means 0.512 bytes. It doesn't look intended for this example.

Pay attention to the case of the suffixes. If you request 400m of memory, this is a request for 0.4 bytes. Someone who types that probably meant to ask for 400 mebibytes (400Mi) or 400 megabytes (400M).

https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#meaning-of-memory

TO-BE

    resources:
        limits:
            cpu: "500m"
            memory: "512Mi"
        requests:
            cpu: "250m"
            memory: "128Mi"

The memory resource unit for mebibytes is Mi. (megabytes is M)

@yetone
Copy link
Contributor

yetone commented Sep 24, 2023

LGTM

@yetone yetone merged commit 2aedacc into bentoml:main Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Curt-Park @yetone