-
Notifications
You must be signed in to change notification settings - Fork 132
fix broken player due to changes to variant a #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Variant a has changed so the data needs to be in a list if I don't know why the commit has so many changes.. I just removed the |
|
work for me |
trekshcool
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works!
|
Doesn't work for me, Im still having infinite loading |
Shuudy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just tested it and it works perfectly
How you do that on android ? |
|
Can I have a tut on how to do that ? I'm new to GitHub and Coding (Like new new) it would be nice, thank you :) |
You can just modify your src/app.js You go from this window.Worker = class Worker extends oldWorker {
constructor(twitchBlobUrl) {
super(twitchBlobUrl);
if (!isVariantA) {
this.addEventListener("message", (event) => {
const data = event.data;
if (data.id == 1 && data.type == 1) {
const newData = event.data;
newData.arg = [data.arg];
this.postMessage(newData);
}
});
}
}
}To this window.Worker = class Worker extends oldWorker {
constructor(twitchBlobUrl) {
super(twitchBlobUrl);
this.addEventListener("message", (event) => {
const data = event.data;
if ((data.id == 1 || isVariantA) && data.type == 1) {
const newData = event.data;
newData.arg = [data.arg];
this.postMessage(newData);
}
});
}
} |
Well this worked for me, thank a lot Shuudy have an amazing day ! :) |
|
i did all that but it didn't work |
Did you reload the extension in chrome? |
Same for me |
yeah i think i just have to wait for the new update |
|
Thanks the modification works for me |
Thanks, it works fine for me. |
|
The file path is this : src/app.js |
|
Works perfect, ty |
|
Im still really new to this and have very little understanding overall of this, but i was wondering where do i find and change all this coding stuff or whatever you call it to make the extension work. I`ve tried looking around but i cant find it. I tried to go to "src/app.js" but i still dont really know what im supposed to do |
|
Thank you so much :))) ! |
Hey @SewageBoikot Go on your TwitchNoSub folder open the app.js file in the src folder and then remove all the code and paste this one here enjoy and then add again your extension on the browser it worked for me ;) : |
|
Thank you soooo much! Been scratching my head for a week with this lol, but its finally working again |
|
Hello @yidichat, can you apply your update to the userscript file with the lastest version of master. And also apply the changes that was made in userscript to the src/app.js file |
besuper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
|
with the modification to this part all works. Just edit the code in downloadable files |
fixed issue #149