Fix BOOTGRACE arming disabled reset when motor protocol is DISABLED #9739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
reviewed
Apr 28, 2020
src/main/fc/core.c
Outdated
Member
There was a problem hiding this comment.
I'd probably even go for (!isMotorProtocolDshot() || dshotCommandsAreEnabled(DSHOT_CMD_TYPE_INLINE)) - no point to wait for Dshot commands for any non-Dshot protocols.
73361ad to
9ce1e6d
Compare
mikeller
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the motor protocol defaults to
DISABLEDtheBOOTGRACEarming disabled reason would never reset because DSHOT commands would never be enabled (because protocol wasn't DSHOT). The motor protocol has it's own arming disabled so it should not block the boot grace period timeout.