improve installation experience #281
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 9, 2025
f1ab3b7 to
3842e0f
Compare
b56a2bc to
2fce747
Compare
balupton
added a commit
that referenced
this pull request
Feb 21, 2025
This was referenced Mar 6, 2025
f23b717 to
77afaf1
Compare
/ref https://github.com/bevry/dorothy/actions/runs/18567569750/job/52932811944#step:4:400 this was the issue: ``` + /Users/balupton/.local/share/dorothy/sources/bash.bash [154] [__command_required] [2] get-installer --first-success --invoke --quiet -- '' + /Users/balupton/.local/share/dorothy/sources/bash.bash [156] [__command_required] [2] for COMMAND_REQUIRED__command in "${COMMAND_REQUIRED__commands[@]}" + /Users/balupton/.local/share/dorothy/sources/bash.bash [157] [__command_required] [2] __command_exists -- '' + /Users/balupton/.local/share/dorothy/sources/bash.bash [95] [__command_exists] [2] [[ -- == \-\- ]] + /Users/balupton/.local/share/dorothy/sources/bash.bash [96] [__command_exists] [2] shift + /Users/balupton/.local/share/dorothy/sources/bash.bash [98] [__command_exists] [2] __affirm_length_defined 1 command + /Users/balupton/.local/share/dorothy/sources/bash.bash [1441] [__affirm_length_defined] [2] [[ 2 -ne 1 ]] + /Users/balupton/.local/share/dorothy/sources/bash.bash [1441] [__affirm_length_defined] [2] [[ 2 -ne 2 ]] + /Users/balupton/.local/share/dorothy/sources/bash.bash [1446] [__affirm_length_defined] [2] [[ 1 =~ ^[0-9]+$ ]] + /Users/balupton/.local/share/dorothy/sources/bash.bash [1450] [__affirm_length_defined] [2] [[ 1 -eq 0 ]] + /Users/balupton/.local/share/dorothy/sources/bash.bash [100] [__command_exists] [2] local COMMAND_EXISTS__command + /Users/balupton/.local/share/dorothy/sources/bash.bash [101] [__command_exists] [2] for COMMAND_EXISTS__command in "$@" + /Users/balupton/.local/share/dorothy/sources/bash.bash [102] [__command_exists] [2] [[ '' == brew ]] + /Users/balupton/.local/share/dorothy/sources/bash.bash [109] [__command_exists] [2] type -P '' + /Users/balupton/.local/share/dorothy/sources/bash.bash [112] [__command_exists] [2] return 1 + /Users/balupton/.local/share/dorothy/sources/bash.bash [165] [__command_required] [2] return 104 ``` this also fixes wraps not showing on --verbose
the cause was `is-fedora` was mistaken /ref https://github.com/bevry/dorothy/actions/runs/18568283791/job/52935291763#step:4:333 /ref https://github.com/bevry/dorothy/actions/runs/18568283791/job/52935291763#step:4:630
wget1 is now being installed, but failing to detect, as `wget_binary` was not being updated to `wget1` https://github.com/bevry/dorothy/actions/runs/18568507438/job/52936078431#step:4:422
- fs-temp, *:
- use `TMPDIR` instead of `XDG_CACHE_HOME` by default, to prevent SSD wear
- fs-temp:
- support other types as well
- return root if no `--file` nor `--directory`
- no longer begin with `dorothy` as initial directory
- `bash.bash:__print_help`
- support error as arguments
it is 100x more performant than subshell process substitution `="$(printf ...)"`
especially around assocative arrays
the cask is no longer available
prep for eventual merge in `media-helper`
perhaps it should be re-added, however for now, workaround
update `echo-math` for `--rounding`, `--decimals`, `--trim`, and better debugging, also fix `fltexpr` failing when 0 is the result
fix double `in in <duration>` add tests eval-helper: fix a subsequent `--` not being respected correctly /ref d3a11a2
- `fs-{copy,link,move,remove}`: styled docs
- `fs-copy`: add `--backup`/`--quiet`, better default handling, fix rsync inserting a directory into a directory
- `fs-move`: prep new args, and call `fs-copy` on dir conflicts
- now delegates to the local dorothy if invoked remotely to prevent conflicts within commands - more streamlined detection and handling of dorothy and user configuration directories - create/update the repository in the existing/desired location, then migrate if necessary - prevents a `fs-move --merge` (and thus `rsync`) copy requirement
- trunk: upgrade cspell - fs-type: alma has same output as opensuse - setup-util-mediainfo: support more distros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Closes:
dorothy installandsetup-system updateattempt to symlink$DOROTHYto itself on macOS 15.4 arm64 #294setup-util-brew --uninstallhas several flows that requiresbrew#278eval_capturehas a race condition that can cause CI to fail #277setup-shellwhen no configuration should prompt which shell to use #271setup-utilsupport for streamlined{bin,man,lib,etc}extraction #223fs-dirnameshould support non-existing paths #153May close:
Improves:
setup-environment-commandsfor faster initialisation #290get-installerintosetup-util, such that I can dosetup-util --cli='thing'and it'll work #282Discards old implementation of:
Todos:
Current batch todos, in any order:
setup-shellflowsetup-util-$shellflow remove uninstalled login shell, without endless recursion - I've added an exclude option, however need to finish implementing ituse_shellsempty by default, as otherwise everything is selected for login shellconfig-helperecho-waitecho-fileis-touchable--sudoflag to--elevatein all relevant locationseval-helperandsudo-helpershould be merged, or need a neweval-targetcommand, to avoid conflating stderr output in no-tty mode (achieved by new__dofunction)__doand__tryfunctionsecho-waitcleanupget-installerto use a json file, so it can run on bash v3 which will fixdorothy-configfailing on old bash versions.sudo --stdinflag when neededstyles.bashenv vars preset tosetup-environment-commandsget-terminal-themeon WSL