Store hash before decoding, do not parse broken file twice #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjeker
approved these changes
Mar 1, 2024
Contributor
cjeker
left a comment
There was a problem hiding this comment.
Looks good. Could you also change the log message from info to debug?
460d315 to
4c1c8fa
Compare
Collaborator
Author
|
Tested locally. Inconclusive results because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny tweak. My previous interpretation (but have not tested it) is that a SLURM or JSON file that fails to parse will be parsed every time.
Trivial change. Prevents a series of "updating from x to y" when y is in fact not parseable.