feat: handle workspace/configuration requests for config path in v2
#77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
reviewed
Mar 14, 2025
src/biome.rs
Outdated
| zed::npm_package_installed_version(PACKAGE_NAME) | ||
| .ok() | ||
| .flatten() | ||
| .is_none_or(|version| version.starts_with("2.")) |
There was a problem hiding this comment.
I suggest checking v1 instead, so even future versions like V3, v4, etc. will be compatible.
It's more future proof
There was a problem hiding this comment.
Yeah it makes sense, fixed in 4054066
ematipico
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75
Added support of
workspace/configurationLSP requests to provide the configuration to Biome v2.0. In Biome v2, we will drop--config-pathin favour of the LSP request. For backward compatibility, we keep using--config-pathfor Biome v1.