fix(linter): fix recursive hooks #6931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6ee95f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dd3890f to
fb686a9
Compare
fb686a9 to
bb87586
Compare
bb87586 to
283e612
Compare
CodSpeed Performance ReportMerging #6931 will not alter performanceComparing Summary
|
ematipico
approved these changes
Jul 18, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed #6915:
useHookAtTopLevelno longer hangs when rules call themselves recursively.Test Plan
Tests added. Added one for
useHookAtTopLevelto check indirect recursion, and another in the CLI tests to make sure other rules don't trip over it either (but stopped short of enabled all rules, since we don't have a convenient config setting for that 😅 ).