Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(analyse/js): add noNonNullAssertedOptionalChain rule #7100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 5, 2025
Merged

feat(analyse/js): add noNonNullAssertedOptionalChain rule #7100

merged 4 commits into from
Aug 5, 2025

Conversation

@Jayllyz
Copy link
Contributor

@Jayllyz Jayllyz commented Aug 4, 2025

Summary

Add https://typescript-eslint.io/rules/no-non-null-asserted-optional-chain/ rule, named noNonNullAssertedOptionalChain.

Test Plan

Imported tests cases from eslint : here

Docs

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Aug 4, 2025
@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 3d895df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the A-CLI Area: CLI label Aug 4, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 4, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #7100 will not alter performance

Comparing Jayllyz:feat/no-non-null-asserted-opt-chain (3d895df) with main (655049e)1

Summary

✅ 128 untouched benchmarks

Footnotes

  1. No successful run was found on main (6cc84cb) during the generation of this report, so 655049e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@Jayllyz Jayllyz marked this pull request as ready for review August 4, 2025 21:44
arendjr
arendjr approved these changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@arendjr
Copy link
Contributor

arendjr commented Aug 5, 2025

I see some conflicts occurred. If you rebase on main and rerun the codegen, they should resolve themselves.

@Jayllyz Jayllyz force-pushed the feat/no-non-null-asserted-opt-chain branch from 4b3d172 to 3d895df Compare August 5, 2025 08:01
@arendjr arendjr merged commit 29fcb05 into biomejs:main Aug 5, 2025
31 checks passed
@github-actions github-actions bot mentioned this pull request Aug 5, 2025
Merged
@Jayllyz Jayllyz deleted the feat/no-non-null-asserted-opt-chain branch August 5, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arendjr arendjr arendjr approved these changes

Assignees

No one assigned

Labels

A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jayllyz @arendjr