-
-
Notifications
You must be signed in to change notification settings - Fork 728
chore(coderabbit): dont review generated files #7172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughA new Possibly related PRs
Suggested reviewers
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.coderabbit.yaml (1)
15-15: Improve readability: switch to a multiline list.Easier to maintain and review diffs when patterns change.
- path_filters: ["**", "!**/generated/**", "!**/biome_unicode_table/src/tables.rs", "!**/migrate/eslint_any_rule_to_biome.rs", "!**/nursery.rs", "!**/categories.rs", "!**/rules.rs", "!**/configuration_schema.json", "!**/backend-jsonrpc/src/workspace.ts"] + path_filters: + - "**" + - "!**/generated/**" + - "!**/biome_unicode_table/src/tables.rs" + - "!**/migrate/eslint_any_rule_to_biome.rs" + - "!**/nursery.rs" + - "!**/categories.rs" + - "!**/rules.rs" + - "!**/configuration_schema.json" + - "!**/backend-jsonrpc/src/workspace.ts"
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.coderabbit.yaml(1 hunks)
🔇 Additional comments (2)
.coderabbit.yaml (2)
15-15: Path filters look correct and schema-compliant.Includes everything, then excludes known generated artefacts. Nice and tidy.
15-15: Manual verification needed: confirm excluded pathsThe sandbox couldn’t show which files are actually dropped by your filters. Please run this locally and share the results:
git ls-files \ | grep -E '(^|/)(generated/|biome_unicode_table/src/tables\.rs|migrate/eslint_any_rule_to_biome\.rs|nursery\.rs|categories\.rs|rules\.rs|configuration_schema\.json|backend-jsonrpc/src/workspace\.ts)$'That’ll list everything your
!…patterns exclude so we can be sure nothing critical slips through.
b5e91cc to
99af763
Compare
Summary
Ignore generated files for Coderabbit
Test Plan
N/A
Docs
N/A