biomejs · ematipico · Aug 24, 2025 · Aug 22, 2025 · Aug 24, 2025
diff --git a/.changeset/seven-glasses-attack.md b/.changeset/seven-glasses-attack.md
@@ -0,0 +1,14 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [#7130](https://github.com/biomejs/biome/issues/7130). Removed the emission of a false-positive diagnostic. Biome no longer emits the following diagnostic:
+```
+lib/main.ts:1:5 suppressions/unused ━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ⚠ Suppression comment has no effect because the tool is not enabled.
+
+  > 1 │ /** biome-ignore-all assist/source/organizeImports: For the lib root file, we don't want to organize exports */
+      │     ^^^^^^^^^^^^^^^^
+
+```
diff --git a/crates/biome_analyze/src/lib.rs b/crates/biome_analyze/src/lib.rs
@@ -88,8 +88,6 @@ pub struct Analyzer<'analyzer, L: Language, Matcher, Break, Diag> {
     suppression_action: Box<dyn SuppressionAction<Language = L>>,
     /// Handles analyzer signals emitted by individual rules
     emit_signal: SignalHandler<'analyzer, L, Break>,
-    /// The rule categories used during the run of the analyzer
-    categories: RuleCategories,
 }
 
 pub struct AnalyzerContext<'a, L: Language> {
@@ -113,7 +111,6 @@ where
         parse_suppression_comment: SuppressionParser<Diag>,
         suppression_action: Box<dyn SuppressionAction<Language = L>>,
         emit_signal: SignalHandler<'analyzer, L, Break>,
-        categories: RuleCategories,
     ) -> Self {
         Self {
             phases: BTreeMap::new(),
@@ -123,7 +120,6 @@ where
             parse_suppression_comment,
             suppression_action,
             emit_signal,
-            categories,
         }
     }
 
@@ -150,7 +146,6 @@ where
             mut emit_signal,
             suppression_action,
             metadata: _,
-            categories,
         } = self;
 
         let mut line_index = 0;
@@ -171,7 +166,6 @@ where
                 suppression_action: suppression_action.as_ref(),
                 options: ctx.options,
                 suppressions: &mut suppressions,
-                categories,
                 deny_top_level_suppressions: false,
             };
 
@@ -329,8 +323,6 @@ struct PhaseRunner<'analyzer, 'phase, L: Language, Matcher, Break, Diag> {
     options: &'phase AnalyzerOptions,
     /// Tracks all suppressions during the analyzer phase
     suppressions: &'phase mut Suppressions<'analyzer>,
-    /// The current categories
-    categories: RuleCategories,
     /// Whether we have already encountered a token that can't precede top level suppressions
     deny_top_level_suppressions: bool,
 }
@@ -573,18 +565,6 @@ where
                 (self.emit_signal)(&signal)?;
             }
 
-            if !self.categories.contains(suppression.category) {
-                let signal = DiagnosticSignal::new(|| {
-                    AnalyzerSuppressionDiagnostic::new(
-                        category!("suppressions/unused"),
-                        suppression.ignore_range.unwrap_or(range),
-                        "Suppression comment has no effect because the tool is not enabled.",
-                    )
-                });
-                (self.emit_signal)(&signal)?;
-                continue;
-            }
-
             if let Err(diagnostic) = self.suppressions.push_suppression(
                 &suppression,
                 range,

diff --git a/crates/biome_analyze/src/matcher.rs b/crates/biome_analyze/src/matcher.rs
@@ -210,8 +210,8 @@ mod tests {
     use super::MatchQueryParams;
     use crate::{
         Analyzer, AnalyzerContext, AnalyzerSignal, ApplySuppression, ControlFlow, MetadataRegistry,
-        Never, Phases, QueryMatcher, RuleCategories, RuleCategory, RuleKey, ServiceBag,
-        SignalEntry, SuppressionAction, SyntaxVisitor, signals::DiagnosticSignal,
+        Never, Phases, QueryMatcher, RuleCategory, RuleKey, ServiceBag, SignalEntry,
+        SuppressionAction, SyntaxVisitor, signals::DiagnosticSignal,
     };
     use crate::{AnalyzerOptions, AnalyzerSuppression};
     use biome_diagnostics::{Diagnostic, Severity};
@@ -425,7 +425,6 @@ mod tests {
             parse_suppression_comment,
             Box::new(TestAction),
             &mut emit_signal,
-            RuleCategories::all(),
         );
 
         analyzer.add_visitor(Phases::Syntax, Box::<SyntaxVisitor<RawLanguage>>::default());

diff --git a/crates/biome_analyze/src/registry.rs b/crates/biome_analyze/src/registry.rs
@@ -1,6 +1,6 @@
 use crate::{
-    AddVisitor, AnalysisFilter, GroupCategory, QueryMatcher, Rule, RuleCategories, RuleGroup,
-    RuleKey, RuleMetadata, ServiceBag, SignalEntry, Visitor,
+    AddVisitor, AnalysisFilter, GroupCategory, QueryMatcher, Rule, RuleGroup, RuleKey,
+    RuleMetadata, ServiceBag, SignalEntry, Visitor,
     context::RuleContext,
     matcher::{GroupKey, MatchQueryParams},
     query::{QueryKey, Queryable},
@@ -240,7 +240,6 @@ type BuilderResult<L> = (
     ServiceBag,
     Vec<Error>,
     BTreeMap<(Phases, TypeId), Box<dyn Visitor<Language = L>>>,
-    RuleCategories,
 );
 
 impl<L: Language> RuleRegistryBuilder<'_, L> {
@@ -250,7 +249,6 @@ impl<L: Language> RuleRegistryBuilder<'_, L> {
             self.services,
             self.diagnostics,
             self.visitors,
-            self.filter.categories,
         )
     }
 }

diff --git a/crates/biome_analyze/src/syntax.rs b/crates/biome_analyze/src/syntax.rs
@@ -100,8 +100,8 @@ mod tests {
 
     use crate::{
         Analyzer, AnalyzerContext, AnalyzerOptions, AnalyzerSignal, ApplySuppression, ControlFlow,
-        MetadataRegistry, Never, QueryMatcher, RuleCategoriesBuilder, ServiceBag,
-        SuppressionAction, SyntaxVisitor, matcher::MatchQueryParams, registry::Phases,
+        MetadataRegistry, Never, QueryMatcher, ServiceBag, SuppressionAction, SyntaxVisitor,
+        matcher::MatchQueryParams, registry::Phases,
     };
 
     #[derive(Default)]
@@ -191,7 +191,6 @@ mod tests {
             |_, _| -> Vec<Result<_, Infallible>> { unreachable!() },
             Box::new(TestAction),
             &mut emit_signal,
-            RuleCategoriesBuilder::default().with_syntax().build(),
         );
 
         analyzer.add_visitor(Phases::Syntax, Box::<SyntaxVisitor<RawLanguage>>::default());

diff --git a/crates/biome_css_analyze/src/lib.rs b/crates/biome_css_analyze/src/lib.rs
@@ -96,7 +96,7 @@ where
     let mut registry = RuleRegistry::builder(&filter, root);
     visit_registry(&mut registry);
 
-    let (registry, services, diagnostics, visitors, categories) = registry.build();
+    let (registry, services, diagnostics, visitors) = registry.build();
 
     // Bail if we can't parse a rule option
     if !diagnostics.is_empty() {
@@ -109,7 +109,6 @@ where
         parse_linter_suppression_comment,
         Box::new(CssSuppressionAction),
         &mut emit_signal,
-        categories,
     );
 
     for plugin in plugins {

diff --git a/crates/biome_graphql_analyze/src/lib.rs b/crates/biome_graphql_analyze/src/lib.rs
@@ -89,7 +89,7 @@ where
     let mut registry = RuleRegistry::builder(&filter, root);
     visit_registry(&mut registry);
 
-    let (registry, services, diagnostics, visitors, categories) = registry.build();
+    let (registry, services, diagnostics, visitors) = registry.build();
 
     // Bail if we can't parse a rule option
     if !diagnostics.is_empty() {
@@ -102,7 +102,6 @@ where
         parse_linter_suppression_comment,
         Box::new(GraphqlSuppressionAction),
         &mut emit_signal,
-        categories,
     );
 
     for ((phase, _), visitor) in visitors {

diff --git a/crates/biome_js_analyze/src/lib.rs b/crates/biome_js_analyze/src/lib.rs
@@ -120,7 +120,7 @@ where
         source_type,
     } = services;
 
-    let (registry, mut services, diagnostics, visitors, categories) = registry.build();
+    let (registry, mut services, diagnostics, visitors) = registry.build();
 
     // Bail if we can't parse a rule option
     if !diagnostics.is_empty() {
@@ -133,7 +133,6 @@ where
         parse_linter_suppression_comment,
         Box::new(JsSuppressionAction),
         &mut emit_signal,
-        categories,
     );
 
     for plugin in plugins {

diff --git a/crates/biome_js_transform/src/lib.rs b/crates/biome_js_transform/src/lib.rs
@@ -45,7 +45,7 @@ where
     let mut registry = RuleRegistry::builder(&filter, root);
     visit_transformation_registry(&mut registry);
 
-    let (registry, mut services, diagnostics, visitors, categories) = registry.build();
+    let (registry, mut services, diagnostics, visitors) = registry.build();
 
     // Bail if we can't parse a rule option
     if !diagnostics.is_empty() {
@@ -92,7 +92,6 @@ where
         |_, _| -> Vec<Result<_, Infallible>> { unreachable!() },
         Box::new(TestAction),
         &mut emit_signal,
-        categories,
     );
 
     for ((phase, _), visitor) in visitors {

diff --git a/crates/biome_json_analyze/src/lib.rs b/crates/biome_json_analyze/src/lib.rs
@@ -92,7 +92,7 @@ where
     let mut registry = RuleRegistry::builder(&filter, root);
     visit_registry(&mut registry);
 
-    let (registry, mut services, diagnostics, visitors, categories) = registry.build();
+    let (registry, mut services, diagnostics, visitors) = registry.build();
 
     // Bail if we can't parse a rule option
     if !diagnostics.is_empty() {
@@ -105,7 +105,6 @@ where
         parse_linter_suppression_comment,
         Box::new(JsonSuppressionAction),
         &mut emit_signal,
-        categories,
     );
 
     for ((phase, _), visitor) in visitors {

diff --git a/crates/biome_migrate/src/lib.rs b/crates/biome_migrate/src/lib.rs
@@ -51,7 +51,7 @@ where
     let mut registry = RuleRegistry::builder(&filter, root);
     visit_migration_registry(&mut registry);
 
-    let (migration_registry, mut services, diagnostics, visitors, categories) = registry.build();
+    let (migration_registry, mut services, diagnostics, visitors) = registry.build();
 
     // Bail if we can't parse a rule option
     if !diagnostics.is_empty() {
@@ -91,7 +91,6 @@ where
         |_, _| -> Vec<Result<_, Infallible>> { Default::default() },
         Box::new(TestAction),
         &mut emit_signal,
-        categories,
     );
 
     for ((phase, _), visitor) in visitors {