packages/@biomejs/biome/scripts/generate-packages.mjs (2)

128-129: Avoid drift: keep LINUX_ONLY_ARCHITECTURES in one place.

This constant also appears in scripts/update-manifests.mjs. Consider importing from a single source (or generating both scripts from a template) to prevent silent divergence later.

---

141-143: Tiny style fix: brace the loop and terminate statements.

Keeps consistency with the rest of the file and avoids ASI gotchas.

-for (const arch of LINUX_ONLY_ARCHITECTURES)
-	copyBinaryToNativePackage("linux-%s", arch)
+for (const arch of LINUX_ONLY_ARCHITECTURES) {
+	copyBinaryToNativePackage("linux-%s", arch);
+}

.github/workflows/release_cli.yml (2)

103-106: Pinning cross to a commit: add --locked; consider a tag

• Add --locked to respect Cargo.lock of cross.
• If possible, prefer a released tag over a raw commit to avoid accidental breakage when the repo history shifts.

Proposed tweak:

-        run: cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea
+        run: cargo install cross --locked --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea

---

117-125: Cross path looks good; optional: de-duplicate env and confirm QEMU availability

• Env duplication across native/cross can be hoisted to the job level.
• Please confirm the depot runners have a working container engine and binfmt/QEMU for LoongArch.

Optional refactor:

   env:
-      version: ${{ needs.check.outputs.version }}
+      version: ${{ needs.check.outputs.version }}
+      # Shared build env
+      RUSTFLAGS: "-C strip=symbols -C codegen-units=1"
+      BIOME_VERSION: ${{ env.version }}
@@
-        env:
-          # Strip all debug symbols from the resulting binaries
-          RUSTFLAGS: "-C strip=symbols -C codegen-units=1"
-          # Inline the version of the npm package in the CLI binary
-          BIOME_VERSION: ${{ env.version }}
+        env: {}
@@
-        env:
-          # Strip all debug symbols from the resulting binaries
-          RUSTFLAGS: "-C strip=symbols -C codegen-units=1"
-          # Inline the version of the npm package in the CLI binary
-          BIOME_VERSION: ${{ env.version }}
+        env: {}

.github/workflows/beta.yml (2)

86-89: Install cross: add --locked; tag if feasible

Same rationale as in release workflow.

-        run: cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea
+        run: cargo install cross --locked --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea

---

100-108: Cross build path LGTM; confirm jemalloc page size needs for loong64

• If LoongArch defaults to 16KiB pages on your targets and you rely on jemalloc, consider exporting JEMALLOC_SYS_WITH_LG_PAGE=16 (Cross.toml already passthroughs it). If not required, ignore.

Optional env hoist (as in release) to avoid duplication:

   env:
-      version: ${{ needs.version.outputs.version }}
+      version: ${{ needs.version.outputs.version }}
+      RUSTFLAGS: "-C strip=symbols -C codegen-units=1"
+      BIOME_VERSION: ${{ env.version }}
@@
-        env:
-          # Strip all debug symbols from the resulting binaries
-          RUSTFLAGS: "-C strip=symbols -C codegen-units=1"
-          # Inline the version of the npm package in the CLI binary
-          BIOME_VERSION: ${{ env.version }}
+        env: {}
@@
-        env:
-          # Strip all debug symbols from the resulting binaries
-          RUSTFLAGS: "-C strip=symbols -C codegen-units=1"
-          # Inline the version of the npm package in the CLI binary
-          BIOME_VERSION: ${{ env.version }}
+        env: {}

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: dyc3
PR: biomejs/biome#7081
File: packages/@biomejs/biome/configuration_schema.json:7765-7781
Timestamp: 2025-08-05T14:43:29.581Z
Learning: The file `packages/biomejs/biome/configuration_schema.json` is auto-generated and should not be manually edited or reviewed for schema issues; any changes should be made at the code generation source.

.github/workflows/release.yml (1)

145-148: Pin to cross git rev is fine; add rationale + preflight check

Add a brief comment explaining why a git rev (not tag) is used, and fail early if Docker isn’t present on the runner.

You can inline a note:

       - name: Install cross
         if: matrix.cross == true
-        run: cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea
+        run: |
+          # Pin to a known-good commit; latest tagged release lacks loongarch64 fixes.
+          cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea

Optional preflight (add before installing cross):

- name: Preflight cross dependencies
  if: matrix.cross == true
  run: |
    docker --version

.github/workflows/release_cli.yml (1)

64-67: Loong64 matrix entry: +1; also whitelist depot labels

Entry looks correct; please add the depot labels to .github/actionlint.yaml as noted in release.yml.

.github/workflows/preview.yml (4)

47-51: Loong64 matrix entry OK; don’t forget actionlint whitelist

Good addition. Please add depot labels to .github/actionlint.yaml as per release.yml.

---

79-82: Pin cross and document why

Same note: add a brief comment for the chosen commit; optional Docker preflight as in release.yml.

---

84-92: BIOME_VERSION uses undefined env; wire to job output

Use the version from the version job; current ${{ env.cli-version }} is unset here.

       - name: Build binaries (native)
         if: matrix.cross != true
         run: cargo build -p biome_cli --release --target ${{ matrix.target }}
         env:
           # Strip all debug symbols from the resulting binaries
           RUSTFLAGS: "-C strip=symbols -C codegen-units=1"
           # Inline the version of the npm package in the CLI binary
-          BIOME_VERSION: ${{ env.cli-version }}
+          BIOME_VERSION: ${{ needs.version.outputs.version }}

---

93-101: Mirror BIOME_VERSION fix in cross path

Same correction needed here.

       - name: Build binaries (cross)
         if: matrix.cross == true
         run: cross build -p biome_cli --release --target ${{ matrix.target }}
         env:
           # Strip all debug symbols from the resulting binaries
           RUSTFLAGS: "-C strip=symbols -C codegen-units=1"
           # Inline the version of the npm package in the CLI binary
-          BIOME_VERSION: ${{ env.cli-version }}
+          BIOME_VERSION: ${{ needs.version.outputs.version }}

Run to catch any remaining occurrences (there’s usually one in the GNU job too):

#!/bin/bash
rg -nP -C1 '\bBIOME_VERSION:\s*\${{\s*env\.cli-version\s*}}' .github/workflows/preview.yml

.github/workflows/beta.yml (1)

50-54: Loong64 matrix entry: thumbs up; whitelist depot labels

Looks correct. Please add/extend .github/actionlint.yaml with depot runner labels.

.github/workflows/release.yml (1)

150-167: Split native/cross paths: solid; consider de-duplicating env

Both paths mirror flags nicely. Consider lifting RUSTFLAGS/BIOME_VERSION to job-level env to avoid repetition.

.github/workflows/release_cli.yml (2)

104-107: Cross install pinned; add why + consider faster install

Add a one-liner comment for the pin rationale. Optionally switch to taiki-e/install-action for cached installs to speed CI.

       - name: Install cross
         if: matrix.cross == true
-        run: cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea
+        run: |
+          # Using commit pin due to missing loongarch64 support in latest tag.
+          cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea

---

109-126: Native/cross builds mirror nicely; minor DRY

Looks good. You could hoist RUSTFLAGS/BIOME_VERSION to job env to reduce duplication.

.github/workflows/beta.yml (2)

87-90: Pin rationale for cross + optional caching

Add a short comment explaining the pin; consider taiki-e/install-action for cached installs.

       - name: Install cross
         if: matrix.cross == true
-        run: cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea
+        run: |
+          # Pin to a commit with loongarch64 support pending next release.
+          cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea

---

92-109: Native/cross build split is sound; minor DRY opportunity

As elsewhere, you could hoist RUSTFLAGS/BIOME_VERSION to job env to avoid repetition.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

.github/workflows/preview.yml (1)

95-96: Wire BIOME_VERSION from the job output, not an undefined env.

env.cli-version isn’t defined; use the version job’s output so the binary embeds the correct preview version.

Apply:

-          BIOME_VERSION: ${{ env.cli-version }}
+          BIOME_VERSION: ${{ needs.version.outputs.version }}

Also applies to: 101-105, 159-161

.github/workflows/release.yml (2)

145-151: Pinning cross to a commit is fine; centralise the rev and plan to revisit.

Given crates.io is stale and newer targets land only on Git, pinning is reasonable. Please:

• Hoist the commit to a single env (e.g. CROSS_RS_REV) to keep all workflows in sync.
• Revisit periodically; if/when a tagged release ships with LoongArch, switch to cargo install cross --version or a tag.

Rationale: cross hasn't cut frequent GitHub/crates.io releases; folks install from Git for newer support. (github.com)

Apply within this step:

- run: cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea
+ run: cargo install cross --git https://github.com/cross-rs/cross --rev $CROSS_RS_REV

Add (outside this hunk) near the top-level env: so it propagates to all jobs:

CROSS_RS_REV: "e281947ca900da425e4ecea7483cfde646c8a1ea"

If you confirm a newer tag includes loongarch64, I can prep a follow-up patch to switch to that tag.

---

87-117: Silence actionlint for custom Depot runners.

actionlint will keep flagging the custom depot-* labels as “unknown”. Add a repo config to whitelist them.

Add .github/actionlint.yaml:

runner:
  labels:
    - depot-ubuntu-24.04-16
    - depot-ubuntu-24.04-arm-16
    - depot-ubuntu-24.04
    - depot-ubuntu-24.04-arm-4
    - depot-windows-2022-16
    - depot-macos-14

Also applies to: 193-209, 245-248

.github/workflows/preview.yml (2)

79-86: Pin cross via a single env and plan a follow-up to a tag when available.

Same note as release.yml: centralise the commit and periodically reassess; crates.io is behind, so Git pinning is expected. (github.com)

Apply within this step:

-        run: cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea
+        run: cargo install cross --git https://github.com/cross-rs/cross --rev $CROSS_RS_REV

Add (outside this hunk) near the top-level env::

CROSS_RS_REV: "e281947ca900da425e4ecea7483cfde646c8a1ea"

---

35-41: Whitelist Depot labels in actionlint config.

Add .github/actionlint.yaml as in the release.yml comment to silence “unknown label” warnings for custom runners.

Also applies to: 132-138, 178-186, 229-234

.github/workflows/beta.yml (2)

87-94: DRY the pinned cross revision via env; plan a later switch to a tag.

Same guidance as other workflows; pinning to Git is expected given release cadence. (github.com)

Apply:

-        run: cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea
+        run: cargo install cross --git https://github.com/cross-rs/cross --rev $CROSS_RS_REV

Add (outside this hunk) at the workflow or job env::

CROSS_RS_REV: "e281947ca900da425e4ecea7483cfde646c8a1ea"

---

38-44: Add actionlint config to whitelist self-hosted depot-* labels.

Same snippet as proposed in release.yml to stop false positives.

Also applies to: 140-146, 192-196, 243-248

.github/workflows/release_cli.yml (2)

104-111: Same cross pinning: centralise the rev and reassess when tags catch up.

Use a shared env CROSS_RS_REV and reference it here; crates.io is lagging, so Git pinning is expected. (github.com)

Apply:

-        run: cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea
+        run: cargo install cross --git https://github.com/cross-rs/cross --rev $CROSS_RS_REV

Add (outside this hunk) to the workflow env::

CROSS_RS_REV: "e281947ca900da425e4ecea7483cfde646c8a1ea"

---

156-162: Whitelist custom runner labels for actionlint.

Add .github/actionlint.yaml as suggested earlier to suppress “unknown label” warnings.

Also applies to: 208-214, 236-245

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

.github/workflows/preview.yml (2)

47-51: Whitelist depot runners for actionlint

Same nit as release.yml; add depot labels to .github/actionlint.yaml.

---

87-96: BIOME_VERSION uses an undefined var; wire to job output

env.cli-version isn’t defined. Use the version job’s output.

       - name: Build binaries (native)
         if: matrix.cross != true
         run: cargo build -p biome_cli --release --target ${{ matrix.target }} --features=js_plugin
         env:
           # Strip all debug symbols from the resulting binaries
           RUSTFLAGS: "-C strip=symbols -C codegen-units=1"
           # Inline the version of the npm package in the CLI binary
-          BIOME_VERSION: ${{ env.cli-version }}
+          BIOME_VERSION: ${{ needs.version.outputs.version }}

       - name: Build binaries (cross)
         if: matrix.cross == true
         run: cross build -p biome_cli --release --target ${{ matrix.target }} --features=js_plugin
         env:
           # Strip all debug symbols from the resulting binaries
           RUSTFLAGS: "-C strip=symbols -C codegen-units=1"
           # Inline the version of the npm package in the CLI binary
-          BIOME_VERSION: ${{ env.cli-version }}
+          BIOME_VERSION: ${{ needs.version.outputs.version }}

       - name: Build binaries
         run: cargo build -p biome_cli --release --target=${{ matrix.target }} --features=js_plugin
         env:
           # Strip all debug symbols from the resulting binaries
           RUSTFLAGS: "-C strip=symbols -C codegen-units=1"
           # Inline the version of the npm package in the CLI binary
-          BIOME_VERSION: ${{ env.cli-version }}
+          BIOME_VERSION: ${{ needs.version.outputs.version }}

Also applies to: 97-105, 154-161

.github/workflows/beta.yml (1)

50-54: Whitelist depot labels for actionlint

Add the depot runners to .github/actionlint.yaml to avoid noisy lint.

packages/@biomejs/backend-jsonrpc/src/command.ts (1)

15-31: Type surface: ensure NodeJS.Architecture includes 'loong64'

If your @types/node is older, the object literal may error on the extra key. If you hit that, widen the type locally:

TypeScript (outside this hunk):

type Arch = NodeJS.Architecture | 'loong64';
type PlatformPaths = { [P in NodeJS.Platform]?: Partial<Record<Arch, string>> };

.github/workflows/release.yml (2)

145-151: Pin cross deterministically

Add --locked to make the git install reproducible.

-        run: cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea
+        run: cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea --locked

---

113-117: Silence actionlint for custom depot labels

actionlint flags depot-* runners by default. Add an actionlint config to whitelist them.

New file .github/actionlint.yaml:

runner:
  labels:
    - depot-ubuntu-24.04-16
    - depot-ubuntu-24.04-arm-16
    - depot-windows-2022-16
    - depot-macos-14

.github/workflows/preview.yml (1)

79-86: Make cross install reproducible

Add --locked to the cargo install.

-        run: cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea
+        run: cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea --locked

.github/workflows/release_cli.yml (2)

104-111: Lock cross install for determinism

Pin dependencies during install.

-        run: cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea
+        run: cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea --locked

---

64-67: actionlint and depot labels

If not already in repo, add an actionlint config to allow depot-* labels.

.github/workflows/beta.yml (1)

87-94: Reproducible cross install

Same --locked suggestion here.

-        run: cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea
+        run: cargo install cross --git https://github.com/cross-rs/cross --rev e281947ca900da425e4ecea7483cfde646c8a1ea --locked

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.