fix(useNamingConvention): ignore interfaces in global declarations #7389

Conaclos · 2025-09-03T20:55:56Z

Summary

Fixes #7344

Test Plan

I added a test.

Docs

I updated the rule description.

changeset-bot · 2025-09-03T20:56:01Z

🦋 Changeset detected

Latest commit: 4f61385

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-09-03T20:56:03Z

Walkthrough

Updates the useNamingConvention lint to ignore declarations inside TypeScript declare global blocks by treating TS_GLOBAL_DECLARATION the same as TS_EXTERNAL_MODULE_DECLARATION for scope computation. Adds a docs example and a test (crates/biome_js_analyze/tests/specs/style/useNamingConvention/validInterfaceOverload.ts) to verify no diagnostics for global interface augmentation. Also adds a changeset entry. Minor formatting tweaks in selector_from_binding_declaration; no public API changes.

Assessment against linked issues

Objective	Addressed	Explanation
Ignore naming-convention checks for interface augmentations inside `declare global` to avoid unsafe renames with external DOM interfaces (#7344)	✅
Ensure rule does not perform unsafe interface renames generally without `--unsafe` or add type-aware checks beyond `declare global` context (#7344)	❓	Change only skips `declare global`; no additional type-resolution or `--unsafe` gating implemented.

Suggested labels

A-Parser

Suggested reviewers

siketyan
ematipico

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9e34090 and 4f61385.

⛔ Files ignored due to path filters (1)

crates/biome_js_analyze/tests/specs/style/useNamingConvention/validInterfaceOverload.ts.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (3)

.changeset/tender-results-fix.md (1 hunks)
crates/biome_js_analyze/src/lint/style/use_naming_convention.rs (4 hunks)
crates/biome_js_analyze/tests/specs/style/useNamingConvention/validInterfaceOverload.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

crates/biome_js_analyze/tests/specs/style/useNamingConvention/validInterfaceOverload.ts
.changeset/tender-results-fix.md
crates/biome_js_analyze/src/lint/style/use_naming_convention.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)

GitHub Check: Test Node.js API
GitHub Check: Bench (biome_graphql_formatter)
GitHub Check: Bench (biome_configuration)
GitHub Check: Bench (biome_html_formatter)
GitHub Check: Bench (biome_html_parser)
GitHub Check: Bench (biome_module_graph)
GitHub Check: Bench (biome_js_formatter)
GitHub Check: Bench (biome_css_parser)
GitHub Check: Bench (biome_json_parser)
GitHub Check: Bench (biome_json_analyze)
GitHub Check: Bench (biome_graphql_parser)
GitHub Check: Bench (biome_css_formatter)
GitHub Check: Bench (biome_css_analyze)
GitHub Check: Bench (biome_json_formatter)
GitHub Check: Bench (biome_js_parser)
GitHub Check: Bench (biome_js_analyze)
GitHub Check: autofix

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch conaclos/useNamingConvention-7344

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codspeed-hq · 2025-09-03T21:10:13Z

CodSpeed Performance Report

Merging #7389 will not alter performance

_{Comparing conaclos/useNamingConvention-7344 (4f61385) with main (4416573)}

Summary

✅ 133 untouched benchmarks

…7389)

github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Sep 3, 2025

Conaclos force-pushed the conaclos/useNamingConvention-7344 branch from b5faf14 to 9e34090 Compare September 3, 2025 20:58

This comment was marked as resolved.

Sign in to view

Conaclos force-pushed the conaclos/useNamingConvention-7344 branch 3 times, most recently from 8470d12 to 795a690 Compare September 3, 2025 21:10

Conaclos force-pushed the conaclos/useNamingConvention-7344 branch from 795a690 to 4f61385 Compare September 3, 2025 21:10

Conaclos requested review from a team September 3, 2025 21:10

fix(useNamingConvention): ignore interfaces in global declarations

4f61385

siketyan approved these changes Sep 4, 2025

View reviewed changes

ematipico approved these changes Sep 4, 2025

View reviewed changes

Conaclos merged commit ab06a7e into main Sep 4, 2025
30 checks passed

Conaclos deleted the conaclos/useNamingConvention-7344 branch September 4, 2025 08:28

github-actions bot mentioned this pull request Sep 4, 2025

ci: release #7306

Merged

dyc3 pushed a commit that referenced this pull request Oct 3, 2025

fix(useNamingConvention): ignore interfaces in global declarations (#…

9a6ae1c

…7389)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(useNamingConvention): ignore interfaces in global declarations #7389

fix(useNamingConvention): ignore interfaces in global declarations #7389

Uh oh!

Conaclos commented Sep 3, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Sep 3, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 3, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

Status, Documentation and Community

Uh oh!

This comment was marked as resolved.

Uh oh!

codspeed-hq bot commented Sep 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(useNamingConvention): ignore interfaces in global declarations #7389

fix(useNamingConvention): ignore interfaces in global declarations #7389

Uh oh!

Conversation

Conaclos commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Docs

Uh oh!

changeset-bot bot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Assessment against linked issues

Suggested labels

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

Status, Documentation and Community

Uh oh!

This comment was marked as resolved.

Uh oh!

codspeed-hq bot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #7389 will not alter performance

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conaclos commented Sep 3, 2025 •

edited

Loading

changeset-bot bot commented Sep 3, 2025 •

edited

Loading

coderabbitai bot commented Sep 3, 2025 •

edited

Loading

codspeed-hq bot commented Sep 3, 2025 •

edited

Loading