crates/biome_js_analyze/src/lint/nursery/no_import_cycles.rs (1)

196-201: Nicer path display in diagnostics (strip leading slash for in‑memory paths).

When running under the in‑memory FS, users may see absolute “/foo.js”. Consider stripping a single leading “/” if cwd isn’t a prefix.

Apply this diff:

-            match Utf8Path::new(path).strip_prefix(&cwd) {
-                Ok(relative_path) => {
-                    note.extend_with(markup!(<Info>{relative_path.as_str()}</Info>))
-                }
-                Err(_) => note.extend_with(markup!(<Info>{path}</Info>)),
-            }
+            match Utf8Path::new(path).strip_prefix(&cwd) {
+                Ok(relative_path) => {
+                    note.extend_with(markup!(<Info>{relative_path.as_str()}</Info>))
+                }
+                Err(_) => {
+                    let display = path.strip_prefix('/').unwrap_or(path);
+                    note.extend_with(markup!(<Info>{display}</Info>))
+                }
+            }

xtask/rules_check/src/lib.rs (2)

221-239: Parser for file=...: OK, but consider normalising more robustly.

The trim chain works, but it only removes a single leading ../. If you ever need to support nested dirs like ../../a/b.ts, a loop or a path normaliser would be sturdier. Low-priority.

---

453-460: Avoid rebuilding the module graph for every test in a section.

You rebuild the graph per test even though the file set doesn’t change within the section. Build once per section and reuse; this will speed up large docs.

Apply these diffs to plumb a single graph through:

- fn assert_lint(
+ fn assert_lint(
     group: &'static str,
     rule: &'static str,
     test: &CodeBlockTest,
     code: &str,
     config: &Option<Configuration>,
-    test_files: &HashMap<String, String>,
+    test_files: &HashMap<String, String>,
+    module_graph: &Arc<ModuleGraph>,
 ) -> anyhow::Result<()> {
@@
-                let module_graph = get_test_module_graph(test_files);
-
-                let services = JsAnalyzerServices::from((
-                    Arc::new(module_graph),
+                let services = JsAnalyzerServices::from((
+                    Arc::clone(module_graph),
                     Default::default(),
                     file_source,
                 ));

and in TestRunner::run_pending_tests:

     pub fn run_pending_tests(&mut self) -> anyhow::Result<()> {
-        for test in &self.pending_tests {
+        let mg = Arc::new(get_test_module_graph(&self.file_system));
+        for test in &self.pending_tests {
             assert_lint(
                 self.group,
                 self.rule_name,
                 &test.test,
                 &test.block,
                 &test.options_snapshot,
-                &self.file_system,
+                &self.file_system,
+                &mg,
             )?;
         }

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/biome_js_analyze/lib/src/lint/nursery/*.rs : For new JavaScript lint rules generated by `just new-js-lintrule`, implement the rule in the generated file under `biome_js_analyze/lib/src/lint/nursery/`

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:53:15.299Z
Learning: Use the `noImportCycles` rule to observe project layout and module graph state during debugging

Learnt from: CR
PR: biomejs/biome#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:40:38.097Z
Learning: Applies to crates/**/Cargo.toml : In internal crates, use `workspace = true` for internal dependencies.

Learnt from: CR
PR: biomejs/biome#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:40:38.097Z
Learning: Applies to Cargo.toml : Centralize shared dependencies in the root Cargo.toml using workspace dependencies.

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:27.774Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/Cargo.toml : Add the specified dev-dependencies (biome_formatter_test, biome_html_factory, biome_html_parser, biome_parser, biome_service, countme with feature enable, iai 0.1.1, quickcheck, quickcheck_macros, tests_macros) to Cargo.toml under [dev-dependencies]

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:52.001Z
Learning: Applies to crates/biome_js_formatter/**/Cargo.toml : Add biome_js_formatter as a path dependency in Cargo.toml: biome_js_formatter = { version = "0.0.1", path = "../biome_js_formatter" }

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:53:15.299Z
Learning: Applies to crates/biome_service/src/workspace.rs : Implement the Workspace trait in src/workspace.rs

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:53:15.299Z
Learning: Applies to crates/biome_service/src/workspace/watcher.tests.rs : Place watcher tests for workspace methods in src/workspace/watcher.tests.rs

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/**/lib/src/**/nursery/**/*.rs : Document rules with a one-line first paragraph, `## Examples` with `### Invalid` (first) and `### Valid`, and document options under `## Options` with properly marked code blocks

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/**/lib/src/**/nursery/**/*.rs : Mark code blocks in docs with a language and required properties: use `expect_diagnostic` for invalid examples (exactly one diagnostic), `options`/`full_options` for config blocks, and `use_options` for subsequent examples

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/biome_js_analyze/lib/src/lint/nursery/*.rs : For new JavaScript lint rules generated by `just new-js-lintrule`, implement the rule in the generated file under `biome_js_analyze/lib/src/lint/nursery/`

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/**/lib/src/**/nursery/**/*.rs : When porting from other linters, declare `sources: &[RuleSource::<...>]` in `declare_lint_rule!` using `.same()` or `.inspired()` as appropriate

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/**/lib/src/**/nursery/**/*.rs : In `declare_lint_rule!` declarations, set `version: "next"`

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/**/lib/src/**/nursery/**/*.rs : Use `domains` in `declare_lint_rule!` when applicable; recommended rules with domains enable only when the domain is active

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/**/lib/src/**/nursery/**/*.rs : When banning globals (e.g., `console.log`), consult the semantic model to avoid false positives on locally shadowed identifiers

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/**/lib/src/**/nursery/**/*.rs : Place all new rules in the nursery group (implement new rule files under a `nursery` directory)

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/**/lib/src/**/nursery/**/*.rs : If a rule is deprecated, set the `deprecated:` field in `declare_lint_rule!` with a reason and alternative

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/**/lib/src/**/nursery/**/*.rs : If a rule provides a code action, add `fix_kind` in `declare_lint_rule!` and use `ctx.action_category(ctx.category(), ctx.group())` and `ctx.metadata().applicability()` when constructing actions

Learnt from: CR
PR: biomejs/biome#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-17T08:55:30.118Z
Learning: Applies to crates/biome_*_{syntax,parser,formatter,analyze,factory,semantic}/** : Maintain the per-language crate structure: biome_{lang}_{syntax,parser,formatter,analyze,factory,semantic}

xtask/rules_check/src/lib.rs (1)

973-997: Compilation fix: make module_graph mutable before update_graph_for_js_paths

This method mutates the graph; current binding won’t compile.

-fn get_test_module_graph(files: &HashMap<String, String>) -> ModuleGraph {
-    let module_graph = ModuleGraph::default();
+fn get_test_module_graph(files: &HashMap<String, String>) -> ModuleGraph {
+    let mut module_graph = ModuleGraph::default();
@@
-    module_graph.update_graph_for_js_paths(&fs, &layout, &added_paths, &[]);
+    module_graph.update_graph_for_js_paths(&fs, &layout, &added_paths, &[]);
 
     module_graph
 }

#!/usr/bin/env bash
# Spot the mutability issue and the call site
rg -n 'get_test_module_graph\(|update_graph_for_js_paths\(' xtask/rules_check/src/lib.rs

xtask/rules_check/src/lib.rs (4)

221-237: Handle quoted file= values and preserve absolute paths

Support file="src/a.ts" and file='src/a.ts', and avoid over-zealous prefix trimming. Keep a leading slash if the user provides one.

-            if let Some(file) = token.strip_prefix("file=") {
-
-                if file.is_empty() {
-                    bail!("The 'file' attribute must be followed by a file path");
-                }
-
-                // Normalize to absolute paths for consistent module resolution
-                let path = file
-                    .trim_start_matches('/')
-                    .trim_start_matches("./")
-                    .trim_start_matches("../")
-                    .trim();
-                test.file_path = Some(format!("/{}", path));
-
-                continue;
-            }
+            if let Some(file) = token.strip_prefix("file=") {
+                // Allow quoted values: file="src/a.ts" or file='src/a.ts'
+                let file = file.trim().trim_matches('"').trim_matches('\'');
+                if file.is_empty() {
+                    bail!("The 'file' attribute must be followed by a file path");
+                }
+                // Normalise to an absolute path without collapsing '..'
+                let path = if file.starts_with('/') {
+                    file.to_string()
+                } else {
+                    format!("/{}", file.trim_start_matches("./"))
+                };
+                test.file_path = Some(path);
+                continue;
+            }

---

871-875: Detect duplicate file paths within a section

Silently overwriting files can mask mistakes. Consider warning if a file path is defined twice with different contents. Low-touch safety net.

-                        test_runner
-                            .file_system
-                            .insert(file_path.clone(), block.clone());
+                        if let Some(prev) = test_runner.file_system.insert(file_path.clone(), block.clone()) {
+                            if prev != block {
+                                eprintln!("Warning: duplicate file path '{}' in this section; last definition wins.", file_path);
+                            }
+                        }

---

895-904: Flush on all heading levels, not just H1–H4

H5/H6 are rare in docs, but easy to support and keeps the behaviour predictable.

-                if matches!(
-                    level,
-                    HeadingLevel::H1 | HeadingLevel::H2 | HeadingLevel::H3 | HeadingLevel::H4
-                ) {
+                if matches!(level, HeadingLevel::H1 | HeadingLevel::H2 | HeadingLevel::H3 | HeadingLevel::H4 | HeadingLevel::H5 | HeadingLevel::H6) {

---

413-427: Prefer file-type from the file path when provided

If a code block sets file=foo.ts but the tag is js, the TS extension should win. This avoids mis-parsing and wrong semantics.

             let (code, file_source) = match file_source.as_embedding_kind() {
@@
                 _ => (code, file_source),
             };
+            // Prefer extension-derived source when a file path is provided
+            let file_source = if let Some(fp) = &test.file_path {
+                JsFileSource::try_from(Utf8PathBuf::from(fp).as_path()).unwrap_or(file_source)
+            } else {
+                file_source
+            };

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/biome_js_analyze/lib/src/lint/nursery/*.rs : For new JavaScript lint rules generated by `just new-js-lintrule`, implement the rule in the generated file under `biome_js_analyze/lib/src/lint/nursery/`

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/biome_js_analyze/lib/src/lint/nursery/*.rs : For new JavaScript lint rules generated by `just new-js-lintrule`, implement the rule in the generated file under `biome_js_analyze/lib/src/lint/nursery/`

Learnt from: CR
PR: biomejs/biome#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-17T08:55:30.118Z
Learning: Applies to crates/biome_*_{syntax,parser,formatter,analyze,factory,semantic}/** : Maintain the per-language crate structure: biome_{lang}_{syntax,parser,formatter,analyze,factory,semantic}

xtask/rules_check/src/lib.rs (1)

974-995: Compilation fix: make ModuleGraph mutable

update_graph_for_js_paths mutates the graph; the binding must be mutable. This is already flagged earlier; still outstanding.

Apply:

-    let module_graph = ModuleGraph::default();
+    let mut module_graph = ModuleGraph::default();

Sanity check:

#!/usr/bin/env bash
rg -n 'let\s+mut\s+module_graph\s*=\s*ModuleGraph::default' xtask/rules_check/src/lib.rs
rg -n 'update_graph_for_js_paths' xtask/rules_check/src/lib.rs

xtask/rules_check/src/lib.rs (3)

221-236: Avoid accidental '///foo.js' and accept absolute paths in file=…

If a user writes file=/foo.js, we currently produce ///foo.js. Let’s respect absolute inputs and only prefix when needed.

-                // Normalize to absolute paths for consistent module resolution
-                let path = file
-                    .trim_start_matches("./")
-                    .trim_start_matches("../")
-                    .trim();
-                test.file_path = Some(format!("/{}", path));
+                // Normalise to an absolute path for consistent module resolution
+                let raw = file.trim();
+                let normalised = raw
+                    .trim_start_matches("./")
+                    .trim_start_matches("../");
+                let abs = if normalised.starts_with('/') {
+                    normalised.to_string()
+                } else {
+                    format!("/{}", normalised)
+                };
+                test.file_path = Some(abs);

---

951-962: Build the module graph once per section to speed up tests

get_test_module_graph is called for every test, but self.file_system is identical within a section. Precompute once in run_pending_tests and reuse.

Sketch:

• In run_pending_tests, before the loop:

let module_graph = Arc::new(get_test_module_graph(&self.file_system));

• Thread &module_graph into assert_lint (add an optional module_graph: Option<&Arc<ModuleGraph>> param).
• In the JS branch of assert_lint, use the provided graph (clone the Arc) instead of rebuilding.

Happy to draft a full patch if you want this in the same PR.

Also applies to: 450-456

---

893-902: Consider flushing on H5/H6 as well

Minor, but this future-proofs section detection if docs ever use deeper headings.

-                if matches!(
-                    level,
-                    HeadingLevel::H1 | HeadingLevel::H2 | HeadingLevel::H3 | HeadingLevel::H4
-                ) {
+                if matches!(
+                    level,
+                    HeadingLevel::H1
+                        | HeadingLevel::H2
+                        | HeadingLevel::H3
+                        | HeadingLevel::H4
+                        | HeadingLevel::H5
+                        | HeadingLevel::H6
+                ) {

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/biome_js_analyze/lib/src/lint/nursery/*.rs : For new JavaScript lint rules generated by `just new-js-lintrule`, implement the rule in the generated file under `biome_js_analyze/lib/src/lint/nursery/`

Learnt from: CR
PR: biomejs/biome#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-17T08:55:30.118Z
Learning: Applies to crates/biome_*_{syntax,parser,formatter,analyze,factory,semantic}/** : Maintain the per-language crate structure: biome_{lang}_{syntax,parser,formatter,analyze,factory,semantic}