crates/biome_js_analyze/src/lint/correctness/no_unused_private_class_members.rs (3)

123-147: Pre-size results and prefer an explicit empty box

Minor allocation/readability nits: allocate results with the exact capacity after unused_members is known, and use Box::new([]) for clarity over Box::default().

-        let private_members: Vec<AnyMember> = get_all_declared_private_members(node).collect();
-        if private_members.is_empty() {
-            Box::default()
-        } else {
-            let mut results = Vec::new();
-            let unused_members = traverse_members_usage(node.syntax(), private_members);
+        let private_members: Vec<AnyMember> = get_all_declared_private_members(node).collect();
+        if private_members.is_empty() {
+            Box::new([])
+        } else {
+            let unused_members = traverse_members_usage(node.syntax(), private_members);
+            let mut results = Vec::with_capacity(unused_members.len());

---

248-303: Vec-based flow: confirm uniqueness and update the stale comment

Switching from a set to a Vec is fine here, but please confirm we never feed duplicates; a quick debug-only assert guards against accidental regressions. Also, the doc still says “hashmap”.

 fn traverse_members_usage(
     syntax: &JsSyntaxNode,
     mut private_members: Vec<AnyMember>,
 ) -> Vec<AnyMember> {
+    #[cfg(debug_assertions)]
+    {
+        use std::collections::HashSet;
+        let mut seen = HashSet::new();
+        assert!(
+            private_members
+                .iter()
+                .all(|m| seen.insert(m.syntax().text_range())),
+            "duplicate private members passed to traverse_members_usage"
+        );
+    }

Doc tweak (outside the selected range, near Lines 245–246):

-/// if the member usage is found, we remove it from the hashmap
+/// if the member usage is found, we remove it from the working list

---

352-375: Slightly flatter iterator chain for readability

Equivalent, but a tad easier to scan by grouping map(...).into_iter().flatten() at the end.

-fn get_constructor_params(
-    class_declaration: &JsClassDeclaration,
-) -> impl Iterator<Item = AnyMember> {
-    class_declaration
-        .members()
-        .iter()
-        .find_map(|member| match member {
-            AnyJsClassMember::JsConstructorClassMember(member) => Some(member),
-            _ => None,
-        })
-        .and_then(|constructor_member| constructor_member.parameters().ok())
-        .into_iter()
-        .flat_map(|constructor_params| {
-            constructor_params
-                .parameters()
-                .iter()
-                .filter_map(|param| match param.ok()? {
-                    biome_js_syntax::AnyJsConstructorParameter::TsPropertyParameter(
-                        ts_property,
-                    ) => Some(ts_property.into()),
-                    _ => None,
-                })
-        })
-}
+fn get_constructor_params(
+    class_declaration: &JsClassDeclaration,
+) -> impl Iterator<Item = AnyMember> {
+    class_declaration
+        .members()
+        .iter()
+        .find_map(|member| match member {
+            AnyJsClassMember::JsConstructorClassMember(member) => Some(member),
+            _ => None,
+        })
+        .and_then(|c| c.parameters().ok())
+        .map(|params| {
+            params
+                .parameters()
+                .iter()
+                .filter_map(|param| match param.ok()? {
+                    biome_js_syntax::AnyJsConstructorParameter::TsPropertyParameter(p) => {
+                        Some(p.into())
+                    }
+                    _ => None,
+                })
+        })
+        .into_iter()
+        .flatten()
+}

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro