Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: replace domains polyfill.io to Cloudflare #7678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2025
Merged

fix: replace domains polyfill.io to Cloudflare #7678

merged 1 commit into from
Oct 4, 2025

Conversation

You-saku
Copy link
Contributor

@You-saku You-saku commented Oct 3, 2025 •
edited by ematipico
Loading

Summary

I respond to this Issue.

Closes biomejs/website#2305

Test Plan

none.

Docs

none.

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2025

⚠️ No Changeset found

Latest commit: 9acd22a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Oct 3, 2025
@You-saku You-saku marked this pull request as ready for review October 3, 2025 18:44
@You-saku You-saku mentioned this pull request Oct 3, 2025
Closed
1 task
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 3, 2025 •
edited
Loading

Walkthrough

The lint rule documentation in crates/biome_js_analyze/src/lint/performance/no_unwanted_polyfillio.rs was updated. In the Valid JSX example, polyfill URLs were switched from polyfill.io to cdnjs.cloudflare.com. Only the inline documentation/sample comments were modified. No changes were made to the rule’s logic, control flow, diagnostics, exports, or public APIs.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description Check ❓ Inconclusive The pull request description references the related issue and closure but does not outline what was changed, such as updating documentation examples to use Cloudflare URLs instead of polyfill.io, making it too generic to convey meaningful information about the changeset. Please update the description to include a concise summary of the actual modifications, for example that the lint rule documentation comments were updated to replace polyfill.io domains with Cloudflare CDN links, so reviewers can quickly grasp what the pull request does.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly describes the primary update, replacing polyfill.io domains with Cloudflare in the documentation examples, and directly reflects the change made without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 3, 2025

CodSpeed Performance Report

Merging #7678 will not alter performance

Comparing You-saku:fix-no_unwanted_polyfillio-comments (9acd22a) with main (a8e7301)

Summary

✅ 53 untouched
⏩ 85 skipped1

Footnotes

  1. 85 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@ematipico ematipico merged commit efc9980 into biomejs:main Oct 4, 2025
17 checks passed
@You-saku
Copy link
Contributor Author

You-saku commented Oct 6, 2025

@ematipico
Thanks merge！
I'm interested in Biome.js nowadays, I will try other issue when I found easy issue for me. 👍

cadunass pushed a commit to cadunass/biome that referenced this pull request Oct 9, 2025
@You-saku @cadunass
fix: replace domains polyfill.io to Cloudflare (biomejs#7678)
c8f303f
andogq pushed a commit to andogq/biome that referenced this pull request Oct 14, 2025
@You-saku @andogq
fix: replace domains polyfill.io to Cloudflare (biomejs#7678)
982b640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

📚 📎 noUnwantedPolyfillio should be updated to only showcase replacement domains

2 participants

@You-saku @ematipico