Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: typescript types generation #7743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

fix: typescript types generation #7743

merged 1 commit into from
Oct 13, 2025

Conversation

@ematipico
Copy link
Member

@ematipico ematipico commented Oct 13, 2025

Summary

When I added the new feature for domains when using --skip and --only, I assigned an incorrect name to the schema, causing a regression in the exported typescript types.

This PR fixes it.

Test Plan

Checked that we assign the correct type

Docs

It will fix the playground

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2025

⚠️ No Changeset found

Latest commit: 2264a46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the A-Project Area: project label Oct 13, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 13, 2025

Walkthrough

Renamed the JsonSchema implementation name for the type AnalyzerSelector from "Selector" to "AnalyzerSelector" in crates/biome_configuration/src/analyzer/mod.rs. This changes only the value returned by schema_name(), without altering the type, its serialisation/deserialisation behaviour, or other logic.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly indicates that the PR fixes the TypeScript types generation, which aligns with the main change of correcting the schema name assignment. It directly references the core issue without extraneous details, making it clear to any teammate what the primary update is.
Description Check ✅ Passed The description clearly explains the incorrect schema name assignment, the resulting regression in exported TypeScript types, and includes a test plan validating the fix. It is fully on-topic and provides sufficient context for reviewers.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/typescript-types
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28e8860 and 2264a46.

⛔ Files ignored due to path filters (1)
  • packages/@biomejs/backend-jsonrpc/src/workspace.ts is excluded by !**/backend-jsonrpc/src/workspace.ts and included by **
📒 Files selected for processing (1)
  • crates/biome_configuration/src/analyzer/mod.rs (1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
crates/biome_*/**

📄 CodeRabbit inference engine (CLAUDE.md)

Place core crates under /crates/biome_*/

Files:

  • crates/biome_configuration/src/analyzer/mod.rs
crates/biome_configuration/src/**

📄 CodeRabbit inference engine (CLAUDE.md)

Keep configuration sources under biome_configuration/src/

Files:

  • crates/biome_configuration/src/analyzer/mod.rs
**/*.{rs,toml}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Before committing, format Rust and TOML files (e.g., via just f/just format)

Files:

  • crates/biome_configuration/src/analyzer/mod.rs
**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Document rules, assists, and options via inline rustdoc in Rust source

Files:

  • crates/biome_configuration/src/analyzer/mod.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: Bench (biome_configuration)
  • GitHub Check: autofix
  • GitHub Check: Lint project (depot-windows-2022)
  • GitHub Check: Documentation
  • GitHub Check: Test (depot-ubuntu-24.04-arm-16)
  • GitHub Check: Test (depot-windows-2022-16)
  • GitHub Check: Check Dependencies
  • GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
🔇 Additional comments (1)
crates/biome_configuration/src/analyzer/mod.rs (1)

501-509: Correct schema name aligns with type name.

The change from "Selector" to "AnalyzerSelector" properly fixes the TypeScript types generation. Well spotted!

Comment @coderabbitai help to get the list of available commands and usage tips.

@ematipico ematipico merged commit d523500 into next Oct 13, 2025
10 of 12 checks passed
@ematipico ematipico deleted the fix/typescript-types branch October 13, 2025 10:00
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 13, 2025

CodSpeed Performance Report

Merging #7743 will not alter performance

Comparing fix/typescript-types (2264a46) with next (28e8860)

Summary

✅ 1 untouched
⏩ 139 skipped1

Footnotes

  1. 139 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@coderabbitai coderabbitai bot mentioned this pull request Nov 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-Project Area: project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ematipico