You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This pull request updates the code generation templates in xtask/codegen/src/generate_new_analyzer_rule.rs. The CSS, JSON, and GraphQL rule templates are revised to standardise diagnostic example documentation to JSON-style format and remove references to external stylelint rule links. The CSS template's diagnostic method signature is updated, changing parameter naming convention (_ to _ctx, node to state) and adjusting the diagnostic span source from node.range() to state.range(). Template documentation structure is simplified across all three language variants to focus on diagnostic examples only.
Pre-merge checks and finishing touches
❌ Failed checks (1 warning)
Check name
Status
Explanation
Resolution
Docstring Coverage
⚠️ Warning
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.
You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name
Status
Explanation
Description Check
✅ Passed
The PR description directly addresses the core changes made in the changeset. The summary section accurately lists the three main improvements: removing stylelint references from JSON and GraphQL templates, correcting the CSS-to-JSON label in the JSON example, and aligning diagnostic naming conventions. These points map clearly to the actual modifications described in the raw summary.
Title Check
✅ Passed
The title "chore: improve rule templates" is directly related to the changeset. The PR makes improvements to the rule templates for CSS, JSON, and GraphQL by removing outdated Stylelint references, correcting examples, and aligning diagnostic naming conventions across templates. The title accurately captures the nature of the changes and would allow a teammate scanning history to understand this is a maintenance improvement to the code generation templates.
✨ Finishing touches
📝 Generate docstrings
🧪 Generate unit tests (beta)
Create PR with unit tests
Post copyable unit tests in a comment
Comment @coderabbitai help to get the list of available commands and usage tips.
Netail
changed the title
chore: improve templates
chore: improve rule templates
Oct 17, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
css->jsonin json description exampleTest Plan
Docs