Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "fix(lint/useExhaustiveDependencies): correct fix for method calls" #7810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

Revert "fix(lint/useExhaustiveDependencies): correct fix for method calls" #7810

merged 1 commit into from
Oct 21, 2025
+0 −147

Conversation

siketyan
Copy link
Member

@siketyan siketyan commented Oct 21, 2025 •
edited
Loading

Reverts #7709

Reverting for now as some users have complained about the new behaviour. It was to align the behaviour of the official react-hooks plugin, but the change was too big for a patch update.

@siketyan siketyan self-assigned this Oct 21, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2025

⚠️ No Changeset found

Latest commit: 61737d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Oct 21, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 21, 2025 •
edited
Loading

Walkthrough

This PR simplifies the dependency analysis logic in use_exhaustive_dependencies by removing a special-case handler that previously detected when a static member expression's root was a child of a call expression and would return the object part to circumvent prototype chain issues. The function now consistently casts the root directly instead of taking an early-exit path. Associated test cases from issue 7704 have also been removed.

Possibly related PRs

Suggested labels

A-Linter, L-JavaScript

Suggested reviewers

  • arendjr
  • dyc3

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Revert "fix(lint/useExhaustiveDependencies): correct fix for method calls"" clearly indicates that this pull request is reverting a previous fix. The changeset shows removals from the use_exhaustive_dependencies.rs implementation and test file, which is consistent with reverting changes. A developer scanning the history would immediately understand that this is a revert operation for a method call-related fix. The title is specific, concise, and accurately summarises the main change.
Description Check ✅ Passed The pull request description clearly states that it reverts a previous PR (#7709) and provides context for why this revert is necessary—user complaints about the new behaviour and concerns about the scope of the change for a patch release. This explanation directly aligns with the changeset, which removes code modifications to the use_exhaustive_dependencies linting rule and its associated test cases, effectively reverting the prior fix. The description is on-topic and relates meaningfully to the changes being made.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-7709-fix/GH-7704

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 21, 2025

CodSpeed Performance Report

Merging #7810 will not alter performance

Comparing revert-7709-fix/GH-7704 (61737d8) with main (f1e3841)1

Summary

✅ 53 untouched
⏩ 85 skipped2

Footnotes

  1. No successful run was found on main (aeaa70e) during the generation of this report, so f1e3841 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 85 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@siketyan siketyan merged commit b5de3bf into main Oct 21, 2025
15 of 17 checks passed
@siketyan siketyan deleted the revert-7709-fix/GH-7704 branch October 21, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

@siketyan siketyan

Labels

A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@siketyan @ematipico