Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: ignore tests on macos #7820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

test: ignore tests on macos #7820

merged 1 commit into from
Oct 22, 2025
+2 −0

Conversation

ematipico
Copy link
Member

Summary

Those tests keep failing on main, so we should ignore them for now. cc @siketyan

Test Plan

CI should pass

Docs

@ematipico ematipico requested a review from siketyan October 22, 2025 08:56
@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2025

⚠️ No Changeset found

Latest commit: b33cdd8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the A-Project Area: project label Oct 22, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 22, 2025

Walkthrough

Test skip attributes have been added to two watcher tests in the Biome service scanner module. The tests should_index_on_write_but_not_on_read and should_index_on_create_and_unload_on_delete now include macOS-specific ignore conditions, causing them to be skipped on macOS platforms whilst remaining active on other systems. No functional changes to test logic or public APIs are present.

Suggested reviewers

  • arendjr

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title "test: ignore tests on macos" directly and clearly summarises the primary change in the pull request. The changeset adds macOS-specific ignore attributes to two flaky tests, and the title accurately captures this intent. The phrasing is concise, specific, and free from vague terminology or noise.
Description Check ✅ Passed The description is clearly related to the changeset, explaining that the tests have been failing on the main branch and are being ignored as a temporary measure. Whilst brief, it provides sufficient context for why the changes are needed and what the expected outcome should be (CI passing). The description directly addresses the motivation for the pull request.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/ignore-tests-mac
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7f1742b and b33cdd8.

📒 Files selected for processing (1)
  • crates/biome_service/src/scanner/watcher.tests.rs (2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
crates/biome_*/**

📄 CodeRabbit inference engine (CLAUDE.md)

Place core crates under /crates/biome_*/

Files:

  • crates/biome_service/src/scanner/watcher.tests.rs
**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

**/*.rs: Format Rust files before committing (e.g., via just f which formats Rust)
Document rules, assists, and options with inline rustdoc in source

Files:

  • crates/biome_service/src/scanner/watcher.tests.rs
🧠 Learnings (1)
📚 Learning: 2025-10-15T09:25:05.698Z 
Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-10-15T09:25:05.698Z
Learning: Applies to crates/biome_service/src/workspace/watcher.tests.rs : Place watcher tests related to workspace methods in src/workspace/watcher.tests.rs

Applied to files:

  • crates/biome_service/src/scanner/watcher.tests.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: autofix
  • GitHub Check: Check Dependencies
  • GitHub Check: Test (depot-windows-2022-16)
  • GitHub Check: Test (depot-ubuntu-24.04-arm-16)
  • GitHub Check: Documentation
  • GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
  • GitHub Check: Lint project (depot-windows-2022)
  • GitHub Check: Test Node.js API
🔇 Additional comments (2)
crates/biome_service/src/scanner/watcher.tests.rs (2)

26-26: Pragmatic fix for CI stability, but consider tracking the root cause.

The ignore attribute is correctly applied. However, since these tests will now never run on macOS in CI, any macOS-specific regressions in file watching won't be caught. Given that line 61 already has special handling for macOS timing issues, the underlying problem is likely timing-related.

Consider linking a tracking issue in the ignore message to ensure this doesn't become permanent:

-#[cfg_attr(target_os = "macos", ignore = "flaky on macOS")]
+#[cfg_attr(target_os = "macos", ignore = "flaky on macOS (see #ISSUE_NUMBER)")]

Is there a plan to investigate and fix the underlying flakiness?

99-99: Consistent with the first test change.

Same ignore attribute applied to the second flaky test. The same considerations about tracking the underlying issue apply here.

Comment @coderabbitai help to get the list of available commands and usage tips.

@ematipico ematipico merged commit 303eec0 into main Oct 22, 2025
12 checks passed
@ematipico ematipico deleted the ci/ignore-tests-mac branch October 22, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siketyan siketyan siketyan approved these changes

Assignees

No one assigned

Labels

A-Project Area: project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ematipico @siketyan