You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The change adds "noSecrets" to the exception list within the rules checker, allowing this rule to have non-Error severities whilst still residing in the a11y/correctness/security group. This expands an existing conditional that already exempted several other rule names from the severity validation logic.
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.
You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name
Status
Explanation
Title Check
✅ Passed
The pull request title "ci(rules-check): add noSecrets exception" directly and accurately summarises the main change, which adds "noSecrets" to the exception list in the rules-check xtask. The title is concise, specific, and uses a conventional commit format. It clearly conveys what was changed without ambiguity.
Description Check
✅ Passed
The pull request description "Add noSecrets as an exception in the rules-check xtask" is directly related to the changeset and accurately describes what the change accomplishes. The test plan, whilst minimal, is also relevant to the change.
✨ Finishing touches
📝 Generate docstrings
🧪 Generate unit tests (beta)
Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch conaclos/noSecrets-rule-check-exception
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between d5b416e and 5630a69.
**/*.rs: Format Rust files before committing (e.g., via just f which formats Rust)
Document rules, assists, and options with inline rustdoc in source
Files:
xtask/rules_check/src/lib.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
70-93: Addition of "noSecrets" to exception list is correct.
The rule exists in crates/biome_js_analyze/src/lint/security/no_secrets.rs with proper metadata configuration. The change follows the established pattern and aligns with the PR objective.
Comment @coderabbitai help to get the list of available commands and usage tips.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
noSecretsas an exception in the rules-check xtaskTest Plan
CI must pass.