Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: update Rust to v1.91.0 #7947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ematipico merged 4 commits into from
Nov 3, 2025
Merged

chore: update Rust to v1.91.0 #7947

ematipico merged 4 commits into from
Nov 3, 2025

Conversation

@Gumichocopengin8
Copy link
Contributor

@Gumichocopengin8 Gumichocopengin8 commented Nov 2, 2025 •
edited
Loading

Summary

Update Rust from v1.90.0 to v1.91.0

Test Plan

All CI should be green

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e82f0cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Project Area: project A-Formatter Area: formatter A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS labels Nov 2, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 2, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #7947 will not alter performance

Comparing Gumichocopengin8:chore/update-rust-to-v1.91.0 (e82f0cc) with main (04f4973)

Summary

✅ 53 untouched
⏩ 85 skipped1

Footnotes

  1. 85 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 2, 2025 •
edited
Loading

Walkthrough

The PR replaces numerous .to_string() conversions with .clone() when the source is already an owned String, updates a few cloning patterns for String extraction, refactors one test to use a fixed-size array instead of a Vec, and bumps the Rust toolchain from 1.90.0 to 1.91.0. No public API signatures or control flow changes were introduced.

Suggested reviewers

  • siketyan
  • ematipico

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title "chore: update Rust to v1.91.0" accurately describes a genuine and significant aspect of the changeset: the toolchain bump in rust-toolchain.toml from version 1.90.0 to 1.91.0. Whilst the PR also includes numerous .to_string() to .clone() refactoring changes across multiple files, these appear to be consequences of the Rust upgrade (likely from updated clippy lints or formatter suggestions). The title is concise, specific, and clearly communicates the primary intent stated in the PR description.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check ✅ Passed The PR description states "Update Rust from v1.90.0 to v1.91.0," which directly corresponds to the primary change reflected in the changeset—specifically the rust-toolchain.toml update from version 1.90.0 to 1.91.0. The description is specific and clearly conveys the purpose of this aspect of the changeset. While the PR contains additional refactoring changes (converting .to_string() to .clone() across multiple files and minor documentation tweaks), the description is appropriately related to the substantive change being made, and the instructions indicate that level of detail is not critical for passing this check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the A-Parser Area: parser label Nov 2, 2025
@ematipico ematipico merged commit 198a371 into biomejs:main Nov 3, 2025
28 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Nov 3, 2025
Merged
l0ngvh pushed a commit to l0ngvh/biome that referenced this pull request Dec 21, 2025
@Gumichocopengin8 @autofix-ci @l0ngvh
chore: update Rust to v1.91.0 (biomejs#7947)
4ddaf04 
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

A-CLI Area: CLI A-Core Area: core A-Formatter Area: formatter A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Gumichocopengin8 @ematipico