Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: rules.rs cleanup #8044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 9, 2025
Merged

docs: rules.rs cleanup #8044

merged 5 commits into from
Nov 9, 2025

Conversation

@Netail
Copy link
Member

@Netail Netail commented Nov 8, 2025 •
edited
Loading

Summary

  • The package is called @stylistic/eslint-plugin instead of eslint-plugin-stylistic
  • Renamed ReactPreferFunctionComponent to EslintReactPreferFunctionComponent as it's an Eslint plugin (also in the name; eslint-plugin-react-prefer-function-component)
  • Change solidjs namespace to solid (as that's the actual eslint namespace)
  • Do not prefix a namespace for stylelint & deno as they do not have one
  • Sorted alphabetically
  • Excluded DenoLint & GraphqlSchemaLinter from being marked as an Eslint plugin

Test Plan

Docs

@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 121ec5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the A-Linter Area: linter label Nov 8, 2025
@dyc3
Copy link
Contributor

dyc3 commented Nov 8, 2025

Probably could use a changeset.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 8, 2025 •
edited
Loading

Walkthrough

Expanded the RuleSource enum with multiple new variants (DenoLint and several Eslint* variants such as EslintBarrelFiles, EslintMysticatea, EslintN, EslintNext, EslintNoSecrets, EslintPackageJson, EslintPackageJsonDependencies, EslintQwik, EslintReactPreferFunctionComponent, EslintRegexp). Updated Display, as_rule_name, to_namespaced_rule_name and to_rule_url implementations to recognise, format and produce URLs for these new sources. Switched the UseReactFunctionComponents lint to reference EslintReactPreferFunctionComponent.

Possibly related PRs

Suggested reviewers

  • ematipico
  • dyc3

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'docs: rules.rs cleanup' is misleading—the PR makes substantial code changes including adding new RuleSource variants and updating rule references, not just documentation or cleanup. Use a more accurate title reflecting the actual changes, such as 'refactor: correct and expand RuleSource variants for ESLint plugins' or similar.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly relates to the changeset, detailing specific corrections to rule source references including plugin naming, namespace adjustments, and alphabetical sorting.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@Netail Netail force-pushed the docs/correct-stylistic-plugin-name branch from df5468d to 90e3245 Compare November 8, 2025 23:43
@Netail Netail changed the title docs: correct stylistic plugin name docs: rules.rs cleanup Nov 8, 2025
@Netail Netail requested a review from dyc3 November 8, 2025 23:43
@github-actions github-actions bot added the L-JavaScript Language: JavaScript and super languages label Nov 8, 2025
@Netail Netail force-pushed the docs/correct-stylistic-plugin-name branch from aa1db2c to 7f4d4fa Compare November 8, 2025 23:48
@Netail
Copy link
Member Author

Netail commented Nov 8, 2025

@dyc3 added a few more stuff (see description), hence the re-review

@github-actions github-actions bot added the A-CLI Area: CLI label Nov 8, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 8, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8044 will not alter performance

Comparing Netail:docs/correct-stylistic-plugin-name (121ec5b) with main (beeb7bb)

Summary

✅ 53 untouched
⏩ 85 skipped1

Footnotes

  1. 85 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

dyc3
dyc3 approved these changes Nov 9, 2025
View reviewed changes
@Netail Netail merged commit 8f77d4a into biomejs:main Nov 9, 2025
18 checks passed
@github-actions github-actions bot mentioned this pull request Nov 8, 2025
Merged
@Netail Netail deleted the docs/correct-stylistic-plugin-name branch November 10, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dyc3 dyc3 dyc3 approved these changes

Assignees

No one assigned

Labels

A-CLI Area: CLI A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Netail @dyc3