Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: regression schemars v1 #8092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ematipico merged 2 commits into from
Nov 13, 2025
Merged

chore: regression schemars v1 #8092

ematipico merged 2 commits into from
Nov 13, 2025

Conversation

@ematipico
Copy link
Member

@ematipico ematipico commented Nov 13, 2025

Summary

Forgot to push the fix for this small regression

Test Plan

Gree CI

Docs

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: cddf7bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ematipico ematipico requested review from a team November 13, 2025 08:28
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 13, 2025

Walkthrough

This change refactors JSON schema generation for rule options and streamlines build dependencies. The CustomRestrictedElements schema shifts from using a reference type to inlining the object structure directly, with explicit constraints (object type, string properties, minimum one property required). In parallel, the schemars crate dependency is removed from the primary dependencies list for the biome_wasm crate, though it remains available as a build dependency. No public API changes occur; these are internal schema and build configuration adjustments.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately identifies the main change: fixing a regression related to schemars v1 dependency handling across the codebase.
Description check ✅ Passed The description relates to the changeset by acknowledging it fixes a forgotten regression, though it lacks implementation details about what was changed.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/fix-regerssion-schemars
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c0edd4 and a958d2e.

⛔ Files ignored due to path filters (2)
  • packages/@biomejs/backend-jsonrpc/src/workspace.ts is excluded by !**/backend-jsonrpc/src/workspace.ts and included by **
  • packages/@biomejs/biome/configuration_schema.json is excluded by !**/configuration_schema.json and included by **
📒 Files selected for processing (2)
  • crates/biome_rule_options/src/no_restricted_elements.rs (1 hunks)
  • crates/biome_wasm/Cargo.toml (0 hunks)
💤 Files with no reviewable changes (1)
  • crates/biome_wasm/Cargo.toml
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings 
Learnt from: dyc3
Repo: biomejs/biome PR: 7081
File: packages/@biomejs/biome/configuration_schema.json:7765-7781
Timestamp: 2025-08-05T14:43:29.581Z
Learning: The file `packages/biomejs/biome/configuration_schema.json` is auto-generated and should not be manually edited or reviewed for schema issues; any changes should be made at the code generation source.

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_type_info/CONTRIBUTING.md:0-0
Timestamp: 2025-10-15T09:23:33.055Z
Learning: Applies to crates/biome_js_type_info/src/{type_info,local_inference,resolver,flattening}.rs : Avoid recursive type structures and cross-module Arcs; represent links between types using TypeReference and TypeData::Reference.

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-10-15T09:22:15.851Z
Learning: Applies to crates/biome_formatter/src/**/*.rs : After generation, remove usages of `format_verbatim_node` and implement real formatting with biome_formatter utilities
📚 Learning: 2025-10-15T09:23:33.055Z 
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_type_info/CONTRIBUTING.md:0-0
Timestamp: 2025-10-15T09:23:33.055Z
Learning: Applies to crates/biome_js_type_info/src/{type_info,local_inference,resolver,flattening}.rs : Avoid recursive type structures and cross-module Arcs; represent links between types using TypeReference and TypeData::Reference.

Applied to files:

  • crates/biome_rule_options/src/no_restricted_elements.rs
📚 Learning: 2025-10-15T09:23:33.055Z 
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_type_info/CONTRIBUTING.md:0-0
Timestamp: 2025-10-15T09:23:33.055Z
Learning: Applies to crates/biome_js_type_info/src/type_info.rs : Add new TypeScript type support by extending the TypeData enum rather than introducing parallel structures.

Applied to files:

  • crates/biome_rule_options/src/no_restricted_elements.rs
🧬 Code graph analysis (1)
crates/biome_rule_options/src/no_restricted_elements.rs (1)
crates/biome_configuration/src/analyzer/linter/mod.rs (1)
  • json_schema (71-81)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Test Node.js API
  • GitHub Check: Documentation
  • GitHub Check: Check Dependencies
  • GitHub Check: Test (depot-windows-2022-16)
  • GitHub Check: Check JS Files
  • GitHub Check: Test (depot-ubuntu-24.04-arm-16)
  • GitHub Check: Lint project (depot-windows-2022)
  • GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
  • GitHub Check: autofix
🔇 Additional comments (1)
crates/biome_rule_options/src/no_restricted_elements.rs (1)

51-59: LGTM! Schema correctly models the underlying HashMap.

The inline schema generation accurately represents the FxHashMap<Box<str>, Box<str>> type, and the minProperties: 1 constraint sensibly enforces at least one restricted element. The description provides clear guidance for users.

Comment @coderabbitai help to get the list of available commands and usage tips.

@ematipico ematipico merged commit 6bcc9d2 into main Nov 13, 2025
13 checks passed
@ematipico ematipico deleted the chore/fix-regerssion-schemars branch November 13, 2025 09:06
@coderabbitai coderabbitai bot mentioned this pull request Nov 18, 2025
Merged
ematipico added a commit to hamirmahal/biome that referenced this pull request Nov 19, 2025
@ematipico @autofix-ci
chore: regression schemars v1 (biomejs#8092)
fa94f9c 
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
l0ngvh pushed a commit to l0ngvh/biome that referenced this pull request Dec 21, 2025
@ematipico @autofix-ci @l0ngvh
chore: regression schemars v1 (biomejs#8092)
d2894ed 
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ematipico