Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(useReactFunctionComponents): handle class expressions with componentDidCatch #8102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dyc3 merged 1 commit into from
Nov 15, 2025
+49 −0
Merged

fix(useReactFunctionComponents): handle class expressions with componentDidCatch #8102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .changeset/fuzzy-worms-smell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
"@biomejs/biome": patch
---

Fixed [#8027](https://github.com/biomejs/biome/issues/8027). [`useReactFunctionComponents`](https://biomejs.dev/linter/rules/use-react-function-components/) no longer reports class components that implement `componentDidCatch` using class expressions.

The rule now correctly recognizes error boundaries defined as class expressions:
```jsx
const ErrorBoundary = class extends Component {
componentDidCatch(error, info) {}

render() {
return this.props.children;
}
}
```
17 changes: 17 additions & 0 deletions crates/biome_js_analyze/src/lint/style/use_react_function_components.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ use biome_analyze::{
Ast, Rule, RuleDiagnostic, RuleDomain, RuleSource, context::RuleContext, declare_lint_rule,
};
use biome_console::markup;
use biome_js_syntax::AnyJsExpression;
use biome_rowan::{AstNode, AstNodeList};
use biome_rule_options::use_react_function_components::UseReactFunctionComponentsOptions;

Expand Down Expand Up @@ -114,6 +115,22 @@ fn has_component_did_catch(node: &AnyPotentialReactComponentDeclaration) -> bool
.is_some_and(|name| name.text() == "componentDidCatch")
})
}
JsVariableDeclarator(variable_declarator) => variable_declarator
.initializer()
.and_then(|initializer| initializer.expression().ok())
.is_some_and(|expression| {
if let AnyJsExpression::JsClassExpression(class_expression) = &expression {
return class_expression.members().iter().any(|member| {
member
.name()
.ok()
.flatten()
.and_then(|name| name.name())
.is_some_and(|name| name.text() == "componentDidCatch")
});
}
false
}),
_ => false,
}
}
8 changes: 8 additions & 0 deletions crates/biome_js_analyze/tests/specs/style/useReactFunctionComponents/valid.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,11 @@ export default class Bar extends React.Component {
return <div>This is a class component with error handling.</div>;
}
}

const ErrorBoundary = class extends React.Component {
componentDidCatch(error, errorInfo) {}

render() {
return this.props.children;
}
}
8 changes: 8 additions & 0 deletions crates/biome_js_analyze/tests/specs/style/useReactFunctionComponents/valid.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,12 @@ export default class Bar extends React.Component {
}
}

const ErrorBoundary = class extends React.Component {
componentDidCatch(error, errorInfo) {}

render() {
return this.props.children;
}
}

```