Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: schema regression rule domains #8133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ematipico merged 2 commits into from
Nov 17, 2025
Merged

chore: schema regression rule domains #8133

ematipico merged 2 commits into from
Nov 17, 2025

Conversation

@ematipico
Copy link
Member

@ematipico ematipico commented Nov 17, 2025

Summary

This should fix the website

Test Plan

Manually checked

Docs

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: da0ccab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the A-Project Area: project label Nov 17, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 17, 2025

Walkthrough

This PR refines JSON schema generation within the linter configuration module. The changes comprise renaming a trait method parameter for clarity, adding explicit subschema generation calls for RuleDomain and RuleDomainValue types, and updating schema reference paths from the internal #/definitions/ format to the standardised #/components/schemas/ format. No public API modifications are present.

Suggested labels

A-Project

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly relates to the changeset, which updates JSON schema generation for rule domains in the linter configuration.
Description check ✅ Passed The description references fixing the website and includes standard PR template content, though it lacks specific technical detail about the schema changes made.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/regression-schema
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c9d5df8 and be4cf77.

⛔ Files ignored due to path filters (1)
  • packages/@biomejs/backend-jsonrpc/src/workspace.ts is excluded by !**/backend-jsonrpc/src/workspace.ts and included by **
📒 Files selected for processing (1)
  • crates/biome_configuration/src/analyzer/linter/mod.rs (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings 
Learnt from: dyc3
Repo: biomejs/biome PR: 7081
File: packages/@biomejs/biome/configuration_schema.json:7765-7781
Timestamp: 2025-08-05T14:43:29.581Z
Learning: The file `packages/biomejs/biome/configuration_schema.json` is auto-generated and should not be manually edited or reviewed for schema issues; any changes should be made at the code generation source.
🧬 Code graph analysis (1)
crates/biome_configuration/src/analyzer/linter/mod.rs (3)
crates/biome_service/src/workspace.rs (4)
  • json_schema (429-443)
  • json_schema (676-678)
  • generator (431-431)
  • generator (432-432)
crates/biome_configuration/src/analyzer/mod.rs (22)
  • json_schema (110-122)
  • json_schema (216-228)
  • json_schema (377-387)
  • json_schema (452-464)
  • json_schema (495-510)
  • json_schema (545-562)
  • json_schema (654-656)
  • json_schema (862-864)
  • generator (112-112)
  • generator (113-113)
  • generator (218-218)
  • generator (219-219)
  • generator (378-378)
  • generator (379-379)
  • generator (453-453)
  • generator (454-454)
  • generator (497-497)
  • generator (498-498)
  • generator (547-547)
  • generator (548-548)
  • generator (549-549)
  • generator (985-985)
xtask/codegen/src/generate_bindings.rs (3)
  • SchemaGenerator (158-159)
  • SchemaGenerator (161-162)
  • SchemaGenerator (164-165)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: Documentation
  • GitHub Check: End-to-end tests
  • GitHub Check: Check Dependencies
  • GitHub Check: Test (depot-ubuntu-24.04-arm-16)
  • GitHub Check: Test (depot-windows-2022-16)
  • GitHub Check: Test Node.js API
  • GitHub Check: Lint project (depot-windows-2022)
  • GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
  • GitHub Check: autofix
  • GitHub Check: Check JS Files
  • GitHub Check: Bench (biome_configuration)
🔇 Additional comments (1)
crates/biome_configuration/src/analyzer/linter/mod.rs (1)

71-83: LGTM! Schema generation properly aligned with OpenAPI 3.

The changes correctly update the schema generation to follow OpenAPI 3 conventions and ensure proper schema composition. The parameter rename (removing the underscore), explicit subschema generation calls, and reference path updates from #/definitions/ to #/components/schemas/ all align with the established patterns in workspace.rs and the OpenAPI 3 settings used in generate_bindings.rs.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 17, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8133 will not alter performance

Comparing chore/regression-schema (da0ccab) with main (ec7fa32)1

Summary

✅ 1 untouched
⏩ 154 skipped2

Footnotes

  1. No successful run was found on main (97353a8) during the generation of this report, so ec7fa32 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 154 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@ematipico ematipico merged commit 6976d03 into main Nov 17, 2025
15 checks passed
@ematipico ematipico deleted the chore/regression-schema branch November 17, 2025 08:52
@coderabbitai coderabbitai bot mentioned this pull request Nov 18, 2025
Merged
ematipico added a commit to hamirmahal/biome that referenced this pull request Nov 19, 2025
@ematipico @autofix-ci
chore: schema regression rule domains (biomejs#8133)
da56e13 
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
l0ngvh pushed a commit to l0ngvh/biome that referenced this pull request Dec 21, 2025
@ematipico @autofix-ci @l0ngvh
chore: schema regression rule domains (biomejs#8133)
88ac6c9 
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-Project Area: project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ematipico