Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(formatter): add printer option to disable source-map generation #8284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ematipico merged 3 commits into from
Dec 5, 2025
Merged

refactor(formatter): add printer option to disable source-map generation #8284

ematipico merged 3 commits into from
Dec 5, 2025

Conversation

@denbezrukov
Copy link
Contributor

@denbezrukov denbezrukov commented Nov 27, 2025

Summary

I've noticed that we use source maps only for range, lets try to disable it otherwise.
Just want to see if we have a performance difference

Test Plan

Green CI

Docs

@changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c8bf113

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added A-Project Area: project A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS A-Type-Inference Area: type inference labels Nov 27, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2025 •
edited
Loading

Warning

Rate limit exceeded

@ematipico has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 5 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between ae08bfe and c8bf113.

📒 Files selected for processing (2)
  • .changeset/tough-buckets-write.md (1 hunks)
  • crates/biome_formatter/src/printer/printer_options/mod.rs (3 hunks)

Walkthrough

This pull request introduces source map generation capabilities to the formatter. A new SourceMapGeneration enum with Disabled and Enabled variants is added to PrinterOptions, along with configuration methods and accessors. The print_with_indent API signature is updated to accept a SourceMapGeneration parameter. Most call sites are updated to pass SourceMapGeneration::Enabled, whilst Svelte and Vue formatters explicitly pass SourceMapGeneration::Disabled. The printer's push_marker method now includes a guard to skip source marker generation when disabled. Semantic model formatters initialise the new field with its default value.

Possibly related PRs

Suggested labels

A-Formatter, A-Tooling, A-Project

Suggested reviewers

  • ematipico
  • dyc3

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The PR title accurately describes the main change: introducing a printer option to control source-map generation, allowing it to be disabled.
Description check ✅ Passed The description explains the motivation (source maps only used for range, measuring performance impact) and relates directly to the changeset's purpose.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025 •
edited
Loading

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 52552 52552 0
Passed 51339 51339 0
Failed 1171 1171 0
Panics 42 42 0
Coverage 97.69% 97.69% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 38 38 0
Passed 37 37 0
Failed 1 1 0
Panics 0 0 0
Coverage 97.37% 97.37% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6327 6327 0
Passed 2108 2108 0
Failed 4219 4219 0
Panics 0 0 0
Coverage 33.32% 33.32% 0.00%

ts/babel

Test result main count This PR count Difference
Total 626 626 0
Passed 561 561 0
Failed 65 65 0
Panics 0 0 0
Coverage 89.62% 89.62% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18827 18827 0
Passed 14073 14073 0
Failed 4753 4753 0
Panics 1 1 0
Coverage 74.75% 74.75% 0.00%

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 27, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8284 will not alter performance

Comparing dbezrukov/source-maps-option (c8bf113) with main (8107ef3)

Summary

✅ 58 untouched
⏩ 95 skipped1

Footnotes

  1. 95 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@ematipico
Copy link
Member

ematipico commented Nov 27, 2025

Overall, they improved! ~3%

@ematipico ematipico mentioned this pull request Dec 5, 2025
Open
6 tasks
@ematipico ematipico merged commit 4976d1b into main Dec 5, 2025
26 checks passed
@ematipico ematipico deleted the dbezrukov/source-maps-option branch December 5, 2025 15:11
@github-actions github-actions bot mentioned this pull request Dec 4, 2025
Merged
ematipico added a commit that referenced this pull request Dec 8, 2025
@denbezrukov @ematipico
refactor(formatter): add printer option to disable source-map generat…
e57470f 
…ion (#8284)

Co-authored-by: Emanuele Stoppa <[email protected]>
This was referenced Dec 15, 2025
Merged
Merged
This was referenced Dec 15, 2025
Open
Open
l0ngvh pushed a commit to l0ngvh/biome that referenced this pull request Dec 21, 2025
@denbezrukov @ematipico @l0ngvh
refactor(formatter): add printer option to disable source-map generat…
caa2280 
…ion (biomejs#8284)

Co-authored-by: Emanuele Stoppa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-Formatter Area: formatter A-Project Area: project A-Type-Inference Area: type inference L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@denbezrukov @ematipico