chore: sync html prettier tests #8291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3807f1a to
75ccdb6
Compare
ematipico
approved these changes
Nov 28, 2025
22d6847 to
d74c8bd
Compare
75ccdb6 to
d254367
Compare
d254367 to
9aaeff2
Compare
Contributor
|
Warning Rate limit exceeded@dyc3 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 47 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (21)
📒 Files selected for processing (207)
WalkthroughBumps Prettier versions in multiple package.json files (examples: benchmark to 3.7.4, prettier-tests to 3.7.1) and adds a large suite of Prettier HTML/Vue test fixtures and snapshots. New test coverage includes HTML attributes (event handlers, iframe allow), broken HTML, comments, MJML style, interpolation, script variants, multiparser cases, and hundreds of Vue SFC scenarios (custom blocks, event bindings, TS expressions, template/lang variants, style blocks). prepare_tests.js migrated to ESM, adds Vue test extraction and cleans up html/cursor. No production formatter logic changes. Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
crates/biome_html_formatter/tests/specs/prettier/vue/event-binding/non-ascii-expression.vue (1)
1-4: Focused non‑ASCII vs ASCII event‑binding fixture looks goodTemplate syntax is valid and the uneven spacing in the expressions is exactly the sort of thing the formatter should normalise, so this is a neat little edge‑case probe.
If any AI tooling helped sketch these fixtures, a quick note in the PR description would keep us aligned with the repo’s contributing guidelines. Based on learnings, …
crates/biome_html_formatter/tests/specs/prettier/prepare_tests.js
Outdated
Show resolved
Hide resolved
crates/biome_html_formatter/tests/specs/prettier/prepare_tests.js
Outdated
Show resolved
Hide resolved
crates/biome_html_formatter/tests/specs/prettier/vue/html-vue/elastic-header.html
Show resolved
Hide resolved
crates/biome_html_formatter/tests/specs/prettier/vue/html-vue/elastic-header.html.prettier-snap
Show resolved
Hide resolved
ematipico
reviewed
Dec 4, 2025
7839c59 to
e04b0a0
Compare
Contributor
Author
|
I've filed #8358 to keep track of the broken snapshot tests. |
e04b0a0 to
f967cf2
Compare
ematipico
pushed a commit
that referenced
this pull request
Dec 8, 2025
l0ngvh
pushed a commit
to l0ngvh/biome
that referenced
this pull request
Dec 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated and reran the sync script for HTML tests. Also adds vue tests.
Test Plan
CI should stay green.
Docs