fix(lint): improve `noBiomeFirstException` #8326

ematipico · 2025-12-01T08:46:21Z

Summary

As discussed in #7930 (comment), this PR improves noBiomeFirstException by inspecting the extended configuration files.

To achieve that, I had to store the extended configuration structures in the workspace. Once that piece is done, I created a new analyzer service that allows the rule pull that information and act accordingly based on the new business logic.

Test Plan

Added a new test

Docs

changeset-bot · 2025-12-01T08:46:25Z

🦋 Changeset detected

Latest commit: 3eb3327

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-12-01T08:48:49Z

Walkthrough

Adds support for propagated extended configurations across the configuration loading, storage and workspace update flows. apply_extends now returns discovered extended configs; LoadedConfiguration gains an extended_configurations field; a new ConfigurationSource and ExtendedConfigurations API were introduced. Settings.merge_with_configuration, UpdateSettingsParams and workspace update flows were extended to accept and forward extended configurations. CLI CommandRunner.merge_configuration signatures changed to accept a bare Configuration plus optional loaded_directory/loaded_file hints and to propagate extended configs. JSON analysis APIs were changed to accept a JsonAnalyzeServices wrapper (file_source plus optional ConfigurationSource). The noBiomeFirstException JSON lint was refactored to consult extends and emit targeted diagnostics/fixes for catch-all "**" patterns.

Possibly related PRs

feat(lsp): provide inline configuration #8278 — touches the configuration/settings subsystem and merge_with_configuration changes; overlaps on API and settings storage changes.
chore: release v2.3.0 #7708 — relates to propagating extended configurations and updating Settings/UpdateSettings flows used by workspace updates.
feat(lint): add useBiomeIgnoreFolder and noBiomeFirstException #7159 — earlier work on the noBiomeFirstException lint; closely connected to the rule refactor and config-source integration.

Suggested reviewers

dyc3
arendjr

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarises the main change: improving the noBiomeFirstException lint rule by inspecting extended configuration files.
Description check	✅ Passed	The description is well-related to the changeset, explaining the motivation, implementation approach (storing extended configurations, creating a new analyzer service), and test coverage.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/biome-lint-rule

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-01T08:50:47Z

Parser conformance results on

js/262

Test result	`main` count	This PR count	Difference
Total	52123	52123	0
Passed	50886	50886	0
Failed	1195	1195	0
Panics	42	42	0
Coverage	97.63%	97.63%	0.00%

jsx/babel

Test result	`main` count	This PR count	Difference
Total	40	40	0
Passed	37	37	0
Failed	3	3	0
Panics	0	0	0
Coverage	92.50%	92.50%	0.00%

symbols/microsoft

Test result	`main` count	This PR count	Difference
Total	6323	6323	0
Passed	2106	2106	0
Failed	4217	4217	0
Panics	0	0	0
Coverage	33.31%	33.31%	0.00%

ts/babel

Test result	`main` count	This PR count	Difference
Total	835	835	0
Passed	742	742	0
Failed	93	93	0
Panics	0	0	0
Coverage	88.86%	88.86%	0.00%

ts/microsoft

Test result	`main` count	This PR count	Difference
Total	18823	18823	0
Passed	14069	14069	0
Failed	4753	4753	0
Panics	1	1	0
Coverage	74.74%	74.74%	0.00%

codspeed-hq · 2025-12-01T08:51:00Z

CodSpeed Performance Report

Merging #8326 will not alter performance

_{Comparing fix/biome-lint-rule (3eb3327) with main (9cf2332)¹}

Summary

✅ 58 untouched
⏩ 95 skipped²

No successful run was found on main (1da899b) during the generation of this report, so 9cf2332 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
95 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

coderabbitai

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

crates/biome_lsp/src/session.rs (1)

836-922: Extended configurations from load_configuration are dropped in the LSP path

The destructuring pattern at line 836-837 uses .. to ignore the extended_configurations field, and line 918 always passes extended_configurations: Default::default() to update_settings. Meanwhile, the CLI (in crates/biome_cli/src/commands/mod.rs) and workspace server (in crates/biome_service/src/workspace/server.rs) both properly thread extended configurations through. This creates a behavioral parity gap where LSP-based sessions won't apply extended configuration rules like noBiomeFirstException that would work via CLI.

Thread the extended_configurations field from LoadedConfiguration into UpdateSettingsParams::extended_configurations instead of always using the empty default.
crates/biome_service/src/workspace.rs (1)
731-740: Add #[serde(default)] to extended_configurations for backwards compatibility

UpdateSettingsParams.extended_configurations lacks #[serde(default)], making the field required during deserialization. Older clients that don't send extendedConfigurations will cause the new server to reject the request.

Throughout this module, Vec fields consistently use #[serde(default)]: PullDiagnosticsParams.only, PullDiagnosticsParams.skip, PullDiagnosticsParams.enabled_rules, and ScanProjectParams.verbose all follow the pattern of combining #[serde(default)] with #[serde(skip_serializing_if)].
 #[serde(skip_serializing_if = "Vec::is_empty")]
+#[serde(default, skip_serializing_if = "Vec::is_empty")]
 pub extended_configurations: Vec<(BiomePath, Configuration)>,
This keeps the new functionality while remaining tolerant of older clients.

🧹 Nitpick comments (9)

crates/biome_fs/src/path.rs (1)

214-224: AsRef impls are correct and improve ergonomics

Both AsRef<Utf8PathBuf> and AsRef<Utf8Path> are thin, cheap views over the inner path field and line up with how BiomePath already derefs, so this slots in cleanly with generic APIs expecting AsRef<_>. Nice little ergonomics win; no changes needed from my side.

If you later find yourself frequently bridging to std::path::Path/PathBuf, a pair of AsRef<Path>/AsRef<PathBuf> impls on BiomePath could round out the conversion story—but that’s strictly optional and out of scope here.
crates/biome_glob/src/lib.rs (1)
284-287: Implementation looks good.

The method correctly exposes the underlying glob pattern. Consider clarifying in the doc comment that this returns the pattern without the negation prefix (unlike to_string()), which might be helpful for future maintainers.

Optional doc enhancement:
-    /// Returns the pattern as a string slice.
+    /// Returns the pattern as a string slice, without the negation prefix.
+    ///
+    /// Use `to_string()` if you need the full pattern including `!` or `!!` prefixes.
     pub fn as_str(&self) -> &str {
         self.glob.glob().glob()
     }
crates/biome_formatter_test/src/spec.rs (1)
272-276: Consider using vec![] for brevity and consistency.

Other call sites (e.g., in spec_test.rs files and settings.tests.rs) use the simpler vec![] form, relying on type inference. This explicit turbofish annotation works but is more verbose than necessary.
             .merge_with_configuration(
                 test_options.unwrap_or_default(),
                 None,
-                Vec::<(Utf8PathBuf, Configuration)>::new(),
+                vec![],
             )
crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs (1)
259-262: Consider adding #[derive(Debug)] to ViolationKind.

This would be helpful for debugging and aligns with Rust conventions for enums that represent state.
+#[derive(Debug)]
 pub enum ViolationKind {
     ExtendedStar(TextRange, JsonArrayElementList),
     NoStar(TextRange, JsonMember),
 }
crates/biome_test_utils/src/lib.rs (1)

121-135: Consider using consistent error handling between the two loading functions.

load_configuration_source returns Option (swallowing errors), while load_configuration_for_test_file returns Result. This is likely intentional since spec tests need config parsing errors in diagnostics, but it may be worth adding a brief doc comment clarifying why load_configuration_source silently ignores errors.
crates/biome_cli/src/commands/ci.rs (1)
46-56: LGTM, with a minor formatting note.

The signature update is consistent with other command payloads. There's an extra blank line at line 51 after _loaded_file — might want to tidy that up with just f.
     fn merge_configuration(
         &mut self,
         loaded_configuration: Configuration,
         loaded_directory: Option<Utf8PathBuf>,
         _loaded_file: Option<Utf8PathBuf>,
-
         fs: &dyn FileSystem,
         _console: &mut dyn Console,
     ) -> Result<Configuration, WorkspaceError> {
crates/biome_json_analyze/src/services/config_source.rs (1)
42-44: Misleading doc comment.

The comment references "the package manifest", but this service provides access to the configuration source. This appears to be a copy-paste artefact.
-/// Query type usable by lint rules **that uses the package manifest** and matches on specific [AstNode] types.
+/// Query type usable by lint rules **that require access to the configuration source** and matches on specific [AstNode] types.
crates/biome_service/src/settings.rs (1)
114-149: Consider extracting the repeated path conversion.

The pattern working_directory.as_ref().map(|p| p.as_path().to_path_buf()) appears six times. Since Utf8PathBuf implements Clone, this could be simplified to working_directory.clone() directly, or extracted to a local binding.
+        let wd = working_directory.clone();
+
         // formatter part§
         if let Some(formatter) = configuration.formatter {
-            self.formatter = to_format_settings(
-                working_directory
-                    .as_ref()
-                    .map(|p| p.as_path().to_path_buf()),
-                formatter,
-            )?;
+            self.formatter = to_format_settings(wd.clone(), formatter)?;
         }
This would reduce repetition and improve readability. Alternatively, if the to_*_settings functions can accept Option<&Utf8Path> instead, borrowing would avoid cloning altogether.
crates/biome_configuration/src/lib.rs (1)
802-816: Consider consolidating impl blocks and optimising source_path().

There are two separate impl ConfigurationSource blocks. These could be merged for better organisation. Additionally, source_path() clones the entire tuple unnecessarily:
     pub fn source_path(&self) -> Option<Utf8PathBuf> {
-        self.source.as_ref().and_then(|source| {
-            let (_, path) = source.clone();
-            path.map(|p| p.as_path().to_path_buf())
-        })
+        self.source
+            .as_ref()
+            .and_then(|(_, path)| path.clone())
     }
This avoids cloning the Configuration when only the path is needed.

.changeset/cruel-meals-talk.md

crates/biome_service/src/file_handlers/json.rs

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

crates/biome_service/src/file_handlers/json.rs (1)
669-673: Consider hoisting services outside the loop.

Both file_source and configuration_source are invariant across iterations, so recreating the struct each time is slightly wasteful. That said, the struct is small and the overhead is negligible — feel free to defer.
+    let services = JsonAnalyzeServices {
+        file_source,
+        configuration_source: params.settings.full_source(),
+    };
     loop {
-        let services = JsonAnalyzeServices {
-            file_source,
-            configuration_source: params.settings.full_source(),
-        };
         let (action, _) = analyze(&tree, filter, &analyzer_options, services, |signal| {
Note: This requires JsonAnalyzeServices to implement Copy or be cloned on each analyze call, so verify whether that's feasible first.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9af1cb5 and 07ecfb2.

📒 Files selected for processing (1)

crates/biome_service/src/file_handlers/json.rs (4 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

**/*.rs: Use the dbg!() macro for debugging output during testing, and pass the --show-output flag to cargo to view debug output
Use cargo t or cargo test to run tests; for a single test, pass the test name after the test command
Use snapshot testing with the insta crate; run cargo insta accept, cargo insta reject, or cargo insta review to manage snapshot changes
Write doctests as doc comments with code blocks; the code inside code blocks will be run during the testing phase
Use just f (alias for just format) to format Rust and TOML files before committing

Files:

crates/biome_service/src/file_handlers/json.rs

🧠 Learnings (28)

📓 Common learnings

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Commit rule changes with message format: `feat(biome_<crate>): <ruleName>` to follow Biome's conventional commit style

Learnt from: arendjr
Repo: biomejs/biome PR: 7593
File: crates/biome_service/src/workspace/server.rs:1306-1306
Timestamp: 2025-09-25T12:32:59.003Z
Learning: In the biomejs/biome project, do not flag compilation errors during code review as they are handled by the existing test infrastructure and CI. Focus on other code quality aspects instead.

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/src/**/*.rs : Implement the `Merge` trait for rule options to define how options from extended configuration merge with user configuration (usually reset instead of extend)

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : For rules ported from other ecosystems like ESLint or Clippy, add a `sources` field with `RuleSource` metadata using `.same()` for identical behavior or `.inspired()` for different behavior

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/src/**/*.rs : Rule options struct fields should use `#[serde(rename_all = "camelCase")]`, `#[serde(deny_unknown_fields)]`, and `#[serde(default)]` attributes for proper JSON serialization

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use language tags in documentation code blocks (js, ts, tsx, json, css) and order properties consistently as: language, then `expect_diagnostic`, then options modifiers, then `ignore`, then `file=path`

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Check if a variable is global before banning it to avoid false positives when the variable is redeclared in local scope; use the semantic model to verify global scope

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/src/**/*.rs : Rule options must be defined in the `biome_rule_options` crate and implement traits: `Deserializable`, `Merge`, `Serialize`, `Deserialize`, and `JsonSchema`

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Implement custom `Queryable` types and `Visitor` traits for rules requiring deep AST inspection to avoid redundant traversal passes

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : The `action` function must return a `JsRuleAction` (or equivalent language-specific action type) with category `ctx.action_category(ctx.category(), ctx.group())` and applicability from `ctx.metadata().applicability()`

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Code actions must specify a `fix_kind` field in the `declare_lint_rule!` macro as either `FixKind::Safe` or `FixKind::Unsafe` to indicate whether fixes always preserve program behavior

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : When using multiple services in a rule, use `ctx.get_service::<ServiceType>()` to retrieve services running in the second phase when query runs during that phase

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use `Semantic<T>` query type instead of `Ast<T>` when a rule needs to access the semantic model for binding references and scope information

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noExcessive` prefix for rules that report code exceeding configurable limits (e.g., `noExcessiveNestedTestSuites`)

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noRestricted` prefix for rules that report user-banned entities (e.g., `noRestrictedGlobals`)

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Framework-specific rules should be named using the `use` or `no` prefix followed by the framework name (e.g., `noVueReservedProps`)

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noInvalid` prefix for rules that report runtime errors from mistyping (e.g., `noInvalidConstructorSuper`)

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Rule diagnostics must explain to the user what the error is, why it is triggered, and what should be done to fix it following the three pillars: (1) what the error is, (2) why the error is triggered, (3) what the user should do

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noUnknown` prefix for rules that report mistyped entities in CSS (e.g., `noUnknownUnit`)

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noMisleading` prefix for rules that report valid but potentially misleading code (e.g., `noMisleadingCharacterClass`)

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noRedundant` prefix for rules that report redundant code (e.g., `noRedundantUseStrict`)

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `useConsistent` prefix for rules that ensure consistency across the codebase (e.g., `useConsistentArrayType`)

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-24T18:05:27.810Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:27.810Z
Learning: Applies to crates/biome_js_formatter/**/*.rs : Import the `FormatNode` trait and implement it for your Node when creating formatters in biome_js_formatter

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-24T18:05:20.371Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:20.371Z
Learning: Applies to crates/biome_formatter/**/biome_*_formatter/src/lib.rs : Expose a public `format_node` function that accepts formatting options and a root syntax node, returning a `FormatResult<Formatted<Context>>` with appropriate documentation

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/src/**/*.rs : Wrap optional rule option fields in `Option<_>` to properly track set vs unset options during configuration merging

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Avoid using `unwrap()` or `expect()` on `Result` and `Option` types; instead use helper functions like `map`, `filter`, `and_then` to maintain code clarity and avoid panics

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `declare_node_union!` macro to query multiple node types at once by joining them into an enum with `Any*Like` naming convention

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : The `run` function of a lint rule should return `Option<Self::State>` or an iterable like `Vec<Self::State>` or `Box<[Self::State]>` to signal zero or more diagnostics

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : The `diagnostic` function must return a `RuleDiagnostic` that defines the message reported to the user using the `markup!` macro

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Lint rules must be implemented using the `Rule` trait with type parameters: `Query` (node type to analyze), `State` (information for signals), `Signals` (return type from run function), and `Options` (rule configuration)

Applied to files:

crates/biome_service/src/file_handlers/json.rs

🧬 Code graph analysis (1)

crates/biome_service/src/file_handlers/json.rs (1)

crates/biome_json_analyze/src/lib.rs (1)

analyze (45-57)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (27)

GitHub Check: Test Node.js API
GitHub Check: Documentation
GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Check JS Files
GitHub Check: Check Dependencies
GitHub Check: End-to-end tests
GitHub Check: Bench (biome_js_formatter)
GitHub Check: Bench (biome_js_analyze)
GitHub Check: Bench (biome_configuration)
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: Bench (biome_js_parser)
GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Bench (biome_css_parser)
GitHub Check: Bench (biome_css_analyze)
GitHub Check: Bench (biome_css_formatter)
GitHub Check: Validate rules documentation
GitHub Check: Bench (biome_tailwind_parser)
GitHub Check: Bench (biome_package)
GitHub Check: Bench (biome_module_graph)
GitHub Check: autofix
GitHub Check: Bench (biome_graphql_formatter)
GitHub Check: Bench (biome_graphql_parser)
GitHub Check: Bench (biome_json_analyze)
GitHub Check: Bench (biome_json_parser)
GitHub Check: Bench (biome_json_formatter)
GitHub Check: Parser conformance

🔇 Additional comments (3)

crates/biome_service/src/file_handlers/json.rs (3)

30-30: LGTM!

Import updated to include the new JsonAnalyzeServices wrapper type.

531-537: LGTM!

Good fix — configuration_source now correctly uses params.settings.full_source(), enabling NoBiomeFirstException to inspect extended configurations.

606-610: LGTM!

Consistent with lint() — extended configuration is now available for code actions as well.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

crates/biome_service/src/file_handlers/json.rs (1)
669-673: Optional: hoist configuration_source out of the fix_all loop

Behaviour here is correct and consistent with lint/code-actions; fix_all now has the extended config view it needs. If you fancy a tiny tidy-up, you could precompute the configuration source once and reuse it in the loop, avoiding repeated lookups:
-    loop {
-        let services = JsonAnalyzeServices {
-            file_source,
-            configuration_source: params.settings.full_source(),
-        };
+    let configuration_source = params.settings.full_source();
+    loop {
+        let services = JsonAnalyzeServices {
+            file_source,
+            configuration_source: configuration_source.clone(),
+        };
Pure micro-optimisation, feel free to ignore if you prefer the current explicit version.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 07ecfb2 and 1a2be8e.

📒 Files selected for processing (2)

crates/biome_service/src/file_handlers/json.rs (4 hunks)
crates/biome_service/src/workspace.rs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

crates/biome_service/src/workspace.rs

🧰 Additional context used

📓 Path-based instructions (1)

**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

**/*.rs: Use the dbg!() macro for debugging output during testing, and pass the --show-output flag to cargo to view debug output
Use cargo t or cargo test to run tests; for a single test, pass the test name after the test command
Use snapshot testing with the insta crate; run cargo insta accept, cargo insta reject, or cargo insta review to manage snapshot changes
Write doctests as doc comments with code blocks; the code inside code blocks will be run during the testing phase
Use just f (alias for just format) to format Rust and TOML files before committing

Files:

crates/biome_service/src/file_handlers/json.rs

🧠 Learnings (29)

📓 Common learnings

Learnt from: arendjr
Repo: biomejs/biome PR: 7593
File: crates/biome_service/src/workspace/server.rs:1306-1306
Timestamp: 2025-09-25T12:32:59.003Z
Learning: In the biomejs/biome project, do not flag compilation errors during code review as they are handled by the existing test infrastructure and CI. Focus on other code quality aspects instead.

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Commit rule changes with message format: `feat(biome_<crate>): <ruleName>` to follow Biome's conventional commit style

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Biome linter is designed to work across languages, so rule naming should be generic if potentially implementable for multiple languages, or specific if meant for one language only

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noExcessive` prefix for rules that report code exceeding configurable limits (e.g., `noExcessiveNestedTestSuites`)

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/src/**/*.rs : Implement the `Merge` trait for rule options to define how options from extended configuration merge with user configuration (usually reset instead of extend)

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : For rules ported from other ecosystems like ESLint or Clippy, add a `sources` field with `RuleSource` metadata using `.same()` for identical behavior or `.inspired()` for different behavior

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Check if a variable is global before banning it to avoid false positives when the variable is redeclared in local scope; use the semantic model to verify global scope

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/src/**/*.rs : Rule options struct fields should use `#[serde(rename_all = "camelCase")]`, `#[serde(deny_unknown_fields)]`, and `#[serde(default)]` attributes for proper JSON serialization

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use language tags in documentation code blocks (js, ts, tsx, json, css) and order properties consistently as: language, then `expect_diagnostic`, then options modifiers, then `ignore`, then `file=path`

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Code actions must specify a `fix_kind` field in the `declare_lint_rule!` macro as either `FixKind::Safe` or `FixKind::Unsafe` to indicate whether fixes always preserve program behavior

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use `Semantic<T>` query type instead of `Ast<T>` when a rule needs to access the semantic model for binding references and scope information

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : The `action` function must return a `JsRuleAction` (or equivalent language-specific action type) with category `ctx.action_category(ctx.category(), ctx.group())` and applicability from `ctx.metadata().applicability()`

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Deprecate rules by adding a `deprecated` field to the `declare_lint_rule!` macro with a message explaining the reason for deprecation (e.g., 'Use the rule noAnotherVar')

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : When using multiple services in a rule, use `ctx.get_service::<ServiceType>()` to retrieve services running in the second phase when query runs during that phase

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Implement custom `Queryable` types and `Visitor` traits for rules requiring deep AST inspection to avoid redundant traversal passes

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noExcessive` prefix for rules that report code exceeding configurable limits (e.g., `noExcessiveNestedTestSuites`)

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noRestricted` prefix for rules that report user-banned entities (e.g., `noRestrictedGlobals`)

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Framework-specific rules should be named using the `use` or `no` prefix followed by the framework name (e.g., `noVueReservedProps`)

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noInvalid` prefix for rules that report runtime errors from mistyping (e.g., `noInvalidConstructorSuper`)

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Rule diagnostics must explain to the user what the error is, why it is triggered, and what should be done to fix it following the three pillars: (1) what the error is, (2) why the error is triggered, (3) what the user should do

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noUnknown` prefix for rules that report mistyped entities in CSS (e.g., `noUnknownUnit`)

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noMisleading` prefix for rules that report valid but potentially misleading code (e.g., `noMisleadingCharacterClass`)

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noRedundant` prefix for rules that report redundant code (e.g., `noRedundantUseStrict`)

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `useConsistent` prefix for rules that ensure consistency across the codebase (e.g., `useConsistentArrayType`)

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-24T18:05:27.810Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:27.810Z
Learning: Applies to crates/biome_js_formatter/**/*.rs : Import the `FormatNode` trait and implement it for your Node when creating formatters in biome_js_formatter

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-24T18:05:20.371Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:20.371Z
Learning: Applies to crates/biome_formatter/**/biome_*_formatter/src/lib.rs : Expose a public `format_node` function that accepts formatting options and a root syntax node, returning a `FormatResult<Formatted<Context>>` with appropriate documentation

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/src/**/*.rs : Wrap optional rule option fields in `Option<_>` to properly track set vs unset options during configuration merging

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/src/**/*.rs : Rule options must be defined in the `biome_rule_options` crate and implement traits: `Deserializable`, `Merge`, `Serialize`, `Deserialize`, and `JsonSchema`

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Avoid using `unwrap()` or `expect()` on `Result` and `Option` types; instead use helper functions like `map`, `filter`, `and_then` to maintain code clarity and avoid panics

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `declare_node_union!` macro to query multiple node types at once by joining them into an enum with `Any*Like` naming convention

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : The `run` function of a lint rule should return `Option<Self::State>` or an iterable like `Vec<Self::State>` or `Box<[Self::State]>` to signal zero or more diagnostics

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : The `diagnostic` function must return a `RuleDiagnostic` that defines the message reported to the user using the `markup!` macro

Applied to files:

crates/biome_service/src/file_handlers/json.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Lint rules must be implemented using the `Rule` trait with type parameters: `Query` (node type to analyze), `State` (information for signals), `Signals` (return type from run function), and `Options` (rule configuration)

Applied to files:

crates/biome_service/src/file_handlers/json.rs

🧬 Code graph analysis (1)

crates/biome_service/src/file_handlers/json.rs (1)

crates/biome_json_analyze/src/lib.rs (1)

analyze (45-57)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (27)

GitHub Check: Bench (biome_configuration)
GitHub Check: Check JS Files
GitHub Check: autofix
GitHub Check: Documentation
GitHub Check: Bench (biome_json_parser)
GitHub Check: Bench (biome_json_analyze)
GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Bench (biome_json_formatter)
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: End-to-end tests
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Check Dependencies
GitHub Check: Bench (biome_module_graph)
GitHub Check: Bench (biome_css_formatter)
GitHub Check: Bench (biome_css_analyze)
GitHub Check: Test Node.js API
GitHub Check: Bench (biome_css_parser)
GitHub Check: Parser conformance
GitHub Check: Bench (biome_graphql_formatter)
GitHub Check: Bench (biome_graphql_parser)
GitHub Check: Validate rules documentation
GitHub Check: Bench (biome_js_formatter)
GitHub Check: Bench (biome_package)
GitHub Check: Bench (biome_tailwind_parser)
GitHub Check: Bench (biome_js_parser)
GitHub Check: Bench (biome_js_analyze)

🔇 Additional comments (3)

crates/biome_service/src/file_handlers/json.rs (3)

30-30: JsonAnalyseServices import looks correct

Importing both JsonAnalyzeServices and analyze here matches the updated biome_json_analyze API and keeps the call sites tidy; no changes needed.

531-537: Lint now correctly threads configuration_source into analysis

Passing params.settings.full_source() into JsonAnalyzeServices means JSON linting can finally see extended configuration, so rules like noBiomeFirstException can reason about inherited ** patterns; this also mirrors the fix_all path, which is exactly what we want.

606-610: Code actions respect extended configuration as well

Threading workspace.full_source() into JsonAnalyzeServices here keeps code actions in lockstep with lint/fix-all regarding extended configs, so suggested fixes should no longer disagree with inherited settings—nice bit of plumbing.

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (2)

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs (2)
119-119: Consider a clearer variable name.

extends_root sounds like it holds the root node of extends, but it's actually a boolean indicating whether extends exists. Perhaps has_extends would be clearer.

259-262: Consider adding Debug derive.

A #[derive(Debug)] would be handy for test assertions and debugging. Also, if this enum is only used internally, pub(crate) would be more appropriate.
+#[derive(Debug)]
+pub(crate) enum ViolationKind {
-pub enum ViolationKind {
     ExtendedStar(TextRange, JsonArrayElementList),
     NoStar(TextRange, JsonMember),
 }

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1a2be8e and 8602c87.

⛔ Files ignored due to path filters (1)

packages/@biomejs/backend-jsonrpc/src/workspace.ts is excluded by !**/backend-jsonrpc/src/workspace.ts and included by **

📒 Files selected for processing (1)

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs (6 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

**/*.rs: Use the dbg!() macro for debugging output during testing, and pass the --show-output flag to cargo to view debug output
Use cargo t or cargo test to run tests; for a single test, pass the test name after the test command
Use snapshot testing with the insta crate; run cargo insta accept, cargo insta reject, or cargo insta review to manage snapshot changes
Write doctests as doc comments with code blocks; the code inside code blocks will be run during the testing phase
Use just f (alias for just format) to format Rust and TOML files before committing

Files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

🧠 Learnings (27)

📓 Common learnings

Learnt from: arendjr
Repo: biomejs/biome PR: 7593
File: crates/biome_service/src/workspace/server.rs:1306-1306
Timestamp: 2025-09-25T12:32:59.003Z
Learning: In the biomejs/biome project, do not flag compilation errors during code review as they are handled by the existing test infrastructure and CI. Focus on other code quality aspects instead.

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Commit rule changes with message format: `feat(biome_<crate>): <ruleName>` to follow Biome's conventional commit style

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Biome linter is designed to work across languages, so rule naming should be generic if potentially implementable for multiple languages, or specific if meant for one language only

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noExcessive` prefix for rules that report code exceeding configurable limits (e.g., `noExcessiveNestedTestSuites`)

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/src/**/*.rs : Implement the `Merge` trait for rule options to define how options from extended configuration merge with user configuration (usually reset instead of extend)

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noRestricted` prefix for rules that report user-banned entities (e.g., `noRestrictedGlobals`)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/src/**/*.rs : Rule options must be defined in the `biome_rule_options` crate and implement traits: `Deserializable`, `Merge`, `Serialize`, `Deserialize`, and `JsonSchema`

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : For rules ported from other ecosystems like ESLint or Clippy, add a `sources` field with `RuleSource` metadata using `.same()` for identical behavior or `.inspired()` for different behavior

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noInvalid` prefix for rules that report runtime errors from mistyping (e.g., `noInvalidConstructorSuper`)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noExcessive` prefix for rules that report code exceeding configurable limits (e.g., `noExcessiveNestedTestSuites`)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Implement custom `Queryable` types and `Visitor` traits for rules requiring deep AST inspection to avoid redundant traversal passes

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noUnknown` prefix for rules that report mistyped entities in CSS (e.g., `noUnknownUnit`)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/nursery/**/*.rs : New rules must be placed inside the `nursery` group as an incubation space exempt from semantic versioning, with promotion to appropriate groups done during minor/major releases

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noUndeclared` prefix for rules that report undefined entities (e.g., `noUndeclaredVariables`)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : In rule documentation code blocks, mark invalid examples with the `expect_diagnostic` property and valid examples without it; each invalid example must emit exactly one diagnostic

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : The `action` function must return a `JsRuleAction` (or equivalent language-specific action type) with category `ctx.action_category(ctx.category(), ctx.group())` and applicability from `ctx.metadata().applicability()`

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Rules should use the `no` prefix naming convention when the sole intention is to forbid a single concept (e.g., `noDebugger` to disallow debugger statements)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Framework-specific rules should be named using the `use` or `no` prefix followed by the framework name (e.g., `noVueReservedProps`)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noMisleading` prefix for rules that report valid but potentially misleading code (e.g., `noMisleadingCharacterClass`)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noDuplicate` prefix for rules that report duplication overriding previous occurrences (e.g., `noDuplicateObjectKeys`)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noUnsafe` prefix for rules that report code leading to runtime failures (e.g., `noUnsafeOptionalChaining`)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Rules should use the `use` prefix naming convention when the sole intention is to mandate a single concept (e.g., `useValidLang` to enforce valid HTML lang attribute values)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/src/**/*.rs : Wrap optional rule option fields in `Option<_>` to properly track set vs unset options during configuration merging

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Lint rules must be implemented using the `Rule` trait with type parameters: `Query` (node type to analyze), `State` (information for signals), `Signals` (return type from run function), and `Options` (rule configuration)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-24T18:06:03.545Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_parser/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:03.545Z
Learning: Applies to crates/biome_parser/**/src/**/*.rs : Parse rules must return `ParsedSyntax::Absent` if the rule can't predict by the next token(s) if they form the expected node, and must not progress the parser in this case

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : The `run` function of a lint rule should return `Option<Self::State>` or an iterable like `Vec<Self::State>` or `Box<[Self::State]>` to signal zero or more diagnostics

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : When navigating CST nodes that return `Result`, use the try operator `?` to convert to `Option`, or use `let else` pattern for `Vec` return types in rule run functions

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : The `diagnostic` function must return a `RuleDiagnostic` that defines the message reported to the user using the `markup!` macro

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use `rule_category!()` macro instead of dynamic string parsing to refer to rule diagnostic categories for compile-time validation

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Set rule severity to `error` for correctness/security/a11y rules, `warn` for suspicious/performance rules, `info` for style/complexity rules, and `info` for actions

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Rule diagnostics must explain to the user what the error is, why it is triggered, and what should be done to fix it following the three pillars: (1) what the error is, (2) why the error is triggered, (3) what the user should do

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

🧬 Code graph analysis (1)

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs (1)

crates/biome_json_analyze/src/services/config_source.rs (1)

extends (14-18)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (26)

GitHub Check: Check JS Files
GitHub Check: Bench (biome_graphql_parser)
GitHub Check: Bench (biome_graphql_formatter)
GitHub Check: Test Node.js API
GitHub Check: Bench (biome_js_parser)
GitHub Check: Bench (biome_js_formatter)
GitHub Check: Bench (biome_module_graph)
GitHub Check: Bench (biome_js_analyze)
GitHub Check: autofix
GitHub Check: Bench (biome_json_analyze)
GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: Documentation
GitHub Check: End-to-end tests
GitHub Check: Bench (biome_json_parser)
GitHub Check: Parser conformance
GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Bench (biome_json_formatter)
GitHub Check: Bench (biome_package)
GitHub Check: Check Dependencies
GitHub Check: Bench (biome_configuration)
GitHub Check: Bench (biome_tailwind_parser)
GitHub Check: Bench (biome_css_formatter)
GitHub Check: Bench (biome_css_analyze)
GitHub Check: Bench (biome_css_parser)

🔇 Additional comments (3)

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs (3)

1-10: LGTM!

Imports are appropriately updated to support the new ConfigSource-based query and ViolationKind state.

166-197: LGTM!

Diagnostic messages are clear, pattern matching is correct, and follows the rule diagnostic best practices.

199-256: LGTM!

Action implementations correctly handle array mutation with proper separator generation. The use of ctx.metadata().action_category() and ctx.metadata().applicability() aligns with the coding guidelines.

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

coderabbitai

Actionable comments posted: 0

♻️ Duplicate comments (1)

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs (1)

121-145: Early return still skips NoStar diagnostics when extends is present

When extends_root is true and includes_first_value exists but is not the "**" + extended catch-all case, this block returns None and prevents the later NoStar branch from ever running. For a config like the one from the earlier review (extends: ["./base.json"], files.includes: ["!dist"]), this means the rule now silently does nothing instead of flagging the leading ! violation.

You can fix this by only returning from the ExtendedStar path and otherwise falling through to the NoStar logic:

-        if extends_root && let Some(includes_first_value) = includes_first_value {
-            return if includes_first_value.inner_string_text().ok()?.text() == "**"
-                && extends_starts_with_catch_all
-            {
-                let includes_value = includes.value().ok()?;
-                let includes_value = includes_value.as_json_array_value()?;
-                let includes_value = includes_value.elements();
-                Some(ViolationKind::ExtendedStar(
-                    includes_first_value.range(),
-                    includes_value,
-                ))
-            } else {
-                None
-            };
-        }
+        if extends_root {
+            if let Some(includes_first_value) = includes_first_value {
+                if includes_first_value.inner_string_text().ok()?.text() == "**"
+                    && extends_starts_with_catch_all
+                {
+                    let includes_value = includes.value().ok()?;
+                    let includes_value = includes_value.as_json_array_value()?;
+                    let includes_value = includes_value.elements();
+                    return Some(ViolationKind::ExtendedStar(
+                        includes_first_value.range(),
+                        includes_value,
+                    ));
+                }
+            }
+        }

This preserves the ExtendedStar behaviour while still allowing NoStar to trigger whenever appropriate.

Also applies to: 147-160

🧹 Nitpick comments (2)

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs (2)

13-41: Extended documentation and examples read clearly

The new section on catch-all ** with extends plus the JSON/JSONC examples are clear and syntactically valid, and they nicely complement the existing “Leading of negated patterns” docs. If you ever feel energetic, a short “Valid” counterpart for the extended ** case would round it out, but it’s already in good shape.

Also applies to: 43-68

167-196: Diagnostics, fixes, and ViolationKind split are coherent

The ViolationKind::{ExtendedStar, NoStar} split keeps the diagnostics and fixes nicely targeted, and both messages explain the problem and remediation clearly. The mutation logic for both variants looks safe and deterministic, with separator construction guarded by new_list.len() > 1 to avoid underflow and predictable reformatting of the array. If you fancy a micro clean-up, you could replace the manual iter.next(); with includes_value.iter().skip(1) in the ExtendedStar branch, but that’s purely cosmetic.

Also applies to: 199-255, 259-262

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8602c87 and 3eb3327.

📒 Files selected for processing (2)

.changeset/cruel-meals-talk.md (1 hunks)
crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs (6 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

.changeset/cruel-meals-talk.md

🧰 Additional context used

📓 Path-based instructions (1)

**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

**/*.rs: Use the dbg!() macro for debugging output during testing, and pass the --show-output flag to cargo to view debug output
Use cargo t or cargo test to run tests; for a single test, pass the test name after the test command
Use snapshot testing with the insta crate; run cargo insta accept, cargo insta reject, or cargo insta review to manage snapshot changes
Write doctests as doc comments with code blocks; the code inside code blocks will be run during the testing phase
Use just f (alias for just format) to format Rust and TOML files before committing

Files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

🧠 Learnings (33)

📓 Common learnings

Learnt from: arendjr
Repo: biomejs/biome PR: 7593
File: crates/biome_service/src/workspace/server.rs:1306-1306
Timestamp: 2025-09-25T12:32:59.003Z
Learning: In the biomejs/biome project, do not flag compilation errors during code review as they are handled by the existing test infrastructure and CI. Focus on other code quality aspects instead.

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Commit rule changes with message format: `feat(biome_<crate>): <ruleName>` to follow Biome's conventional commit style

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noExcessive` prefix for rules that report code exceeding configurable limits (e.g., `noExcessiveNestedTestSuites`)

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Biome linter is designed to work across languages, so rule naming should be generic if potentially implementable for multiple languages, or specific if meant for one language only

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/src/**/*.rs : Implement the `Merge` trait for rule options to define how options from extended configuration merge with user configuration (usually reset instead of extend)

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/src/**/*.rs : Rule options must be defined in the `biome_rule_options` crate and implement traits: `Deserializable`, `Merge`, `Serialize`, `Deserialize`, and `JsonSchema`

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noExcessive` prefix for rules that report code exceeding configurable limits (e.g., `noExcessiveNestedTestSuites`)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noRestricted` prefix for rules that report user-banned entities (e.g., `noRestrictedGlobals`)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : For rules ported from other ecosystems like ESLint or Clippy, add a `sources` field with `RuleSource` metadata using `.same()` for identical behavior or `.inspired()` for different behavior

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noInvalid` prefix for rules that report runtime errors from mistyping (e.g., `noInvalidConstructorSuper`)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/src/**/*.rs : Rule options struct fields should use `#[serde(rename_all = "camelCase")]`, `#[serde(deny_unknown_fields)]`, and `#[serde(default)]` attributes for proper JSON serialization

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noUnknown` prefix for rules that report mistyped entities in CSS (e.g., `noUnknownUnit`)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/src/**/*.rs : Wrap optional rule option fields in `Option<_>` to properly track set vs unset options during configuration merging

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/nursery/**/*.rs : New rules must be placed inside the `nursery` group as an incubation space exempt from semantic versioning, with promotion to appropriate groups done during minor/major releases

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Document rules with a one-line brief description in the first paragraph of the doc comment, followed by detailed paragraphs, `## Examples` section with `### Invalid` and `### Valid` subsections, and optional `## Options` section

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use language tags in documentation code blocks (js, ts, tsx, json, css) and order properties consistently as: language, then `expect_diagnostic`, then options modifiers, then `ignore`, then `file=path`

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : In rule documentation code blocks, mark invalid examples with the `expect_diagnostic` property and valid examples without it; each invalid example must emit exactly one diagnostic

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-24T18:06:03.545Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_parser/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:03.545Z
Learning: Applies to crates/biome_parser/**/*.ungram : Add a legend comment to `.ungram` files explaining the grammar syntax including comments, non-terminals, tokens, sequences, alternations, repetitions, and optional elements

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Rule diagnostics must explain to the user what the error is, why it is triggered, and what should be done to fix it following the three pillars: (1) what the error is, (2) why the error is triggered, (3) what the user should do

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : The `declare_lint_rule!` macro must include metadata fields: `version` (set to 'next'), `name` (rule identifier), `language` (applicable language), `recommended` (boolean), and optional fields like `severity`, `fix_kind`, `sources`, `domains`, and `deprecated`

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-24T18:06:03.545Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_parser/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:03.545Z
Learning: Applies to crates/biome_parser/**/*.ungram : Nodes that represent a list must end with the postfix `List`, e.g., `HtmlAttributeList`, and lists are mandatory (not optional) but empty by default

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noMisleading` prefix for rules that report valid but potentially misleading code (e.g., `noMisleadingCharacterClass`)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : When navigating CST nodes that return `Result`, use the try operator `?` to convert to `Option`, or use `let else` pattern for `Vec` return types in rule run functions

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Framework-specific rules should be named using the `use` or `no` prefix followed by the framework name (e.g., `noVueReservedProps`)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noUnsafe` prefix for rules that report code leading to runtime failures (e.g., `noUnsafeOptionalChaining`)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noEmpty` prefix for rules that report empty code (e.g., `noEmptyBlockStatements`)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noDuplicate` prefix for rules that report duplication overriding previous occurrences (e.g., `noDuplicateObjectKeys`)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Avoid using `unwrap()` or `expect()` on `Result` and `Option` types; instead use helper functions like `map`, `filter`, `and_then` to maintain code clarity and avoid panics

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : The `action` function must return a `JsRuleAction` (or equivalent language-specific action type) with category `ctx.action_category(ctx.category(), ctx.group())` and applicability from `ctx.metadata().applicability()`

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Rules should use the `no` prefix naming convention when the sole intention is to forbid a single concept (e.g., `noDebugger` to disallow debugger statements)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Rules should use the `use` prefix naming convention when the sole intention is to mandate a single concept (e.g., `useValidLang` to enforce valid HTML lang attribute values)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Lint rules must be implemented using the `Rule` trait with type parameters: `Query` (node type to analyze), `State` (information for signals), `Signals` (return type from run function), and `Options` (rule configuration)

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-24T18:06:03.545Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_parser/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:03.545Z
Learning: Applies to crates/biome_parser/**/src/**/*.rs : Parse rules must return `ParsedSyntax::Absent` if the rule can't predict by the next token(s) if they form the expected node, and must not progress the parser in this case

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : The `run` function of a lint rule should return `Option<Self::State>` or an iterable like `Vec<Self::State>` or `Box<[Self::State]>` to signal zero or more diagnostics

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : The `diagnostic` function must return a `RuleDiagnostic` that defines the message reported to the user using the `markup!` macro

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use `rule_category!()` macro instead of dynamic string parsing to refer to rule diagnostic categories for compile-time validation

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Set rule severity to `error` for correctness/security/a11y rules, `warn` for suspicious/performance rules, `info` for style/complexity rules, and `info` for actions

Applied to files:

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)

GitHub Check: Validate rules documentation
GitHub Check: Check JS Files
GitHub Check: Test Node.js API
GitHub Check: Bench (biome_package)
GitHub Check: Bench (biome_js_analyze)
GitHub Check: Bench (biome_graphql_formatter)
GitHub Check: Bench (biome_graphql_parser)
GitHub Check: Bench (biome_js_formatter)
GitHub Check: Bench (biome_module_graph)
GitHub Check: Bench (biome_js_parser)
GitHub Check: autofix
GitHub Check: Parser conformance
GitHub Check: Bench (biome_json_analyze)
GitHub Check: Bench (biome_css_parser)
GitHub Check: Bench (biome_css_formatter)
GitHub Check: Bench (biome_css_analyze)
GitHub Check: Bench (biome_json_formatter)
GitHub Check: Bench (biome_json_parser)
GitHub Check: Bench (biome_configuration)
GitHub Check: Bench (biome_tailwind_parser)

🔇 Additional comments (1)

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs (1)

1-2: Imports and rule wiring to ConfigSource<JsonRoot> look sound

Pulling in ConfigSource, JsonRuleAction, JsonRoot, JsonArrayElementList, TextRange, etc., lines up with the new configuration plumbing, and switching Query = ConfigSource<JsonRoot> / State = ViolationKind integrates cleanly with RuleContext. The ctx.extends() scan for upstream ** patterns plus the top-level files.includes/extends object navigation looks consistent and guarded with ok()?/is_some_and, so there are no obvious robustness issues here.

Also applies to: 8-9, 80-82, 86-86, 89-97, 109-121

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

ematipico requested review from a team December 1, 2025 08:46

fix(lint): improve noBiomeFirstException

6f29ac2

ematipico force-pushed the fix/biome-lint-rule branch from 82d9c80 to 6f29ac2 Compare December 1, 2025 08:47

[autofix.ci] apply automated fixes

9af1cb5

coderabbitai bot reviewed Dec 1, 2025

View reviewed changes

.changeset/cruel-meals-talk.md Outdated Show resolved Hide resolved

crates/biome_service/src/file_handlers/json.rs Show resolved Hide resolved

coderabbitai bot reviewed Dec 1, 2025

View reviewed changes

fix(lint): improve noBiomeFirstException

1a2be8e

ematipico force-pushed the fix/biome-lint-rule branch from 07ecfb2 to 1a2be8e Compare December 1, 2025 12:08

coderabbitai bot reviewed Dec 1, 2025

View reviewed changes

autofix-ci bot and others added 2 commits December 1, 2025 12:15

[autofix.ci] apply automated fixes

9ddbffb

fix(lint): improve noBiomeFirstException

8602c87

coderabbitai bot reviewed Dec 1, 2025

View reviewed changes

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs Show resolved Hide resolved

crates/biome_json_analyze/src/lint/suspicious/no_biome_first_exception.rs Show resolved Hide resolved

dyc3 approved these changes Dec 1, 2025

View reviewed changes

ematipico and others added 2 commits December 1, 2025 14:35

feedback

c6c575a

Apply suggestion from @coderabbitai[bot]

3eb3327

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

coderabbitai bot reviewed Dec 1, 2025

View reviewed changes

ematipico merged commit 153e3c6 into main Dec 1, 2025
32 checks passed

ematipico deleted the fix/biome-lint-rule branch December 1, 2025 15:12

github-actions bot mentioned this pull request Dec 1, 2025

ci: release #8286

Merged

This was referenced Dec 15, 2025

ci: release #8467

Merged

ci: release #8469

Merged

coderabbitai bot mentioned this pull request Dec 16, 2025

refactor(cli): make commands more generic #8485

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(lint): improve `noBiomeFirstException` #8326

fix(lint): improve `noBiomeFirstException` #8326

ematipico commented Dec 1, 2025

Uh oh!

changeset-bot bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(lint): improve noBiomeFirstException #8326

fix(lint): improve noBiomeFirstException #8326

Conversation

ematipico commented Dec 1, 2025

Summary

Test Plan

Docs

Uh oh!

changeset-bot bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

github-actions bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Parser conformance results on

js/262

jsx/babel

symbols/microsoft

ts/babel

ts/microsoft

Uh oh!

codspeed-hq bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #8326 will not alter performance

Summary

Footnotes

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(lint): improve `noBiomeFirstException` #8326

fix(lint): improve `noBiomeFirstException` #8326

changeset-bot bot commented Dec 1, 2025 •

edited

Loading

coderabbitai bot commented Dec 1, 2025 •

edited

Loading

github-actions bot commented Dec 1, 2025 •

edited

Loading

codspeed-hq bot commented Dec 1, 2025 •

edited

Loading