Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dyc3
Copy link
Contributor

@dyc3 dyc3 commented Dec 15, 2025

Summary

Test Plan

Docs

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2025

⚠️ No Changeset found

Latest commit: e989de8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

Walkthrough

The release workflow configuration has been refactored to use matrix-based per-target artifact naming and paths instead of static names. Artifact uploads now employ dynamic naming using the matrix target variable, and paths have been consolidated to a single per-target package location. Node.js registry URL strings have been updated to use consistent double-quote formatting. Minor formatting adjustments have also been made throughout the workflow file.

Possibly related PRs

Suggested labels

A-Project

Suggested reviewers

  • ematipico

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal, containing only the PR template without substantive content, making it difficult to assess its relevance to the changeset. Fill in the Summary section with motivation for the changes and expected outcomes to provide context for reviewers.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing wasm artifact names in the CI release workflow, which aligns with the changeset modifications.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-release-wasm

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 397547a and e989de8.

📒 Files selected for processing (1)
  • .github/workflows/release.yml (3 hunks)
🔇 Additional comments (3)
.github/workflows/release.yml (3)

378-378: Formatting change: single to double quotes for registry URL.

Minor formatting update from single to double quotes. No functional impact.


452-452: Formatting change: single to double quotes for registry URL.

Consistent with line 378; formatting only.


286-289: The artifact naming pattern is consistent and correct. Artifacts named ${{ matrix.target }}-artefact (wasm-bundler-artefact, wasm-nodejs-artefact, wasm-web-artefact) will all be matched by the download pattern wasm-*. The consolidated upload path ./packages/@biomejs/${{ matrix.target }} targets the correct directories, which have been verified to exist. No issues here.


Comment @coderabbitai help to get the list of available commands and usage tips.

uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
with:
name: wasm-artefacts
name: ${{ matrix.target }}-artefact
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL artefact is an alternative spelling of artifact

@dyc3 dyc3 merged commit 1303f9e into main Dec 15, 2025
3 checks passed
@dyc3 dyc3 deleted the fix-release-wasm branch December 15, 2025 14:34
l0ngvh pushed a commit to l0ngvh/biome that referenced this pull request Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants