-
-
Notifications
You must be signed in to change notification settings - Fork 794
chore: add kraken as bronze sponsor #8486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughAdded two new sponsor entries (Graphite and Kraken Tech) across the Biome README files (README.md and multiple translated READMEs). Changes insert additional cells with sponsor links and logos into the existing Bronze/Platinum sponsor tables; no code, logic, exports, or behaviour were modified. Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
ematipico
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update all the readme files (the translated ones)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/@biomejs/biome/README.ru.md (1)
177-182: Sponsor additions verified; URLs are live.Both graphite.dev and kraken.tech are active and valid websites. The HTML structure and formatting align perfectly with existing sponsors. GitHub avatar IDs (61942612 and 105941848) cannot be verified via web search, so please confirm those resolve to the correct organisations before merging.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (12)
packages/@biomejs/biome/README.es.md(1 hunks)packages/@biomejs/biome/README.fr.md(1 hunks)packages/@biomejs/biome/README.hi.md(1 hunks)packages/@biomejs/biome/README.ja.md(1 hunks)packages/@biomejs/biome/README.kr.md(1 hunks)packages/@biomejs/biome/README.md(1 hunks)packages/@biomejs/biome/README.pl.md(1 hunks)packages/@biomejs/biome/README.pt-BR.md(1 hunks)packages/@biomejs/biome/README.ru.md(1 hunks)packages/@biomejs/biome/README.uk.md(1 hunks)packages/@biomejs/biome/README.zh-CN.md(1 hunks)packages/@biomejs/biome/README.zh-TW.md(1 hunks)
✅ Files skipped from review due to trivial changes (7)
- packages/@biomejs/biome/README.zh-TW.md
- packages/@biomejs/biome/README.pt-BR.md
- packages/@biomejs/biome/README.uk.md
- packages/@biomejs/biome/README.zh-CN.md
- packages/@biomejs/biome/README.pl.md
- packages/@biomejs/biome/README.hi.md
- packages/@biomejs/biome/README.fr.md
🚧 Files skipped from review as they are similar to previous changes (1)
- packages/@biomejs/biome/README.md
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-05T14:43:29.581Z
Learnt from: dyc3
Repo: biomejs/biome PR: 7081
File: packages/@biomejs/biome/configuration_schema.json:7765-7781
Timestamp: 2025-08-05T14:43:29.581Z
Learning: The file `packages/biomejs/biome/configuration_schema.json` is auto-generated and should not be manually edited or reviewed for schema issues; any changes should be made at the code generation source.
Applied to files:
packages/@biomejs/biome/README.kr.mdpackages/@biomejs/biome/README.es.mdpackages/@biomejs/biome/README.ja.md
🔇 Additional comments (3)
packages/@biomejs/biome/README.ja.md (1)
162-167: Sponsors added with consistent structure and proper formatting.Both Graphite and Kraken Tech entries follow the established pattern perfectly—same alignment attributes, UTM tracking, image dimensions, and alt text as existing bronze sponsors. The entries are rolled out consistently across all 12 language README translations. Good attention to detail on accessibility.
packages/@biomejs/biome/README.kr.md (1)
174-179: Sponsor entries are well-structured and consistent.The new Graphite and Kraken Tech sponsor cells follow the established pattern perfectly—proper HTML nesting, UTM tracking, accessibility-friendly alt text, and consistent sizing.
One minor note: the PR title mentions only "Kraken," but the changes add both Graphite and Kraken Tech. Ensure the PR description reflects both additions.
packages/@biomejs/biome/README.es.md (1)
175-180: Sponsor entries consistently applied across all localised README variants.Both Graphite and Kraken Tech sponsor entries are present across all 12 localized README files with identical HTML structure and URLs. The Spanish README matches the Korean version exactly—only line numbers differ due to varying content lengths in each locale. Both sponsor URLs are active and properly resolve.
Summary
Test Plan
Docs