fix(plugins): normalize relative plugin paths during config loading #8524

JacquesLeupin · 2025-12-20T16:08:56Z

Summary

In monorepos where nested configurations use extends: "//", relative plugin paths declared in the root configuration could be resolved relative to the child configuration directory, causing plugin loading to fail with "Cannot read file." This is related to the extends: "//" behavior discussed in #8360.

This PR normalizes plugin paths relative to the directory of the configuration file that declares them so that merged configurations keep consistent plugin path semantics.

AI disclosure: I used AI assistance (Cursor / GPT) to explore the codebase and draft the fix and tests.

Test Plan

Added unit tests for plugin path normalization.
Added a regression test covering a monorepo where root config plugins are inherited by a child config using extends: "//".

Commands run:

cargo test -p biome_plugin_loader
cargo test -p biome_cli --test main -- cases::monorepo
cargo test -p biome_service
cargo fmt --check
cargo clippy -p biome_service -p biome_cli -p biome_plugin_loader -- -D warnings

Docs

No documentation changes are needed (bugfix only).

changeset-bot · 2025-12-20T16:09:00Z

🦋 Changeset detected

Latest commit: e127306

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-12-20T16:12:08Z

Walkthrough

Normalises plugin paths after configuration extends are applied so relative plugin paths are resolved against the configuration file directory (or the external resolution base if missing). The change mutates plugin path entries in-place for the main configuration and each override pattern after migration/extends, and adds unit and integration tests exercising monorepo extend behaviour.

Possibly related PRs

fix: resolve plugin paths relative to config file when using extends #8365: Implements the same plugin-path normalisation fix with matching monorepo test coverage for extended configurations.
fix(cli): resolve configs from parent paths #8371: Related changes to configuration-path resolution around extends, including fixes for resolving relative extends.

Suggested reviewers

dyc3
ematipico

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly describes the main change—normalising relative plugin paths during configuration loading—which addresses the core fix implemented across multiple files.
Description check	✅ Passed	The description clearly relates to the changeset, explaining the fix for issue #8488 regarding plugin path resolution in monorepos with extended configurations.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e4d063a and e127306.

⛔ Files ignored due to path filters (1)

crates/biome_cli/tests/snapshots/main_cases_monorepo/plugins_from_root_config_work_in_child_config_extends_root.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (5)

.changeset/cruel-clouds-crash.md (1 hunks)
crates/biome_cli/tests/cases/monorepo.rs (1 hunks)
crates/biome_plugin_loader/Cargo.toml (1 hunks)
crates/biome_plugin_loader/src/configuration.rs (3 hunks)
crates/biome_service/src/configuration.rs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

crates/biome_plugin_loader/src/configuration.rs
crates/biome_cli/tests/cases/monorepo.rs

🧰 Additional context used

📓 Path-based instructions (3)

**/Cargo.toml

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Use workspace dependencies defined in root Cargo.toml for internal crates with workspace = true, and use path dependencies for dev-dependencies to avoid requiring published versions

Files:

crates/biome_plugin_loader/Cargo.toml

crates/**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Update inline rustdoc documentation for rules, assists, and their options when adding new features or changing existing features in Rust crates

Files:

crates/biome_service/src/configuration.rs

.changeset/*.md

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Write changesets that are concise (1-3 sentences), user-focused, use past tense for actions taken and present tense for Biome behavior, include code examples for rules, and end sentences with periods

Files:

.changeset/cruel-clouds-crash.md

🧠 Learnings (21)

📚 Learning: 2025-11-24T18:05:20.371Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:20.371Z
Learning: Applies to crates/biome_formatter/**/biome_*_formatter/Cargo.toml : Include development dependencies in `Cargo.toml` for formatter tests: `biome_formatter_test`, `biome_<language>_factory`, `biome_<language>_parser`, `biome_parser`, `biome_service`, `countme`, `iai`, `quickcheck`, `quickcheck_macros`, and `tests_macros`

Applied to files:

crates/biome_plugin_loader/Cargo.toml

📚 Learning: 2025-12-12T10:11:05.564Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-12-12T10:11:05.564Z
Learning: Applies to **/Cargo.toml : Use workspace dependencies defined in root `Cargo.toml` for internal crates with `workspace = true`, and use path dependencies for `dev-dependencies` to avoid requiring published versions

Applied to files:

crates/biome_plugin_loader/Cargo.toml

📚 Learning: 2025-11-24T18:06:12.048Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:12.048Z
Learning: Applies to crates/biome_service/src/workspace*.rs : Implement the Workspace trait in the Biome Service to manage internal state of projects, including open documents, project layout instances, and module graph instances

Applied to files:

crates/biome_plugin_loader/Cargo.toml

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/lib/**/*.rs : Use `rename_all = "camelCase"` in serde derive macro for rule options

Applied to files:

crates/biome_plugin_loader/Cargo.toml

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/lib/**/*.rs : Use `deny_unknown_fields` in serde derive macro for rule options

Applied to files:

crates/biome_plugin_loader/Cargo.toml

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/lib/**/*.rs : Rule options struct must derive `Deserializable`, `Serialize`, `Deserialize`, and optionally `JsonSchema`

Applied to files:

crates/biome_plugin_loader/Cargo.toml

📚 Learning: 2025-11-24T18:05:42.356Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_type_info/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:42.356Z
Learning: Applies to crates/biome_js_type_info/**/*.rs : Use `TypeReference` instead of `Arc` for types that reference other types to avoid stale cache issues when modules are replaced

Applied to files:

crates/biome_plugin_loader/Cargo.toml

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/lib/**/*.rs : Wrap rule options fields in `Option<>` to properly track set and unset options during merge

Applied to files:

crates/biome_plugin_loader/Cargo.toml
crates/biome_service/src/configuration.rs

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Set `version` field to `next` in `declare_lint_rule!` macro

Applied to files:

crates/biome_plugin_loader/Cargo.toml

📚 Learning: 2025-11-24T18:05:42.356Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_type_info/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:42.356Z
Learning: Applies to crates/biome_js_type_info/**/*.rs : Store type data in linear vectors instead of using recursive data structures with `Arc` for improved data locality and performance

Applied to files:

crates/biome_plugin_loader/Cargo.toml

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Use `full_options` code block property for complete biome.json configuration snippets in documentation

Applied to files:

crates/biome_plugin_loader/Cargo.toml

📚 Learning: 2025-11-24T18:06:12.048Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:12.048Z
Learning: Debug the WorkspaceWatcher by starting the daemon with cargo run --bin=biome -- start and running commands such as cargo run --bin=biome -- lint --use-server <path>

Applied to files:

crates/biome_plugin_loader/Cargo.toml

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Rules with `recommended: true` and no domains are enabled by default

Applied to files:

crates/biome_plugin_loader/Cargo.toml

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Rules with `recommended: true` and domains are only enabled when the domain is enabled

Applied to files:

crates/biome_plugin_loader/Cargo.toml

📚 Learning: 2025-11-24T18:04:57.309Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_diagnostics/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:04:57.309Z
Learning: Applies to crates/biome_diagnostics/**/*.rs : Use helper types from the biome_diagnostics::v2 module (CodeFrameAdvice, CommandAdvice, DiffAdvice, LogAdvice) or implement the Advices trait yourself for custom advice handling

Applied to files:

crates/biome_plugin_loader/Cargo.toml

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/lib/**/*.rs : Rule options must be placed inside the `biome_rule_options` crate

Applied to files:

crates/biome_plugin_loader/Cargo.toml

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/lib/**/*.rs : Implement `Merge` trait for rule options to support configuration inheritance

Applied to files:

crates/biome_service/src/configuration.rs

📚 Learning: 2025-11-24T18:06:03.545Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_parser/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:03.545Z
Learning: Applies to crates/biome_parser/**/language_kind.rs : Add a new language prefix to the `LANGUAGE_PREFIXES` constant in `language_kind.rs` file

Applied to files:

crates/biome_service/src/configuration.rs

📚 Learning: 2025-12-12T10:11:05.564Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-12-12T10:11:05.564Z
Learning: Create a changeset for user-facing bug fixes and features using `just new-changeset`, selecting appropriate packages and change type (`major`, `minor`, or `patch`)

Applied to files:

.changeset/cruel-clouds-crash.md

📚 Learning: 2025-08-05T14:43:29.581Z

Learnt from: dyc3
Repo: biomejs/biome PR: 7081
File: packages/@biomejs/biome/configuration_schema.json:7765-7781
Timestamp: 2025-08-05T14:43:29.581Z
Learning: The file `packages/biomejs/biome/configuration_schema.json` is auto-generated and should not be manually edited or reviewed for schema issues; any changes should be made at the code generation source.

Applied to files:

.changeset/cruel-clouds-crash.md

📚 Learning: 2025-12-12T10:11:05.564Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-12-12T10:11:05.564Z
Learning: Applies to .changeset/*.md : Write changesets that are concise (1-3 sentences), user-focused, use past tense for actions taken and present tense for Biome behavior, include code examples for rules, and end sentences with periods

Applied to files:

.changeset/cruel-clouds-crash.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

GitHub Check: Test Node.js API
GitHub Check: Documentation
GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Check Dependencies
GitHub Check: autofix

🔇 Additional comments (3)

.changeset/cruel-clouds-crash.md (1)

1-5: LGTM!

The changeset follows all guidelines: concise, proper tense usage (past for action, present for behaviour), and user-focused description.

crates/biome_plugin_loader/Cargo.toml (1)

18-18: LGTM!

The serde feature addition is correctly configured with workspace = true and aligns with the plugin path normalisation requirements.

crates/biome_service/src/configuration.rs (1)

89-105: Solid implementation!

The normalisation logic is well-placed (after extends and migration), uses safe fallbacks, and correctly handles optional fields. The comment clearly explains the rationale for monorepo scenarios.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions bot added A-CLI Area: CLI A-Project Area: project labels Dec 20, 2025

fix(plugins): normalize relative plugin paths during config loading

e127306

JacquesLeupin force-pushed the fix/plugin-relative-paths-config-merge branch from e4d063a to e127306 Compare December 20, 2025 21:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(plugins): normalize relative plugin paths during config loading #8524

fix(plugins): normalize relative plugin paths during config loading #8524

JacquesLeupin commented Dec 20, 2025

Uh oh!

changeset-bot bot commented Dec 20, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 20, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

fix(plugins): normalize relative plugin paths during config loading #8524

Are you sure you want to change the base?

fix(plugins): normalize relative plugin paths during config loading #8524

Conversation

JacquesLeupin commented Dec 20, 2025

Summary

Test Plan

Docs

Uh oh!

changeset-bot bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

changeset-bot bot commented Dec 20, 2025 •

edited

Loading

coderabbitai bot commented Dec 20, 2025 •

edited

Loading