Codestin Search App

dyc3 · 2025-12-24T14:58:57Z

Summary

Replaces Box<str> in noRedeclare with TokenText.

On the test file I was using, execution time for the rule went from ~1ms to ~560µs.

Test Plan

Docs

changeset-bot · 2025-12-24T14:59:01Z

🦋 Changeset detected

Latest commit: b91b470

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dyc3 · 2025-12-24T14:59:16Z

perf(noRedeclare): reduce string allocations #8571 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

coderabbitai · 2025-12-24T17:04:26Z

Walkthrough

This change optimises the noRedeclare lint rule by replacing the Box<str> type with TokenText for storing binding names throughout the codebase. The modification affects how names are stored in the declarations map, extracted from bindings, compared, and used in diagnostic messages. A corresponding changeset entry documents this performance improvement targeting string allocation reduction.

Suggested reviewers

ematipico

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: replacing Box with TokenText to reduce string allocations in the noRedeclare rule.
Description check	✅ Passed	The description clearly relates to the changeset, explaining the motivation (Box replacement with TokenText) and quantifying the performance improvement achieved.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch dyc3/perf-no-redeclare

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1022c76 and b91b470.

📒 Files selected for processing (2)

.changeset/neat-items-tan.md
crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

🧰 Additional context used

📓 Path-based instructions (1)

**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

**/*.rs: Use inline rustdoc documentation for rules, assists, and their options
Use the dbg!() macro for debugging output in Rust tests and code
Use doc tests (doctest) format with code blocks in rustdoc comments; ensure assertions pass in tests

Files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

🧠 Learnings (23)

📓 Common learnings

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Avoid string allocations by comparing against `&str` or using `TokenText`

📚 Learning: 2025-12-21T21:15:03.782Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-12-21T21:15:03.782Z
Learning: Changesets should describe user-facing changes only; internal refactoring without behavior changes does not require a changeset

Applied to files:

.changeset/neat-items-tan.md

📚 Learning: 2025-08-05T14:43:29.581Z

Learnt from: dyc3
Repo: biomejs/biome PR: 7081
File: packages/@biomejs/biome/configuration_schema.json:7765-7781
Timestamp: 2025-08-05T14:43:29.581Z
Learning: The file `packages/biomejs/biome/configuration_schema.json` is auto-generated and should not be manually edited or reviewed for schema issues; any changes should be made at the code generation source.

Applied to files:

.changeset/neat-items-tan.md

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Avoid string allocations by comparing against `&str` or using `TokenText`

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Add `deprecated` field to `declare_lint_rule!` macro when deprecating a rule

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/lib/**/*.rs : Use `rename_all = "camelCase"` in serde derive macro for rule options

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Set `version` field to `next` in `declare_lint_rule!` macro

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Assist rules should detect refactoring opportunities and emit code action signals

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Use `domains` field in `declare_lint_rule!` to tag rules that belong to specific concepts like testing or frameworks

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/nursery/**/*.rs : Add `issue_number` field to `declare_lint_rule!` macro for work-in-progress rules

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-12-22T09:26:56.943Z

Learnt from: ematipico
Repo: biomejs/biome PR: 8537
File: crates/biome_js_analyze/src/lint/nursery/no_leaked_render.rs:167-210
Timestamp: 2025-12-22T09:26:56.943Z
Learning: When defining lint rules (declare_lint_rule!), only specify fix_kind if the rule implements an action(...) function. Rules that only emit diagnostics without a code fix should omit fix_kind. This applies to all Rust lint rule definitions under crates/.../src/lint (e.g., crates/biome_js_analyze/src/lint/...).

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Set `language` field in `declare_lint_rule!` macro to the language the rule primarily applies to

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Use language-specific rule names if the rule is meant for a specific language only

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-11-24T18:05:27.810Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:27.810Z
Learning: Applies to crates/biome_js_formatter/**/*.rs : When formatting AST nodes, use mandatory tokens from the AST instead of hardcoding token strings (e.g., use `node.l_paren_token().format()` instead of `token("(")`)

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Use `Semantic<>` query type to access semantic model information like scopes and declarations

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-11-24T18:05:27.810Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:27.810Z
Learning: Applies to crates/biome_js_formatter/**/*.rs : Import the `FormatNode` trait and implement it for your Node when creating formatters in biome_js_formatter

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-11-24T18:05:42.356Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_type_info/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:42.356Z
Learning: Applies to crates/biome_js_type_info/**/local_inference.rs : Implement local inference in dedicated modules to derive type definitions from expressions without context of surrounding scopes

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-11-24T18:06:03.545Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_parser/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:03.545Z
Learning: Applies to crates/biome_parser/**/src/**/*.rs : Use `ConditionalParsedSyntax` for syntax that is only valid in specific contexts (e.g., strict mode, file types, language versions) and call `or_invalid_to_bogus()` to convert to a bogus node if not supported

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-12-19T12:53:30.399Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-12-19T12:53:30.399Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/**/*.rs : Check if a variable is global using the semantic model to avoid false positives

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-11-24T18:05:27.810Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:27.810Z
Learning: Applies to crates/biome_js_formatter/**/*.rs : Do not attempt to 'fix' the code; if a token/node is known to be mandatory but is missing, return `None` instead

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-11-24T18:05:42.356Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_type_info/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:42.356Z
Learning: Applies to crates/biome_js_type_info/**/js_module_info/collector.rs : Implement module-level (thin) inference to resolve `TypeReference::Qualifier` variants by looking up declarations in module scopes and handling import statements

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-11-24T18:05:42.356Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_type_info/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:42.356Z
Learning: Applies to crates/biome_js_type_info/**/scoped_resolver.rs : Implement full inference to resolve `TypeReference::Import` variants across the entire module graph

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

📚 Learning: 2025-11-24T18:05:27.810Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:27.810Z
Learning: Applies to crates/biome_js_formatter/**/*.rs : For tokens that are not mandatory, use helper functions instead of hardcoding

Applied to files:

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)

GitHub Check: Test (depot-windows-2022-16)
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Check Dependencies
GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: Documentation
GitHub Check: End-to-end tests
GitHub Check: autofix
GitHub Check: Bench (biome_js_analyze)
GitHub Check: Bench (biome_js_parser)
GitHub Check: Test Node.js API
GitHub Check: Bench (biome_js_formatter)

🔇 Additional comments (7)

.changeset/neat-items-tan.md (1)

1-5: LGTM!

The changeset correctly documents this as a patch-level performance improvement. The description is concise and accurately reflects the TokenText optimisation. Based on learnings, performance improvements are user-facing and warrant a changeset.

crates/biome_js_analyze/src/lint/suspicious/no_redeclare.rs (6)

9-9: LGTM!

Correct import addition for TokenText. Based on learnings, using TokenText is the recommended approach to avoid string allocations in analyzer rules.

76-81: Nice optimisation!

Switching from Box<str> to TokenText eliminates the heap allocation per redeclaration. The ~44% improvement mentioned in the PR (1 ms → 560 µs) is a solid win.

149-155: LGTM!

The let-else pattern cleanly handles the fallible name_token() call, and token_text_trimmed() gives us the zero-allocation TokenText for the map key.

167-171: LGTM!

Clever use of name.text() for the lookup — avoids creating a redundant TokenText since FxHashMap supports lookup by borrowed form. The TokenText is only stored when actually needed (line 195).

188-195: LGTM!

The TokenText is moved directly into the Redeclaration struct and the declarations map without any intermediate allocations. Clean finish to the optimisation.

121-121: LGTM!

Map key type correctly updated to TokenText. This is the foundation that enables the allocation-free lookups throughout the function.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codspeed-hq · 2025-12-24T17:14:28Z

CodSpeed Performance Report

Merging #8571 will not alter performance

_{Comparing dyc3/perf-no-redeclare (b91b470) with main (d80fa41)¹}

Summary

✅ 58 untouched
⏩ 95 skipped²

No successful run was found on main (1022c76) during the generation of this report, so d80fa41 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
95 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

dyc3 mentioned this pull request Dec 24, 2025

feat(cli): rule profiler #8562

Merged

github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Dec 24, 2025

dyc3 marked this pull request as ready for review December 24, 2025 15:00

dyc3 force-pushed the dyc3/perf-no-redeclare branch from da38b9e to 6ae937d Compare December 24, 2025 15:03

dyc3 requested review from a team December 24, 2025 16:31

ematipico approved these changes Dec 24, 2025

View reviewed changes

perf(noRedeclare): reduce string allocations

b153388

dyc3 changed the base branch from dyc3/profile-rules to graphite-base/8571 December 24, 2025 16:53

dyc3 force-pushed the graphite-base/8571 branch from 2603078 to 1022c76 Compare December 24, 2025 16:53

dyc3 force-pushed the dyc3/perf-no-redeclare branch from 6ae937d to b153388 Compare December 24, 2025 16:53

dyc3 changed the base branch from graphite-base/8571 to main December 24, 2025 16:53

trigger ci

b91b470

dyc3 merged commit 03666fd into main Dec 24, 2025
19 checks passed

dyc3 deleted the dyc3/perf-no-redeclare branch December 24, 2025 17:18

github-actions bot mentioned this pull request Dec 24, 2025

ci: release #8507

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

perf(noRedeclare): reduce string allocations#8571

perf(noRedeclare): reduce string allocations#8571
dyc3 merged 2 commits intomainfrom
dyc3/perf-no-redeclare

dyc3 commented Dec 24, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 24, 2025 •

edited

Loading

Uh oh!

dyc3 commented Dec 24, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 24, 2025

Uh oh!

codspeed-hq bot commented Dec 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

dyc3 commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Docs

Uh oh!

changeset-bot bot commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

dyc3 commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Dec 24, 2025

Walkthrough

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

codspeed-hq bot commented Dec 24, 2025

CodSpeed Performance Report

Merging #8571 will not alter performance

Summary

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dyc3 commented Dec 24, 2025 •

edited

Loading

changeset-bot bot commented Dec 24, 2025 •

edited

Loading

dyc3 commented Dec 24, 2025 •

edited

Loading