feat: apply code fixes to embedded snippets in JS #8662

siketyan · 2026-01-03T10:01:13Z

Summary

Added support for applying code fixes to embedded snippets in JavaScript. This is a follow-up PR for #7973 and #8376.

Test Plan

Added some snapshot tests.

Docs

N/A

changeset-bot · 2026-01-03T10:01:17Z

⚠️ No Changeset found

Latest commit: d6fd6cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 14 packages

Name	Type
@biomejs/biome	Minor
@biomejs/cli-win32-x64	Minor
@biomejs/cli-win32-arm64	Minor
@biomejs/cli-darwin-x64	Minor
@biomejs/cli-darwin-arm64	Minor
@biomejs/cli-linux-x64	Minor
@biomejs/cli-linux-arm64	Minor
@biomejs/cli-linux-x64-musl	Minor
@biomejs/cli-linux-arm64-musl	Minor
@biomejs/wasm-web	Minor
@biomejs/wasm-bundler	Minor
@biomejs/wasm-nodejs	Minor
@biomejs/backend-jsonrpc	Patch
@biomejs/js-api	Major

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-01-03T10:04:04Z

Walkthrough

Adds new CLI tests for embedded-language diagnostics and auto-fixes in JavaScript files (crates/biome_cli/tests/cases/javascript.rs) and registers the module in tests. Makes biome_js_factory a required dependency in crates/biome_service/Cargo.toml and removes it from the schema feature. Implements update_snippets in the JavaScript file handler (crates/biome_service/src/file_handlers/javascript.rs), exposes UpdateSnippetsNodes, and wires the function into the handler capabilities.

Possibly related PRs

feat: support formatting GraphQL in JS #8376: Modifies the JavaScript file handler for GraphQL-in-JS parsing/formatting and relates to embedded-snippet handling and tests added here.
feat(core): apply code fixes in snippets #7670: Implements update_snippets support and integrates it into the JavaScript file handler — closely matches the new handler wiring and behaviour.

Suggested labels

A-Formatter, A-Linter, A-Parser, L-JavaScript

Suggested reviewers

ematipico
dyc3
arendjr

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarises the main change: applying code fixes to embedded snippets in JavaScript, which is the primary focus of the changeset.
Description check	✅ Passed	The description is directly related to the changeset, explaining the feature addition and referencing follow-up PRs, with test plan details provided.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 185a16f and d6fd6cd.

📒 Files selected for processing (2)

.changeset/full-berries-follow.md
.changeset/short-points-tie.md

🚧 Files skipped from review as they are similar to previous changes (1)

.changeset/full-berries-follow.md

🧰 Additional context used

🧠 Learnings (7)

📓 Common learnings

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:20.371Z
Learning: Applies to crates/biome_formatter/**/biome_*_formatter/tests/language.rs : Implement `TestFormatLanguage` trait in `tests/language.rs` for the formatter's test language

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/tests/specs/**/*.jsonc : Use `.jsonc` format for test files containing multiple code snippets, where each snippet is a string in an array

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_parser/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:03.545Z
Learning: Create two new crates `biome_{language}_syntax` and `biome_{language}_factory` using `cargo new --lib` for new language parsers

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:20.371Z
Learning: Applies to crates/biome_formatter/**/biome_*_formatter/tests/spec_tests.rs : Use the `tests_macros::gen_tests!` macro in `spec_tests.rs` to generate test functions for each specification file matching the pattern `tests/specs/<language>/**/*.<ext>`

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:20.371Z
Learning: Applies to crates/biome_formatter/**/biome_*_formatter/Cargo.toml : Include development dependencies in `Cargo.toml` for formatter tests: `biome_formatter_test`, `biome_<language>_factory`, `biome_<language>_parser`, `biome_parser`, `biome_service`, `countme`, `iai`, `quickcheck`, `quickcheck_macros`, and `tests_macros`

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:12.048Z
Learning: Applies to crates/biome_service/src/workspace/watcher.tests.rs : Implement watcher tests for workspace methods in watcher.tests.rs and end-to-end tests in LSP tests

Learnt from: dyc3
Repo: biomejs/biome PR: 8291
File: crates/biome_html_formatter/tests/specs/prettier/vue/html-vue/elastic-header.html:10-10
Timestamp: 2025-12-04T13:29:49.287Z
Learning: Files under `crates/biome_html_formatter/tests/specs/prettier` are test fixtures synced from Prettier and should not receive detailed code quality reviews (e.g., HTTP vs HTTPS, formatting suggestions, etc.). These files are test data meant to validate formatter behavior and should be preserved as-is.

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Implement the `diagnostic` function to provide error messages explaining what the error is, why it is triggered, and what the user should do

📚 Learning: 2025-12-21T21:15:03.796Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-12-21T21:15:03.796Z
Learning: For formatter changes in changesets, show formatting changes using diff code blocks

Applied to files:

.changeset/short-points-tie.md

📚 Learning: 2025-12-21T21:15:03.796Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-12-21T21:15:03.796Z
Learning: Changesets should be concise (1-3 sentences) and provide quick overview of changes without overwhelming details

Applied to files:

.changeset/short-points-tie.md

📚 Learning: 2025-12-21T21:15:03.796Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-12-21T21:15:03.796Z
Learning: Changesets should describe user-facing changes only; internal refactoring without behavior changes does not require a changeset

Applied to files:

.changeset/short-points-tie.md

📚 Learning: 2025-12-21T21:15:03.796Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-12-21T21:15:03.796Z
Learning: For new lint rules in changesets, show an example of invalid case in inline code or code block

Applied to files:

.changeset/short-points-tie.md

📚 Learning: 2025-11-24T18:05:27.810Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:27.810Z
Learning: Applies to crates/biome_js_formatter/**/*.rs : Import the `FormatNode` trait and implement it for your Node when creating formatters in biome_js_formatter

Applied to files:

.changeset/short-points-tie.md

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/tests/specs/**/*.jsonc : Use `.jsonc` format for test files containing multiple code snippets, where each snippet is a string in an array

Applied to files:

.changeset/short-points-tie.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: Check Dependencies
GitHub Check: End-to-end tests
GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Documentation
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: autofix

🔇 Additional comments (2)

.changeset/short-points-tie.md (2)

5-7: Accurate description of the expanded feature scope.

The updates correctly reflect that both formatting and linting are now supported for embedded CSS snippets.

47-47: Grammar correction applied.

Properly removes the unnecessary "in" for correct phrasing.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

ematipico

Do we need a changeset and/or update the docs?

siketyan · 2026-01-12T10:20:42Z

Do we need a changeset and/or update the docs?

I've modified the changesets I previously added to clarify that linting snippets is now supported.

feat: apply code fixes to embedded snippets in JS

45a4c05

siketyan requested review from a team January 3, 2026 10:01

siketyan self-assigned this Jan 3, 2026

github-actions bot added A-CLI Area: CLI A-Project Area: project labels Jan 3, 2026

chansuke approved these changes Jan 5, 2026

View reviewed changes

ematipico approved these changes Jan 5, 2026

View reviewed changes

siketyan added 2 commits January 12, 2026 19:19

Merge branch 'next' into feat/js-embed-code-fixes

7fdce7a

chore: modify changeset

185a16f

This comment was marked as resolved.

Sign in to view

chore: apply feedback

d6fd6cd

siketyan merged commit c594a36 into biomejs:next Jan 12, 2026
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: apply code fixes to embedded snippets in JS #8662

feat: apply code fixes to embedded snippets in JS #8662

Uh oh!

siketyan commented Jan 3, 2026

Uh oh!

changeset-bot bot commented Jan 3, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 3, 2026 •

edited

Loading

Uh oh!

ematipico left a comment

Uh oh!

siketyan commented Jan 12, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat: apply code fixes to embedded snippets in JS #8662

feat: apply code fixes to embedded snippets in JS #8662

Uh oh!

Conversation

siketyan commented Jan 3, 2026

Summary

Test Plan

Docs

Uh oh!

changeset-bot bot commented Jan 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Jan 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

ematipico left a comment

Choose a reason for hiding this comment

Uh oh!

siketyan commented Jan 12, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Jan 3, 2026 •

edited

Loading

coderabbitai bot commented Jan 3, 2026 •

edited

Loading