fix(core): correct deletion index calculation for char indices#668
Merged
morgante merged 3 commits intobiomejs:mainfrom Dec 1, 2025
Merged
fix(core): correct deletion index calculation for char indices#668morgante merged 3 commits intobiomejs:mainfrom
morgante merged 3 commits intobiomejs:mainfrom
Conversation
Update get_deletion_indices to use byte indices instead of char indices when checking deletion ranges. This ensures accurate handling of Unicode characters and prevents off-by-one errors during range checks.
3b69346 to
e8993dc
Compare
2b1b47c to
40b72f6
Compare
morgante
approved these changes
Dec 1, 2025
Collaborator
morgante
left a comment
There was a problem hiding this comment.
Looks good, just need to fix the clippy error: https://github.com/honeycombio/gritql/actions/runs/19609104889/job/56742391741?pr=668#step:6:12
morgante
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Change
How to verify that this has the expected result
add test: