Thanks to visit codestin.com
Credit goes to github.com

Skip to content

all arity-specific methods are broken#78

Merged
eparejatobes merged 3 commits intomasterfrom
bug/arity/methods/broken/78
Jun 8, 2016
Merged

all arity-specific methods are broken#78
eparejatobes merged 3 commits intomasterfrom
bug/arity/methods/broken/78

Conversation

@eparejatobes
Copy link
Member

@eparejatobes eparejatobes commented Jun 8, 2016

No description provided.

@laughedelic
Copy link
Member

laughedelic commented Jun 8, 2016

😱

@laughedelic
Copy link
Member

laughedelic commented Jun 8, 2016

What happened?

@eparejatobes
Copy link
Member Author

eparejatobes commented Jun 8, 2016

just pushed

@eparejatobes
Copy link
Member Author

eparejatobes commented Jun 8, 2016

EdgeType needs to refer to itself in TypedGraph, otherwise you just know about it source and target. This is wrong:

angulillos/src/main/java/com/bio4j/angulillos/TypedGraph.java

Lines 216 to 234 in 7ca8381

> extends Element<E, EdgeType<S,E,T>, RE>
implements TypedEdge<
S, VertexType<S>,
E, EdgeType<S,E,T>,
T, VertexType<T>,
G,RV,RE
> {
protected Edge(RE raw, EdgeType<S,E,T> type) { super(raw, type); }
}
public abstract class EdgeType<
S extends Vertex<S>,
E extends Edge<S,E,T>,
T extends Vertex<T>
> extends ElementType<E, EdgeType<S,E,T>, RE>
implements TypedEdge.Type<
S, VertexType<S>,
E, EdgeType<S,E,T>,

@eparejatobes
Copy link
Member Author

eparejatobes commented Jun 8, 2016

That, or making on EdgeType class per Arity combination in TypedGraph

@eparejatobes
Copy link
Member Author

eparejatobes commented Jun 8, 2016

There's a super-easy unsafe fix though, that could be enough

@eparejatobes
Copy link
Member Author

eparejatobes commented Jun 8, 2016

@laughedelic doing this? if not, will do

@laughedelic
Copy link
Member

laughedelic commented Jun 8, 2016 •
edited
Loading

So what's your plan?

@eparejatobes
Copy link
Member Author

eparejatobes commented Jun 8, 2016

to fix it!

@eparejatobes eparejatobes merged commit fac9441 into master Jun 8, 2016
@eparejatobes eparejatobes deleted the bug/arity/methods/broken/78 branch June 8, 2016 15:57
eparejatobes added a commit that referenced this pull request Jun 8, 2016
@eparejatobes
Setting version to 0.9.0:
db77872 
This release fixes #78, which made impossible to use arity-specific methods (inOneV, outAtMostOneV, ...) when using TypedGraph inner classes. Everyone should update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@laughedelic laughedelic

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eparejatobes @laughedelic